From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38963462CC; Wed, 26 Feb 2025 21:13:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2EE94029F; Wed, 26 Feb 2025 21:13:05 +0100 (CET) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id 03BEA4029F for ; Wed, 26 Feb 2025 21:13:05 +0100 (CET) Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3cf8e017abcso966335ab.1 for ; Wed, 26 Feb 2025 12:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1740600784; x=1741205584; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ws+8PV/NOMOIjDbQwBA6QjuisGMCANFWr87lo8Mpkk4=; b=CraJRl5Tfxwek5kMygQH8uM8rNW6wgqgWxTOwYMFz3FBwoUIi0F2YY+nzWcwNhfxyf qK2qqq383aNFZzyJolieEqQsrl+R/Xh0+jQ2vKrU5RBI5OnmrqyK9L+p5iVKg5dGJ4T3 I/LMXF+Ni+BpNjrJtT4zFYQg+VxCRLjc30fDNNWqy5EbY9hY347mXUUofVc6a+a8wV/G bUmnK6hHPHwjxv1teYaZI4uFS+3qI4xsH1sD0+QIm5Flf39r7jWWwaQwS6Qa/jjIxrJL rlIUGB8UQoKHH36pQGSK83ru9r7PFxPrWfGXKjqX14d8PCYzpyVMLB/mIoGHA8UiVxot XYFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740600784; x=1741205584; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ws+8PV/NOMOIjDbQwBA6QjuisGMCANFWr87lo8Mpkk4=; b=BlZVFLMFxGS2pjvwA2n2Qw2IrFgcWRRytO4m4J93TMK/254+ckUvw5jNxFimPn3SHG S7QHW/U8rEPtNwxvH+PXf7428krsOtpDpdo7hhtnIqmrxvL5ad9v9eOB9mey808M5rsl 4yBY+y7sG4BcqufSPg+oYUk3TLz/lCTtWaBqS0tEDtxqjVFr2uyvbwnklBtQUVjEY+2k 9A/BYbnvUbf9+jR1ihdTLgHYs48MHB09l3VVDzzBpZbIhV7FK+KqIlhNrw8SzlvrWhtm E7r1NgAnmoEgq4c2va3sO5kAj/PKAnA5Lm4iascvSOVBvB7D4rMhltE3ZPqNhFxYEEUb /E9w== X-Gm-Message-State: AOJu0YzSPTSe//DbZ5j6FPTuB1jpZVpRgd7s1Fii3dLE7SAwGCChJ/GT RwDDudkc2IsRH7qHjVSXrG0n2dOIU0w+wVY6mCXXrmSTPgMvh8jTquTVewaHh0H92Yd4o5e1VT1 fTVEZG1GfEgtOKtquhclcvXsQBVHPUBdMq4RoXw== X-Gm-Gg: ASbGnct8/Ru0CZO0F7luBgXNG+Qy8ak14km3ndTSuJf/aEpKFbsrjnL9Z1k2Cyik6Eo zD2IKwD71MQLuzTrfmjTCmrIW1yM+dRCP+ievtnBjgFWstLz+AdEz5m/j6wFJeu+1COXKP/wDM6 vJNpSPBdA0P5r7TKVs/apaQ4XWYWc0k/UjP8uv6Yk= X-Google-Smtp-Source: AGHT+IGo3QrjiuLr/CcQ2zHvKzt0cl4IZfDEPDDN44HOEeG9OYWqI9NKj2rTygKglQP5qgHRtcR36msbtf+bQRkLHTI= X-Received: by 2002:a05:6e02:1608:b0:3d0:47cf:869c with SMTP id e9e14a558f8ab-3d30488b517mr87403805ab.19.1740600784221; Wed, 26 Feb 2025 12:13:04 -0800 (PST) MIME-Version: 1.0 References: <20250116195640.68885-1-ariel.otilibili@6wind.com> <20250131231018.2163893-3-ariel.otilibili@6wind.com> <20250224112534.684c19c6@hermes.local> In-Reply-To: <20250224112534.684c19c6@hermes.local> From: Ariel Otilibili Date: Wed, 26 Feb 2025 21:12:51 +0100 X-Gm-Features: AQ5f1JoF9B3JyrQnJ0O9SoqsW0UEGJWyTEYoxUrH_h-yhwj5iYv-0hCbtAl5I6M Message-ID: Subject: Re: [PATCH v6 2/2] net/af_xdp: Refactor af_xdp_tx_zc To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , David Marchand , Maryam Tahhan , Ciara Loftus Content-Type: multipart/alternative; boundary="0000000000007097f9062f113380" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000007097f9062f113380 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Stephen, On Mon, Feb 24, 2025 at 8:25=E2=80=AFPM Stephen Hemminger < stephen@networkplumber.org> wrote: > > Please avoid doing assignment in a conditional statement, can be error > prone. > Surprised checkpatch doesn't complain about it. > Thanks for the feedback. checkpatch did catch them. Here is the new series, https://inbox.dpdk.org/dev/20250226200841.2342632-3-ariel.otilibili@6wind.c= om/ Regards, Ariel > > Better as: > desc =3D reserve_and_fill(txq, mbuf, umem); > if (!desc) { > kick_tx(txq, cq); > desc =3D reserve_and_fill(txq, mbuf, umem= ); > if (!desc) > goto out; > --0000000000007097f9062f113380 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Stephen,

O= n Mon, Feb 24, 2025 at 8:25=E2=80=AFPM Stephen Hemminger <stephen@networkplumber.org> wrote:

Please avoid doing assignment in a conditional statement, can be error pron= e.
Surprised checkpatch doesn't complain about it.
Thanks for the feedback. checkpatch did catch them.
=

Regards,
Ariel

Better as:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 desc =3D reserve_and_fill(txq, mbuf, umem);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 if (!desc) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 kick_tx(txq, cq);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 desc =3D reserve_and_fill(txq, mbuf,= umem);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!desc)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 goto out= ;
--0000000000007097f9062f113380--