From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 277195963 for ; Mon, 5 Jan 2015 00:10:47 +0100 (CET) Received: by mail-pd0-f182.google.com with SMTP id p10so26793199pdj.41 for ; Sun, 04 Jan 2015 15:10:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+qMdXdUBVslhEurwcgvKYnx23SCWoEanHYxE6ZOecJ8=; b=lQl+pgNs+kOT8XhKLIQc39K7SCbBHT5EbwQHp6trFGJ7tGKp6wec6c1oS6PT8YXEfd 8kTSC3ObVDobMsKsbaogOhTl/P0unjeFQxZybCOtAJbN2sYiTZt8oyQIPB1oJOPww/Ry NTjXbSviA6ISLchSyl4EcTiURohu9dtkXOD1R+3bfsT60NkuNOYpPJI9GS4BIYoS2gjW oytEs6PRLxAuWToGVYXfy9XPUDU3D0qBqZYJsKsZCS09GCzxbG29+p45du+++doYUIMS zsdj2oIJi6guIEDEFL/r+CWlCVr4qUsktA6zzcCjmub9LmkwFVd4G1qf3DdXehASOXNJ vZNA== MIME-Version: 1.0 X-Received: by 10.66.150.74 with SMTP id ug10mr143109699pab.68.1420413046137; Sun, 04 Jan 2015 15:10:46 -0800 (PST) Received: by 10.70.114.233 with HTTP; Sun, 4 Jan 2015 15:10:46 -0800 (PST) In-Reply-To: References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <54A11509.5050904@6wind.com> <20141229124723.GA27775@localhost.localdomain> <54A15420.2010401@6wind.com> Date: Sun, 4 Jan 2015 15:10:46 -0800 Message-ID: From: Ravi Kerur To: Olivier MATZ Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jan 2015 23:10:47 -0000 Hi, I plan to work on this and would like to know if I need consider anything else other than mentioned in the email by Olivier/Neil i.e.go with 2 directories common-os/generic-os common-posix under librte_eal directory and move relevant files accordingly. Thanks, Ravi On Mon, Dec 29, 2014 at 10:43 AM, Ravi Kerur wrote: > Thanks Olivier and Neil. I will make a note on this and will work on it > after initial common code movement is completed. > > > On Mon, Dec 29, 2014 at 5:16 AM, Olivier MATZ > wrote: > >> Hi Neil, >> >> On 12/29/2014 01:47 PM, Neil Horman wrote: >> > On Mon, Dec 29, 2014 at 09:47:05AM +0100, Olivier MATZ wrote: >> >> Trying to factorize the common code goes in the good direction. >> >> >> >> However I'm wondering if "common" is the proper place. Initially, >> >> the common directory was for code common to linuxapp and baremetal. >> >> Now that baremetal does not exist anymore, a lot of code is common >> >> to the 2 OSes that are supported (linux and FreeBSD). >> >> >> >> What about moving this code in "common-posix" instead? >> >> It would let the door open for future ports (Windows? or any >> >> other real time OS? Or back in baremetal?). >> >> >> > Posix doesn't make sense IMO, in that a large segment of the functions >> embodied >> > in the common directory have nothing to do with posix API's, and are >> simply just >> > useful functions that have not OS specific dependency (the entire >> > eal_common_memory.c file for example, to name just one). >> > >> > If you wanted to rename the directory, I would say generic-os would be >> more >> > appropriate. >> >> That's probably right for most of the code in the patch. I just wanted >> to point out that "common" is sometimes a bit vague (common to archs, >> common to OSes, common to all). >> >> From a quick look, these 2 files could be concerned and could go to a >> common-posix directory: >> - eal.c (use fopen/ftruncate/fcntl/mmap/...) >> - eal_thread.c (use pipe/read/write) >> >> There's no urgency to do that now and maybe we should wait it's really >> needed. I was just seizing the opportunity as the code is moved. >> >> Regards, >> Olivier >> > >