From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 5B2EE5A06 for ; Mon, 29 Dec 2014 19:43:16 +0100 (CET) Received: by mail-pd0-f179.google.com with SMTP id fp1so17680893pdb.24 for ; Mon, 29 Dec 2014 10:43:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=P4VObSDTf848Vo/zfGMUXZseyiTuXvwMM8FTT021I0w=; b=wq99MV3dmwJHktoQiMk01hOTfxexkri21eQC9Qe+aMDEUoH1NF5xG7NvaaWV3Kk5uA EuyvfjKllppXyVXJtDxWV8w+irPcWu53h31KXTUN99LniG5RoTTFmBuzaJ4ivivV9W58 Tbwp4AidKuqNio4xfsN+10eQQdwzy9wXsxsfT3AAlH/1VL5zPtXsnIjaPEdGG+r4sjVF T+1EBhTPkyhKgGXiic7u2pKWHB9Y0edo0mZgV8Hr2gj/QF2C4AC4EWZgvHq0eaGrNPsN Gj0NfRGX/Giuq/ijoxQFTLn+E6/paahJcPs3rkbiyb+PO3TXOSs5KS3RHKqblx0Y0iD6 Zb5g== MIME-Version: 1.0 X-Received: by 10.66.166.171 with SMTP id zh11mr93083878pab.85.1419878595405; Mon, 29 Dec 2014 10:43:15 -0800 (PST) Received: by 10.70.114.233 with HTTP; Mon, 29 Dec 2014 10:43:15 -0800 (PST) In-Reply-To: <54A15420.2010401@6wind.com> References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <54A11509.5050904@6wind.com> <20141229124723.GA27775@localhost.localdomain> <54A15420.2010401@6wind.com> Date: Mon, 29 Dec 2014 10:43:15 -0800 Message-ID: From: Ravi Kerur To: Olivier MATZ Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2014 18:43:17 -0000 Thanks Olivier and Neil. I will make a note on this and will work on it after initial common code movement is completed. On Mon, Dec 29, 2014 at 5:16 AM, Olivier MATZ wrote: > Hi Neil, > > On 12/29/2014 01:47 PM, Neil Horman wrote: > > On Mon, Dec 29, 2014 at 09:47:05AM +0100, Olivier MATZ wrote: > >> Trying to factorize the common code goes in the good direction. > >> > >> However I'm wondering if "common" is the proper place. Initially, > >> the common directory was for code common to linuxapp and baremetal. > >> Now that baremetal does not exist anymore, a lot of code is common > >> to the 2 OSes that are supported (linux and FreeBSD). > >> > >> What about moving this code in "common-posix" instead? > >> It would let the door open for future ports (Windows? or any > >> other real time OS? Or back in baremetal?). > >> > > Posix doesn't make sense IMO, in that a large segment of the functions > embodied > > in the common directory have nothing to do with posix API's, and are > simply just > > useful functions that have not OS specific dependency (the entire > > eal_common_memory.c file for example, to name just one). > > > > If you wanted to rename the directory, I would say generic-os would be > more > > appropriate. > > That's probably right for most of the code in the patch. I just wanted > to point out that "common" is sometimes a bit vague (common to archs, > common to OSes, common to all). > > From a quick look, these 2 files could be concerned and could go to a > common-posix directory: > - eal.c (use fopen/ftruncate/fcntl/mmap/...) > - eal_thread.c (use pipe/read/write) > > There's no urgency to do that now and maybe we should wait it's really > needed. I was just seizing the opportunity as the code is moved. > > Regards, > Olivier >