From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id ACB723DC for ; Sat, 4 Mar 2017 20:49:23 +0100 (CET) Received: by mail-pf0-f171.google.com with SMTP id x66so44254188pfb.3 for ; Sat, 04 Mar 2017 11:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AklYCdOpChXTWTohnewHB2oOK//aCjMG9yvXaO23t9k=; b=kL3pC4dAbhpbL9us1OPzy2O8JFA4UXRZgh1upZPoYD98kD0sMmDXeBx/f7Ejyet1dO FXBeQ1/FVkbrR+XdYSKb7Sdk206ffdPsx3Epue6bN2l7m2Hf0c0jYDEeC9nMYgD7RdpC p5Kr2ZlOEtvmbWHS/ipcSfgQAdmuOs48TeCAT+M5jlRp4D+EZ0sIN76+NaXQ32ATFa6x +enHkBV59zL2rSa8G5nAh6EGoKdGysw+NzRYs5ikANhJt+/bECwrSSR5GW53RdqopaZW wq+zRMlLW8267kRPGSw6hsY6GLsQpHg9BLUL2/5g6ETrclb9Vh161U7fAsgSGmaMqioJ QvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AklYCdOpChXTWTohnewHB2oOK//aCjMG9yvXaO23t9k=; b=aQFyjK73LN+Ljps8H41EaT8vvnH0DBoX1MYIlZBC5p3XEhiyRNrzenl8QaAozJhFYb syahGMcJiE/mBPPKQmfJ3ypM+0T+Z87GSs32lkfOn8jq1gqHUAjtSDb4NjAk2JqTwKdU YV6jg0SaGnaSiTo6ssMFA3szNaGugJBbdRLiImI/rJXpidLtGVwfkY1QgqbgvjVD4nh8 7OqWsY381vxUOzp/eW5ypZylD6vlvQI4Sgo1DNvBHv4RzDZ38Xcdcl6wlb2RXKHgfquv TFZmJaJuAj9zMhoRLraHEkVCSibSK2F5roOvyvPix5CUYf2xqpmJ1TnWJcdjkjcmj8Yq GSOg== X-Gm-Message-State: AMke39lafEeixoxQBLJ7aloSF2+wcZN7jkrHX6Q+J5A46hvY7JrLsKhk85gxcPA1BmciX7CLTuvYkcWXcIv5jw== X-Received: by 10.84.217.199 with SMTP id d7mr13952488plj.80.1488656962796; Sat, 04 Mar 2017 11:49:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.128.202 with HTTP; Sat, 4 Mar 2017 11:49:22 -0800 (PST) In-Reply-To: References: <1485550795-10771-1-git-send-email-rkerur@gmail.com> <2601191342CEEE43887BDE71AB9772583F11EA2A@irsmsx105.ger.corp.intel.com> From: Ravi Kerur Date: Sat, 4 Mar 2017 11:49:22 -0800 Message-ID: To: "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Richardson, Bruce" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 19:49:24 -0000 Hi Konstantin, I have sent 'v2' patchset. I need clarifications on following things, if they should be fixed I will send out 'v3' so please let me know. Following code changes were done by me manually, not merged. +++ b/examples/l3fwd/main.c @@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf = { .rx_adv_conf = { .rss_conf = { .rss_key = NULL, - .rss_hf = ETH_RSS_IP, + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | + ETH_RSS_TCP | ETH_RSS_SCTP, + }, The reason I did it is because LPM/EM has .rss_hf = ETH_RSS_IP ACL has .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP | ETH_RSS_SCTP, ACL looks like a superset of LPM/EM and functional testing didn't reveal any issues hence I kept ACL version. 2. Checkpatch errors are all fixed. Some warnings are not fixed and they are 2.a, string length greater than 80 characters 2.b GET_CB_FIELD macro. I could have changed GET_CB_FIELD to inline function, however, function names cannot be in capital letters. I could have changed it to 'get_cb_field' inline function, but didn't do it as I thought it may not be worth the change. Let me know your inputs. Thanks. On Wed, Mar 1, 2017 at 7:29 AM, Ravi Kerur wrote: > Hi Konstantin, > > Thank you for the review. > > RSS hash value changes could be due to merge, I didn't make that change. I > will go through the changes and fix it in 'v2' patch along with RFC removed > and checkpatch fix. > > Thanks. > > On Tue, Feb 28, 2017 at 2:36 AM, Ananyev, Konstantin < > konstantin.ananyev@intel.com> wrote: > >> Hi Ravi, >> >> > >> > Thanks to Konstantin and Bruce on first internal review comments. This >> > patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file >> > read options to build LPM and EM tables. >> >> >> Thanks for the patch, I think it is really useful one. >> Can I suggest you re-submit it as non-RFC now, as we are in 17.05 window >> already? >> About the patch itself, one question I forgot to ask you before: >> >> +++ b/examples/l3fwd/main.c >> @@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf = { >> .rx_adv_conf = { >> .rss_conf = { >> .rss_key = NULL, >> - .rss_hf = ETH_RSS_IP, >> + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | >> + ETH_RSS_TCP | ETH_RSS_SCTP, >> + >> }, >> }, >> >> >> Why it is necessary to change RSS hash input values? >> >> As another nit - there are few checkpatch warnings, that probably need >> to be addressed. >> Apart from that looks good to me. >> Thanks >> Konstantin >> >> >> >