From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com
 [209.85.214.173]) by dpdk.org (Postfix) with ESMTP id 8E26D36E
 for <dev@dpdk.org>; Wed, 30 Sep 2015 23:55:57 +0200 (CEST)
Received: by obbbh8 with SMTP id bh8so43078700obb.0
 for <dev@dpdk.org>; Wed, 30 Sep 2015 14:55:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=rn4Ugh+c2Rd08Z7zg12+TZwLOnb2Rl4XDkSZzv8/EMk=;
 b=06w1KKPel4fF3XkueunSmTjOCStO3r6yuzWgdWt7mKZ/iDxWrJEV7iVF/VzIt+d+Qs
 8+AvtZQ2qxLWu62deGkaG5ZQagyRhBtS3gaDJToHJRle2Rge8Z+lITS4OKQqDw9iFP8b
 aS5jnw+0/xJNRHScDJKW69nLIm+RC50gZxsWBXEquGnhv4qFKOotKy04nV8zBONyIk8f
 6jO/TiNssKqaMVhG3nY1k+RwzULVaRxmLFlOAamn/MThXOHjP815kM1NwcFZmKrclh/n
 FxE1VQWsYiyRNJbiQbeLm7bpez8mh6n1uKR6tTLGogDRAwNKJR13aMkNTHuL6ex1c0Au
 AXDg==
MIME-Version: 1.0
X-Received: by 10.60.220.227 with SMTP id pz3mr3810300oec.13.1443650156944;
 Wed, 30 Sep 2015 14:55:56 -0700 (PDT)
Received: by 10.202.65.5 with HTTP; Wed, 30 Sep 2015 14:55:56 -0700 (PDT)
In-Reply-To: <f7tsi5vpue9.fsf@aconole.bos.csb>
References: <1443640706-3984-1-git-send-email-rkerur@gmail.com>
 <f7tsi5vpue9.fsf@aconole.bos.csb>
Date: Wed, 30 Sep 2015 14:55:56 -0700
Message-ID: <CAFb4SLAR4r3sNhucJusLYmb5Mgug3ZZgYwPpPS93EEYaji8YrQ@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Aaron Conole <aconole@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Move rte_mbuf macros to common header file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Sep 2015 21:55:58 -0000

On Wed, Sep 30, 2015 at 12:41 PM, Aaron Conole <aconole@redhat.com> wrote:

> Ravi Kerur <rkerur@gmail.com> writes:
>
> > Macros RTE_MBUF_DATA_DMA_ADDR and RTE_MBUF_DATA_DMA_ADDR_DEFAULT
> > are defined in each PMD driver file. Move those macros into common
> > lib/librte_mbuf/rte_mbuf.h file. PMD drivers include rte_mbuf.h
> > file directly/indirectly hence no additionl header file inclusion
> > is necessary.
> I think this should also mention that they are no longer macros, as
> well.
>
> <<snip>>
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -843,6 +843,16 @@ struct rte_mbuf {
> >       uint16_t timesync;
> >  } __rte_cache_aligned;
> >
> > +static inline uint64_t RTE_MBUF_DATA_DMA_ADDR(struct rte_mbuf* mb)
> > +{
> > +     return ((uint64_t)((mb)->buf_physaddr + (mb)->data_off));
> > +}
> > +
> > +static inline uint64_t RTE_MBUF_DATA_DMA_ADDR_DEFAULT(struct rte_mbuf
> *mb)
> > +{
> > +     return ((uint64_t)((mb)->buf_physaddr + RTE_PKTMBUF_HEADROOM));
> > +}
> > +
> I think these names should be made lower case as well.
>

Thanks, I was waiting for one explicit input on this. I have sent v3 patch.