* [dpdk-dev] [PATCH v6 0/6] Move common functions in EAL
@ 2015-04-18 19:42 Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
0 siblings, 1 reply; 15+ messages in thread
From: Ravi Kerur @ 2015-04-18 19:42 UTC (permalink / raw)
To: dev
Changes in v6 includes
Adding _setname_ pthread functions when threads are created. Plan
to use _getname_ when availabe in both Linux and FreeBSD.
Splitting eal.c into 4 files based on the functionality.
Simplify eal_pci changes for first series.
Testing:
Linux - Ubuntu x86_64 14.04
Compilation successful (x86_64-native-linuxapp-gcc).
"make test" results match baseline code.
testpmd utility on I217/I218 Intel chipset.
FreeBSD 10.0 x86_64
Compilation successful (x86_64-native-bsdapp-gcc).
helloworld.
Ravi Kerur (6):
Move common functions in eal_thread.c
Move common functions in eal.c
Move common functions in eal_lcore.c
Move common functions in eal_timer.c
Move common functions in eal_memory.c
Move common functions in eal_pci.c
examples/vhost/main.c | 18 +-
examples/vhost_xen/main.c | 18 +-
lib/librte_eal/bsdapp/eal/Makefile | 8 +-
lib/librte_eal/bsdapp/eal/eal.c | 278 +++---------------
lib/librte_eal/bsdapp/eal/eal_lcore.c | 72 +----
lib/librte_eal/bsdapp/eal/eal_memory.c | 47 ++-
lib/librte_eal/bsdapp/eal/eal_pci.c | 72 +----
lib/librte_eal/bsdapp/eal/eal_thread.c | 152 ----------
lib/librte_eal/bsdapp/eal/eal_timer.c | 52 +---
lib/librte_eal/common/eal_common_app_usage.c | 63 ++++
lib/librte_eal/common/eal_common_lcore.c | 107 +++++++
lib/librte_eal/common/eal_common_mem_cfg.c | 217 ++++++++++++++
lib/librte_eal/common/eal_common_memory.c | 38 ++-
lib/librte_eal/common/eal_common_pci.c | 72 +++++
lib/librte_eal/common/eal_common_proc_type.c | 58 ++++
lib/librte_eal/common/eal_common_sysfs.c | 163 +++++++++++
lib/librte_eal/common/eal_common_thread.c | 147 +++++++++-
lib/librte_eal/common/eal_common_timer.c | 102 +++++++
lib/librte_eal/common/eal_hugepages.h | 1 +
lib/librte_eal/common/eal_private.h | 171 ++++++++++-
lib/librte_eal/common/eal_thread.h | 5 +
lib/librte_eal/common/include/rte_eal.h | 4 +
lib/librte_eal/common/include/rte_pci_dev_ids.h | 8 +-
lib/librte_eal/linuxapp/eal/Makefile | 9 +
lib/librte_eal/linuxapp/eal/eal.c | 306 ++++----------------
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 +
lib/librte_eal/linuxapp/eal/eal_lcore.c | 66 +----
lib/librte_eal/linuxapp/eal/eal_memory.c | 36 +--
lib/librte_eal/linuxapp/eal/eal_pci.c | 75 +----
lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 22 +-
lib/librte_eal/linuxapp/eal/eal_thread.c | 152 +---------
lib/librte_eal/linuxapp/eal/eal_timer.c | 70 ++---
32 files changed, 1595 insertions(+), 1402 deletions(-)
create mode 100644 lib/librte_eal/common/eal_common_app_usage.c
create mode 100644 lib/librte_eal/common/eal_common_lcore.c
create mode 100644 lib/librte_eal/common/eal_common_mem_cfg.c
create mode 100644 lib/librte_eal/common/eal_common_proc_type.c
create mode 100644 lib/librte_eal/common/eal_common_sysfs.c
create mode 100644 lib/librte_eal/common/eal_common_timer.c
--
1.9.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c
2015-04-18 19:42 [dpdk-dev] [PATCH v6 0/6] Move common functions in EAL Ravi Kerur
@ 2015-04-18 19:43 ` Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c Ravi Kerur
` (5 more replies)
0 siblings, 6 replies; 15+ messages in thread
From: Ravi Kerur @ 2015-04-18 19:43 UTC (permalink / raw)
To: dev
Changes in v6
Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file.
Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD
respectively. Plan to use _getname_ in RTE_LOG when available.
Use existing rte_get_systid() in RTE_LOG to print thread_id.
Changes in v5
Rebase to latest code.
Changes in v4
None
Changes in v3
Changed subject to be more explicit on file name inclusion.
Changes in v2
None
Changes in v1
eal_thread.c has minor differences between Linux and BSD, move
entire file into common directory.
Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences.
Rename eal_thread.c to eal_common_thread.c
Makefile changes to reflect file move and name change.
Fix checkpatch warnings.
Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
examples/vhost/main.c | 18 ++-
examples/vhost_xen/main.c | 18 ++-
lib/librte_eal/bsdapp/eal/Makefile | 2 +-
lib/librte_eal/bsdapp/eal/eal.c | 7 +
lib/librte_eal/bsdapp/eal/eal_thread.c | 152 ---------------------
lib/librte_eal/common/eal_common_thread.c | 147 +++++++++++++++++++-
lib/librte_eal/common/eal_thread.h | 5 +
lib/librte_eal/linuxapp/eal/Makefile | 2 +
lib/librte_eal/linuxapp/eal/eal.c | 10 ++
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 ++
lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 22 ++-
lib/librte_eal/linuxapp/eal/eal_thread.c | 152 +--------------------
lib/librte_eal/linuxapp/eal/eal_timer.c | 15 +-
13 files changed, 250 insertions(+), 311 deletions(-)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index ad10f82..ee36525 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -2891,6 +2891,7 @@ main(int argc, char *argv[])
uint8_t portid;
uint16_t queue_id;
static pthread_t tid;
+ char thread_name[RTE_THREAD_NAME_LEN];
/* init EAL */
ret = rte_eal_init(argc, argv);
@@ -3017,8 +3018,21 @@ main(int argc, char *argv[])
memset(&dev_statistics, 0, sizeof(dev_statistics));
/* Enable stats if the user option is set. */
- if (enable_stats)
- pthread_create(&tid, NULL, (void*)print_stats, NULL );
+ if (enable_stats) {
+ snprintf(thread_name, RTE_THREAD_NAME_LEN, "vhost-stats");
+
+ ret = pthread_create(&tid, NULL, (void*)print_stats, NULL );
+
+ if (ret != 0)
+ rte_exit(EXIT_FAILURE,
+ "Cannot create print-stats thread\n");
+
+ ret = pthread_setname_np(tid, thread_name);
+
+ if (ret != 0)
+ rte_exit(EXIT_FAILURE,
+ "Cannot set print-stats name\n");
+ }
/* Launch all data cores. */
if (zero_copy == 0) {
diff --git a/examples/vhost_xen/main.c b/examples/vhost_xen/main.c
index b4a86e3..530b047 100644
--- a/examples/vhost_xen/main.c
+++ b/examples/vhost_xen/main.c
@@ -1433,6 +1433,7 @@ main(int argc, char *argv[])
int ret;
uint8_t portid;
static pthread_t tid;
+ char thread_name[RTE_THREAD_NAME_LEN];
/* init EAL */
ret = rte_eal_init(argc, argv);
@@ -1505,9 +1506,24 @@ main(int argc, char *argv[])
memset(&dev_statistics, 0, sizeof(dev_statistics));
/* Enable stats if the user option is set. */
- if (enable_stats)
+ if (enable_stats) {
+
+ snprintf(thread_name, RTE_THREAD_NAME_LEN,
+ "vhost-xen-stats");
+
pthread_create(&tid, NULL, (void*)print_stats, NULL );
+ if (ret != 0)
+ rte_exit(EXIT_FAILURE,
+ "Cannot create print-stats thread\n");
+
+ ret = pthread_setname_np(tid, thread_name);
+
+ if (ret != 0)
+ rte_exit(EXIT_FAILURE,
+ "Cannot set print-stats name\n");
+ }
+
/* Launch all data cores. */
RTE_LCORE_FOREACH_SLAVE(lcore_id) {
rte_eal_remote_launch(switch_worker, mbuf_pool, lcore_id);
diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
index 2357cfa..55971b9 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE
# workaround for a gcc bug with noreturn attribute
# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603
ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
-CFLAGS_eal_thread.o += -Wno-return-type
+CFLAGS_eal_common_thread.o += -Wno-return-type
CFLAGS_eal_hpet.o += -Wno-return-type
endif
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 871d5f4..6b756d5 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -437,6 +437,7 @@ rte_eal_init(int argc, char **argv)
int i, fctret, ret;
pthread_t thread_id;
static rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);
+ char thread_name[RTE_THREAD_NAME_LEN];
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
if (!rte_atomic32_test_and_set(&run_once))
@@ -525,6 +526,9 @@ rte_eal_init(int argc, char **argv)
RTE_LCORE_FOREACH_SLAVE(i) {
+ snprintf(thread_name, RTE_THREAD_NAME_LEN,
+ "lcore-slave-%d", i);
+
/*
* create communication pipes between master thread
* and children
@@ -541,6 +545,9 @@ rte_eal_init(int argc, char **argv)
eal_thread_loop, NULL);
if (ret != 0)
rte_panic("Cannot create thread\n");
+
+ pthread_set_name_np(
+ lcore_config[i].thread_id, (const char *)thread_name);
}
/*
diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c b/lib/librte_eal/bsdapp/eal/eal_thread.c
index 9a03437..5714b8f 100644
--- a/lib/librte_eal/bsdapp/eal/eal_thread.c
+++ b/lib/librte_eal/bsdapp/eal/eal_thread.c
@@ -35,163 +35,11 @@
#include <stdio.h>
#include <stdlib.h>
#include <stdint.h>
-#include <unistd.h>
-#include <sched.h>
-#include <pthread_np.h>
-#include <sys/queue.h>
#include <sys/thr.h>
-#include <rte_debug.h>
-#include <rte_atomic.h>
-#include <rte_launch.h>
-#include <rte_log.h>
-#include <rte_memory.h>
-#include <rte_memzone.h>
-#include <rte_per_lcore.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_lcore.h>
-
#include "eal_private.h"
#include "eal_thread.h"
-RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY;
-RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY;
-RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset);
-
-/*
- * Send a message to a slave lcore identified by slave_id to call a
- * function f with argument arg. Once the execution is done, the
- * remote lcore switch in FINISHED state.
- */
-int
-rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)
-{
- int n;
- char c = 0;
- int m2s = lcore_config[slave_id].pipe_master2slave[1];
- int s2m = lcore_config[slave_id].pipe_slave2master[0];
-
- if (lcore_config[slave_id].state != WAIT)
- return -EBUSY;
-
- lcore_config[slave_id].f = f;
- lcore_config[slave_id].arg = arg;
-
- /* send message */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(m2s, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* wait ack */
- do {
- n = read(s2m, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- return 0;
-}
-
-/* set affinity for current thread */
-static int
-eal_thread_set_affinity(void)
-{
- unsigned lcore_id = rte_lcore_id();
-
- /* acquire system unique id */
- rte_gettid();
-
- /* update EAL thread core affinity */
- return rte_thread_set_affinity(&lcore_config[lcore_id].cpuset);
-}
-
-void eal_thread_init_master(unsigned lcore_id)
-{
- /* set the lcore ID in per-lcore memory area */
- RTE_PER_LCORE(_lcore_id) = lcore_id;
-
- /* set CPU affinity */
- if (eal_thread_set_affinity() < 0)
- rte_panic("cannot set affinity\n");
-}
-
-/* main loop of threads */
-__attribute__((noreturn)) void *
-eal_thread_loop(__attribute__((unused)) void *arg)
-{
- char c;
- int n, ret;
- unsigned lcore_id;
- pthread_t thread_id;
- int m2s, s2m;
- char cpuset[RTE_CPU_AFFINITY_STR_LEN];
-
- thread_id = pthread_self();
-
- /* retrieve our lcore_id from the configuration structure */
- RTE_LCORE_FOREACH_SLAVE(lcore_id) {
- if (thread_id == lcore_config[lcore_id].thread_id)
- break;
- }
- if (lcore_id == RTE_MAX_LCORE)
- rte_panic("cannot retrieve lcore id\n");
-
- m2s = lcore_config[lcore_id].pipe_master2slave[0];
- s2m = lcore_config[lcore_id].pipe_slave2master[1];
-
- /* set the lcore ID in per-lcore memory area */
- RTE_PER_LCORE(_lcore_id) = lcore_id;
-
- /* set CPU affinity */
- if (eal_thread_set_affinity() < 0)
- rte_panic("cannot set affinity\n");
-
- ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
-
- RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%p;cpuset=[%s%s])\n",
- lcore_id, thread_id, cpuset, ret == 0 ? "" : "...");
-
- /* read on our pipe to get commands */
- while (1) {
- void *fct_arg;
-
- /* wait command */
- do {
- n = read(m2s, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- lcore_config[lcore_id].state = RUNNING;
-
- /* send ack */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(s2m, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- if (lcore_config[lcore_id].f == NULL)
- rte_panic("NULL function pointer\n");
-
- /* call the function and store the return value */
- fct_arg = lcore_config[lcore_id].arg;
- ret = lcore_config[lcore_id].f(fct_arg);
- lcore_config[lcore_id].ret = ret;
- rte_wmb();
- lcore_config[lcore_id].state = FINISHED;
- }
-
- /* never reached */
- /* pthread_exit(NULL); */
- /* return NULL; */
-}
-
/* require calling thread tid by gettid() */
int rte_sys_gettid(void)
{
diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 2405e93..48dfd95 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -31,11 +31,12 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <stdint.h>
#include <unistd.h>
-#include <pthread.h>
+#include <sys/queue.h>
#include <sched.h>
#include <assert.h>
#include <string.h>
@@ -43,10 +44,21 @@
#include <rte_lcore.h>
#include <rte_memory.h>
#include <rte_log.h>
+#include <rte_debug.h>
+#include <rte_atomic.h>
+#include <rte_launch.h>
+#include <rte_memzone.h>
+#include <rte_per_lcore.h>
+#include <rte_eal.h>
+#include <rte_per_lcore.h>
+#include "eal_private.h"
#include "eal_thread.h"
RTE_DECLARE_PER_LCORE(unsigned , _socket_id);
+RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY;
+RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY;
+RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset);
unsigned rte_socket_id(void)
{
@@ -155,3 +167,136 @@ exit:
return ret;
}
+
+/*
+ * Send a message to a slave lcore identified by slave_id to call a
+ * function f with argument arg. Once the execution is done, the
+ * remote lcore switch in FINISHED state.
+ */
+int
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)
+{
+ int n;
+ char c = 0;
+ int m2s = lcore_config[slave_id].pipe_master2slave[1];
+ int s2m = lcore_config[slave_id].pipe_slave2master[0];
+
+ if (lcore_config[slave_id].state != WAIT)
+ return -EBUSY;
+
+ lcore_config[slave_id].f = f;
+ lcore_config[slave_id].arg = arg;
+
+ /* send message */
+ n = 0;
+ while (n == 0 || (n < 0 && errno == EINTR))
+ n = write(m2s, &c, 1);
+ if (n < 0)
+ rte_panic("cannot write on configuration pipe\n");
+
+ /* wait ack */
+ do {
+ n = read(s2m, &c, 1);
+ } while (n < 0 && errno == EINTR);
+
+ if (n <= 0)
+ rte_panic("cannot read on configuration pipe\n");
+
+ return 0;
+}
+
+/* set affinity for current EAL thread */
+static int
+eal_thread_set_affinity(void)
+{
+ unsigned lcore_id = rte_lcore_id();
+
+ /* acquire system unique id */
+ rte_gettid();
+
+ /* update EAL thread core affinity */
+ return rte_thread_set_affinity(&lcore_config[lcore_id].cpuset);
+}
+
+void eal_thread_init_master(unsigned lcore_id)
+{
+ /* set the lcore ID in per-lcore memory area */
+ RTE_PER_LCORE(_lcore_id) = lcore_id;
+
+ /* set CPU affinity */
+ if (eal_thread_set_affinity() < 0)
+ rte_panic("cannot set affinity\n");
+}
+
+/* main loop of threads */
+__attribute__((noreturn)) void *
+eal_thread_loop(__attribute__((unused)) void *arg)
+{
+ char c;
+ int n, ret;
+ unsigned lcore_id;
+ pthread_t thread_id;
+ int m2s, s2m;
+ char cpuset[RTE_CPU_AFFINITY_STR_LEN];
+
+ thread_id = pthread_self();
+
+ /* retrieve our lcore_id from the configuration structure */
+ RTE_LCORE_FOREACH_SLAVE(lcore_id) {
+ if (thread_id == lcore_config[lcore_id].thread_id)
+ break;
+ }
+ if (lcore_id == RTE_MAX_LCORE)
+ rte_panic("cannot retrieve lcore id\n");
+
+ m2s = lcore_config[lcore_id].pipe_master2slave[0];
+ s2m = lcore_config[lcore_id].pipe_slave2master[1];
+
+ /* set the lcore ID in per-lcore memory area */
+ RTE_PER_LCORE(_lcore_id) = lcore_id;
+
+ /* set CPU affinity */
+ if (eal_thread_set_affinity() < 0)
+ rte_panic("cannot set affinity\n");
+
+ ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
+
+ RTE_LOG(DEBUG, EAL, "lcore %u is ready (thread=%d;cpuset=[%s%s])\n",
+ lcore_id, rte_sys_gettid(), cpuset, ret == 0 ? "" : "...");
+
+ /* read on our pipe to get commands */
+ while (1) {
+ void *fct_arg;
+
+ /* wait command */
+ do {
+ n = read(m2s, &c, 1);
+ } while (n < 0 && errno == EINTR);
+
+ if (n <= 0)
+ rte_panic("cannot read on configuration pipe\n");
+
+ lcore_config[lcore_id].state = RUNNING;
+
+ /* send ack */
+ n = 0;
+ while (n == 0 || (n < 0 && errno == EINTR))
+ n = write(s2m, &c, 1);
+ if (n < 0)
+ rte_panic("cannot write on configuration pipe\n");
+
+ if (lcore_config[lcore_id].f == NULL)
+ rte_panic("NULL function pointer\n");
+
+ /* call the function and store the return value */
+ fct_arg = lcore_config[lcore_id].arg;
+ ret = lcore_config[lcore_id].f(fct_arg);
+ lcore_config[lcore_id].ret = ret;
+ rte_wmb();
+ lcore_config[lcore_id].state = FINISHED;
+ }
+
+ /* never reached */
+ /* pthread_exit(NULL); */
+ /* return NULL; */
+}
diff --git a/lib/librte_eal/common/eal_thread.h b/lib/librte_eal/common/eal_thread.h
index e4e76b9..df7dccd 100644
--- a/lib/librte_eal/common/eal_thread.h
+++ b/lib/librte_eal/common/eal_thread.h
@@ -80,6 +80,11 @@ int eal_cpuset_socket_id(rte_cpuset_t *cpusetp);
#define RTE_CPU_AFFINITY_STR_LEN 256
/**
+ * Default buffer size for thread name
+ */
+#define RTE_THREAD_NAME_LEN 32
+
+/**
* Dump the current pthread cpuset.
* This function is private to EAL.
*
diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile
index 01f7b70..cf2271c 100644
--- a/lib/librte_eal/linuxapp/eal/Makefile
+++ b/lib/librte_eal/linuxapp/eal/Makefile
@@ -93,6 +93,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_thread.c
CFLAGS_eal.o := -D_GNU_SOURCE
CFLAGS_eal_interrupts.o := -D_GNU_SOURCE
+CFLAGS_eal_timer.o := -D_GNU_SOURCE
CFLAGS_eal_lcore.o := -D_GNU_SOURCE
CFLAGS_eal_thread.o := -D_GNU_SOURCE
CFLAGS_eal_log.o := -D_GNU_SOURCE
@@ -101,6 +102,7 @@ CFLAGS_eal_hugepage_info.o := -D_GNU_SOURCE
CFLAGS_eal_pci.o := -D_GNU_SOURCE
CFLAGS_eal_pci_uio.o := -D_GNU_SOURCE
CFLAGS_eal_pci_vfio.o := -D_GNU_SOURCE
+CFLAGS_eal_pci_vfio_mp_sync.o := -D_GNU_SOURCE
CFLAGS_eal_common_whitelist.o := -D_GNU_SOURCE
CFLAGS_eal_common_options.o := -D_GNU_SOURCE
CFLAGS_eal_common_thread.o := -D_GNU_SOURCE
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index bd770cf..6335a41 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -703,6 +703,7 @@ rte_eal_init(int argc, char **argv)
pthread_t thread_id;
static rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);
struct shared_driver *solib = NULL;
+ char thread_name[RTE_THREAD_NAME_LEN];
const char *logid;
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
@@ -816,6 +817,9 @@ rte_eal_init(int argc, char **argv)
RTE_LCORE_FOREACH_SLAVE(i) {
+ snprintf(thread_name, RTE_THREAD_NAME_LEN,
+ "lcore-slave-%d", i);
+
/*
* create communication pipes between master thread
* and children
@@ -832,6 +836,12 @@ rte_eal_init(int argc, char **argv)
eal_thread_loop, NULL);
if (ret != 0)
rte_panic("Cannot create thread\n");
+
+ ret = pthread_setname_np(
+ lcore_config[i].thread_id, thread_name);
+
+ if (ret != 0)
+ rte_panic("Cannot set name for the thread\n");
}
/*
diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
index 66deda2..5487d58 100644
--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c
+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c
@@ -66,6 +66,7 @@
#include "eal_private.h"
#include "eal_vfio.h"
+#include "eal_thread.h"
#define EAL_INTR_EPOLL_WAIT_FOREVER (-1)
@@ -838,6 +839,7 @@ int
rte_eal_intr_init(void)
{
int ret = 0;
+ char thread_name[RTE_THREAD_NAME_LEN];
/* init the global interrupt source head */
TAILQ_INIT(&intr_sources);
@@ -849,6 +851,9 @@ rte_eal_intr_init(void)
if (pipe(intr_pipe.pipefd) < 0)
return -1;
+ snprintf(thread_name, RTE_THREAD_NAME_LEN,
+ "eal-intr-thread");
+
/* create the host thread to wait/handle the interrupt */
ret = pthread_create(&intr_thread, NULL,
eal_intr_thread_main, NULL);
@@ -856,6 +861,12 @@ rte_eal_intr_init(void)
RTE_LOG(ERR, EAL,
"Failed to create thread for interrupt handling\n");
+ ret = pthread_setname_np(intr_thread, thread_name);
+
+ if (ret != 0)
+ RTE_LOG(ERR, EAL,
+ "Failed to set thread name for interrupt handling\n");
+
return -ret;
}
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
index fec7080..c23374d 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
@@ -34,6 +34,7 @@
#include <string.h>
#include <fcntl.h>
#include <sys/socket.h>
+#include <pthread.h>
/* sys/un.h with __USE_MISC uses strlen, which is unsafe */
#ifdef __USE_MISC
@@ -54,6 +55,7 @@
#include "eal_filesystem.h"
#include "eal_pci_init.h"
+#include "eal_thread.h"
/**
* @file
@@ -374,20 +376,36 @@ int
pci_vfio_mp_sync_setup(void)
{
int ret;
+ char thread_name[RTE_THREAD_NAME_LEN];
if (vfio_mp_sync_socket_setup() < 0) {
RTE_LOG(ERR, EAL, "Failed to set up local socket!\n");
return -1;
}
+ snprintf(thread_name, RTE_THREAD_NAME_LEN,
+ "pci-vfio-mp-sync");
+
ret = pthread_create(&socket_thread, NULL,
pci_vfio_mp_sync_thread, NULL);
if (ret) {
- RTE_LOG(ERR, EAL, "Failed to create thread for communication with "
- "secondary processes!\n");
+ RTE_LOG(ERR, EAL,
+ "Failed to create thread for communication with "
+ "secondary processes!\n");
+ close(mp_socket_fd);
+ return -1;
+ }
+
+ ret = pthread_setname_np(socket_thread, thread_name);
+
+ if (ret) {
+ RTE_LOG(ERR, EAL,
+ "Failed to set thread name for "
+ "secondary processes!\n");
close(mp_socket_fd);
return -1;
}
+
return 0;
}
diff --git a/lib/librte_eal/linuxapp/eal/eal_thread.c b/lib/librte_eal/linuxapp/eal/eal_thread.c
index 18bd8e0..51dca37 100644
--- a/lib/librte_eal/linuxapp/eal/eal_thread.c
+++ b/lib/librte_eal/linuxapp/eal/eal_thread.c
@@ -34,163 +34,13 @@
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
-#include <stdint.h>
#include <unistd.h>
-#include <pthread.h>
-#include <sched.h>
-#include <sys/queue.h>
#include <sys/syscall.h>
-#include <rte_debug.h>
-#include <rte_atomic.h>
-#include <rte_launch.h>
-#include <rte_log.h>
-#include <rte_memory.h>
-#include <rte_memzone.h>
-#include <rte_per_lcore.h>
-#include <rte_eal.h>
-#include <rte_per_lcore.h>
-#include <rte_lcore.h>
-
#include "eal_private.h"
#include "eal_thread.h"
-RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY;
-RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY;
-RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset);
-
-/*
- * Send a message to a slave lcore identified by slave_id to call a
- * function f with argument arg. Once the execution is done, the
- * remote lcore switch in FINISHED state.
- */
-int
-rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)
-{
- int n;
- char c = 0;
- int m2s = lcore_config[slave_id].pipe_master2slave[1];
- int s2m = lcore_config[slave_id].pipe_slave2master[0];
-
- if (lcore_config[slave_id].state != WAIT)
- return -EBUSY;
-
- lcore_config[slave_id].f = f;
- lcore_config[slave_id].arg = arg;
-
- /* send message */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(m2s, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- /* wait ack */
- do {
- n = read(s2m, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- return 0;
-}
-
-/* set affinity for current EAL thread */
-static int
-eal_thread_set_affinity(void)
-{
- unsigned lcore_id = rte_lcore_id();
-
- /* acquire system unique id */
- rte_gettid();
-
- /* update EAL thread core affinity */
- return rte_thread_set_affinity(&lcore_config[lcore_id].cpuset);
-}
-
-void eal_thread_init_master(unsigned lcore_id)
-{
- /* set the lcore ID in per-lcore memory area */
- RTE_PER_LCORE(_lcore_id) = lcore_id;
-
- /* set CPU affinity */
- if (eal_thread_set_affinity() < 0)
- rte_panic("cannot set affinity\n");
-}
-
-/* main loop of threads */
-__attribute__((noreturn)) void *
-eal_thread_loop(__attribute__((unused)) void *arg)
-{
- char c;
- int n, ret;
- unsigned lcore_id;
- pthread_t thread_id;
- int m2s, s2m;
- char cpuset[RTE_CPU_AFFINITY_STR_LEN];
-
- thread_id = pthread_self();
-
- /* retrieve our lcore_id from the configuration structure */
- RTE_LCORE_FOREACH_SLAVE(lcore_id) {
- if (thread_id == lcore_config[lcore_id].thread_id)
- break;
- }
- if (lcore_id == RTE_MAX_LCORE)
- rte_panic("cannot retrieve lcore id\n");
-
- m2s = lcore_config[lcore_id].pipe_master2slave[0];
- s2m = lcore_config[lcore_id].pipe_slave2master[1];
-
- /* set the lcore ID in per-lcore memory area */
- RTE_PER_LCORE(_lcore_id) = lcore_id;
-
- /* set CPU affinity */
- if (eal_thread_set_affinity() < 0)
- rte_panic("cannot set affinity\n");
-
- ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
-
- RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%x;cpuset=[%s%s])\n",
- lcore_id, (int)thread_id, cpuset, ret == 0 ? "" : "...");
-
- /* read on our pipe to get commands */
- while (1) {
- void *fct_arg;
-
- /* wait command */
- do {
- n = read(m2s, &c, 1);
- } while (n < 0 && errno == EINTR);
-
- if (n <= 0)
- rte_panic("cannot read on configuration pipe\n");
-
- lcore_config[lcore_id].state = RUNNING;
-
- /* send ack */
- n = 0;
- while (n == 0 || (n < 0 && errno == EINTR))
- n = write(s2m, &c, 1);
- if (n < 0)
- rte_panic("cannot write on configuration pipe\n");
-
- if (lcore_config[lcore_id].f == NULL)
- rte_panic("NULL function pointer\n");
-
- /* call the function and store the return value */
- fct_arg = lcore_config[lcore_id].arg;
- ret = lcore_config[lcore_id].f(fct_arg);
- lcore_config[lcore_id].ret = ret;
- rte_wmb();
- lcore_config[lcore_id].state = FINISHED;
- }
-
- /* never reached */
- /* pthread_exit(NULL); */
- /* return NULL; */
-}
+#include <rte_log.h>
/* require calling thread tid by gettid() */
int rte_sys_gettid(void)
diff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c b/lib/librte_eal/linuxapp/eal/eal_timer.c
index 169c6e1..b19b18e 100644
--- a/lib/librte_eal/linuxapp/eal/eal_timer.c
+++ b/lib/librte_eal/linuxapp/eal/eal_timer.c
@@ -54,6 +54,7 @@
#include "eal_private.h"
#include "eal_internal_cfg.h"
+#include "eal_thread.h"
enum timer_source eal_timer_source = EAL_TIMER_HPET;
@@ -186,6 +187,7 @@ int
rte_eal_hpet_init(int make_default)
{
int fd, ret;
+ char thread_name[RTE_THREAD_NAME_LEN];
if (internal_config.no_hpet) {
RTE_LOG(INFO, EAL, "HPET is disabled\n");
@@ -224,16 +226,27 @@ rte_eal_hpet_init(int make_default)
eal_hpet_msb = (eal_hpet->counter_l >> 30);
+ snprintf(thread_name, RTE_THREAD_NAME_LEN, "hpet-msb-inc");
+
/* create a thread that will increment a global variable for
* msb (hpet is 32 bits by default under linux) */
ret = pthread_create(&msb_inc_thread_id, NULL,
(void *(*)(void *))hpet_msb_inc, NULL);
- if (ret < 0) {
+ if (ret != 0) {
RTE_LOG(ERR, EAL, "ERROR: Cannot create HPET timer thread!\n");
internal_config.no_hpet = 1;
return -1;
}
+ ret = pthread_setname_np(msb_inc_thread_id, thread_name);
+
+ if (ret != 0) {
+ RTE_LOG(ERR, EAL,
+ "ERROR: Cannot set HPET timer thread name!\n");
+ internal_config.no_hpet = 1;
+ return -1;
+ }
+
if (make_default)
eal_timer_source = EAL_TIMER_HPET;
return 0;
--
1.9.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
@ 2015-04-18 19:43 ` Ravi Kerur
2015-04-21 14:36 ` Bruce Richardson
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 3/6] Move common functions in eal_lcore.c Ravi Kerur
` (4 subsequent siblings)
5 siblings, 1 reply; 15+ messages in thread
From: Ravi Kerur @ 2015-04-18 19:43 UTC (permalink / raw)
To: dev
Changes in v6
Split eal_common_system.c and eal_common_runtime.c into
eal_common_sysfs.c
eal_common_mem_cfg.c
eal_common_proc_type.c
eal_comm_app_usage.c
based on functionality.
Changes in v5
Rebase to latest code.
Changes in v4
Remove eal_externs.h file, instead use _get_ and _set_ APIS
to access those variables.
Split eal_common.c into eal_common_system.c and
and eal_common_runtime.c
rte_eal prefix functions are moved to _runtime_ and
eal prefix functions are moved to _system_ files respectively.
Changes in v3
Changed subject to be more explicit on file name inclusion.
Changes in v2
In function rte_eal_config_create remove #ifdef _BSDAPP_
and initialize mem_cfg_addr unconditionally.
Changes in v1
Move common functions in eal.c to librte_eal/common/eal_common.c.
Following functions are moved to eal_common.c file.
struct rte_config *rte_eal_get_configuration(void);
int eal_parse_sysfs_value(const char *filename, unsigned long *val);
static void rte_eal_config_create(void);
enum rte_proc_type_t eal_proc_type_detect(void);
void rte_eal_config_init(void);
rte_usage_hook_t rte_set_application_usage_hook(rte_usage_hook_t
usage_func);
inline size_t eal_get_hugepage_mem_size(void);
void eal_check_mem_on_local_socket(void);
int sync_func(__attribute__((unused)) void *arg);
inline void rte_eal_mcfg_complete(void);
int rte_eal_has_hugepages(void);
enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);
enum rte_proc_type_t rte_eal_process_type(void);
Makefile changes to reflect new files added.
Fix checkpatch warnings and errors.
Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
lib/librte_eal/bsdapp/eal/Makefile | 4 +
lib/librte_eal/bsdapp/eal/eal.c | 271 +++---------------------
lib/librte_eal/common/eal_common_app_usage.c | 63 ++++++
lib/librte_eal/common/eal_common_mem_cfg.c | 217 ++++++++++++++++++++
lib/librte_eal/common/eal_common_proc_type.c | 58 ++++++
lib/librte_eal/common/eal_common_sysfs.c | 163 +++++++++++++++
lib/librte_eal/common/eal_hugepages.h | 1 +
lib/librte_eal/common/eal_private.h | 78 +++++++
lib/librte_eal/common/include/rte_eal.h | 4 +
lib/librte_eal/linuxapp/eal/Makefile | 4 +
lib/librte_eal/linuxapp/eal/eal.c | 296 ++++-----------------------
11 files changed, 668 insertions(+), 491 deletions(-)
create mode 100644 lib/librte_eal/common/eal_common_app_usage.c
create mode 100644 lib/librte_eal/common/eal_common_mem_cfg.c
create mode 100644 lib/librte_eal/common/eal_common_proc_type.c
create mode 100644 lib/librte_eal/common/eal_common_sysfs.c
diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
index 55971b9..5076a05 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -78,6 +78,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_devargs.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_dev.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_options.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_thread.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_sysfs.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_mem_cfg.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_proc_type.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_app_usage.c
CFLAGS_eal.o := -D_GNU_SOURCE
#CFLAGS_eal_thread.o := -D_GNU_SOURCE
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 6b756d5..df6b7ab 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -80,29 +80,6 @@
#include "eal_hugepages.h"
#include "eal_options.h"
-#define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
-
-/* Allow the application to print its usage message too if set */
-static rte_usage_hook_t rte_application_usage_hook = NULL;
-/* early configuration structure, when memory config is not mmapped */
-static struct rte_mem_config early_mem_config;
-
-/* define fd variable here, because file needs to be kept open for the
- * duration of the program, as we hold a write lock on it in the primary proc */
-static int mem_cfg_fd = -1;
-
-static struct flock wr_lock = {
- .l_type = F_WRLCK,
- .l_whence = SEEK_SET,
- .l_start = offsetof(struct rte_mem_config, memseg),
- .l_len = sizeof(early_mem_config.memseg),
-};
-
-/* Address of global and public configuration */
-static struct rte_config rte_config = {
- .mem_config = &early_mem_config,
-};
-
/* internal configuration (per-core) */
struct lcore_config lcore_config[RTE_MAX_LCORE];
@@ -112,160 +89,57 @@ struct internal_config internal_config;
/* used by rte_rdtsc() */
int rte_cycles_vmware_tsc_map;
-/* Return a pointer to the configuration structure */
-struct rte_config *
-rte_eal_get_configuration(void)
-{
- return &rte_config;
-}
-
-/* parse a sysfs (or other) file containing one integer value */
-int
-eal_parse_sysfs_value(const char *filename, unsigned long *val)
-{
- FILE *f;
- char buf[BUFSIZ];
- char *end = NULL;
-
- if ((f = fopen(filename, "r")) == NULL) {
- RTE_LOG(ERR, EAL, "%s(): cannot open sysfs value %s\n",
- __func__, filename);
- return -1;
- }
-
- if (fgets(buf, sizeof(buf), f) == NULL) {
- RTE_LOG(ERR, EAL, "%s(): cannot read sysfs value %s\n",
- __func__, filename);
- fclose(f);
- return -1;
- }
- *val = strtoul(buf, &end, 0);
- if ((buf[0] == '\0') || (end == NULL) || (*end != '\n')) {
- RTE_LOG(ERR, EAL, "%s(): cannot parse sysfs value %s\n",
- __func__, filename);
- fclose(f);
- return -1;
- }
- fclose(f);
- return 0;
-}
-
-
-/* create memory configuration in shared/mmap memory. Take out
- * a write lock on the memsegs, so we can auto-detect primary/secondary.
- * This means we never close the file while running (auto-close on exit).
- * We also don't lock the whole file, so that in future we can use read-locks
- * on other parts, e.g. memzones, to detect if there are running secondary
- * processes. */
-static void
-rte_eal_config_create(void)
+inline void *
+rte_eal_get_mem_cfg_addr(void)
{
- void *rte_mem_cfg_addr;
- int retval;
-
- const char *pathname = eal_runtime_config_path();
-
- if (internal_config.no_shconf)
- return;
-
- if (mem_cfg_fd < 0){
- mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0660);
- if (mem_cfg_fd < 0)
- rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
- }
-
- retval = ftruncate(mem_cfg_fd, sizeof(*rte_config.mem_config));
- if (retval < 0){
- close(mem_cfg_fd);
- rte_panic("Cannot resize '%s' for rte_mem_config\n", pathname);
- }
-
- retval = fcntl(mem_cfg_fd, F_SETLK, &wr_lock);
- if (retval < 0){
- close(mem_cfg_fd);
- rte_exit(EXIT_FAILURE, "Cannot create lock on '%s'. Is another primary "
- "process running?\n", pathname);
- }
-
- rte_mem_cfg_addr = mmap(NULL, sizeof(*rte_config.mem_config),
- PROT_READ | PROT_WRITE, MAP_SHARED, mem_cfg_fd, 0);
-
- if (rte_mem_cfg_addr == MAP_FAILED){
- rte_panic("Cannot mmap memory for rte_config\n");
- }
- memcpy(rte_mem_cfg_addr, &early_mem_config, sizeof(early_mem_config));
- rte_config.mem_config = (struct rte_mem_config *) rte_mem_cfg_addr;
+ return NULL;
}
/* attach to an existing shared memory config */
-static void
+void
rte_eal_config_attach(void)
{
- void *rte_mem_cfg_addr;
+ struct rte_mem_config *mem_config;
+ struct rte_config *rte_config;
const char *pathname = eal_runtime_config_path();
+ int *mem_cfg_fd = eal_get_mem_cfg_fd();
if (internal_config.no_shconf)
return;
- if (mem_cfg_fd < 0){
- mem_cfg_fd = open(pathname, O_RDWR);
- if (mem_cfg_fd < 0)
+ rte_config = rte_eal_get_configuration();
+ if (rte_config == NULL)
+ return;
+
+ if (*mem_cfg_fd < 0) {
+ *mem_cfg_fd = open(pathname, O_RDWR);
+ if (*mem_cfg_fd < 0)
rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
}
- rte_mem_cfg_addr = mmap(NULL, sizeof(*rte_config.mem_config),
- PROT_READ | PROT_WRITE, MAP_SHARED, mem_cfg_fd, 0);
- close(mem_cfg_fd);
- if (rte_mem_cfg_addr == MAP_FAILED)
+ mem_config = (struct rte_mem_config *) mmap(NULL, sizeof(*mem_config),
+ PROT_READ | PROT_WRITE,
+ MAP_SHARED, *mem_cfg_fd, 0);
+ close(*mem_cfg_fd);
+ if (mem_config == MAP_FAILED)
rte_panic("Cannot mmap memory for rte_config\n");
- rte_config.mem_config = (struct rte_mem_config *) rte_mem_cfg_addr;
-}
-
-/* Detect if we are a primary or a secondary process */
-enum rte_proc_type_t
-eal_proc_type_detect(void)
-{
- enum rte_proc_type_t ptype = RTE_PROC_PRIMARY;
- const char *pathname = eal_runtime_config_path();
-
- /* if we can open the file but not get a write-lock we are a secondary
- * process. NOTE: if we get a file handle back, we keep that open
- * and don't close it to prevent a race condition between multiple opens */
- if (((mem_cfg_fd = open(pathname, O_RDWR)) >= 0) &&
- (fcntl(mem_cfg_fd, F_SETLK, &wr_lock) < 0))
- ptype = RTE_PROC_SECONDARY;
-
- RTE_LOG(INFO, EAL, "Auto-detected process type: %s\n",
- ptype == RTE_PROC_PRIMARY ? "PRIMARY" : "SECONDARY");
-
- return ptype;
+ rte_config->mem_config = mem_config;
}
-/* Sets up rte_config structure with the pointer to shared memory config.*/
-static void
-rte_config_init(void)
+/* NOP for BSD */
+void
+rte_eal_config_reattach(void)
{
- rte_config.process_type = internal_config.process_type;
-
- switch (rte_config.process_type){
- case RTE_PROC_PRIMARY:
- rte_eal_config_create();
- break;
- case RTE_PROC_SECONDARY:
- rte_eal_config_attach();
- rte_eal_mcfg_wait_complete(rte_config.mem_config);
- break;
- case RTE_PROC_AUTO:
- case RTE_PROC_INVALID:
- rte_panic("Invalid process type\n");
- }
}
/* display usage */
static void
eal_usage(const char *prgname)
{
+ rte_usage_hook_t rte_application_usage_hook =
+ rte_get_application_usage_hook();
+
printf("\nUsage: %s ", prgname);
eal_common_usage();
/* Allow the application to print its usage message too if hook is set */
@@ -275,37 +149,6 @@ eal_usage(const char *prgname)
}
}
-/* Set a per-application usage message */
-rte_usage_hook_t
-rte_set_application_usage_hook( rte_usage_hook_t usage_func )
-{
- rte_usage_hook_t old_func;
-
- /* Will be NULL on the first call to denote the last usage routine. */
- old_func = rte_application_usage_hook;
- rte_application_usage_hook = usage_func;
-
- return old_func;
-}
-
-static inline size_t
-eal_get_hugepage_mem_size(void)
-{
- uint64_t size = 0;
- unsigned i, j;
-
- for (i = 0; i < internal_config.num_hugepage_sizes; i++) {
- struct hugepage_info *hpi = &internal_config.hugepage_info[i];
- if (hpi->hugedir != NULL) {
- for (j = 0; j < RTE_MAX_NUMA_NODES; j++) {
- size += hpi->hugepage_sz * hpi->num_pages[j];
- }
- }
- }
-
- return (size < SIZE_MAX) ? (size_t)(size) : SIZE_MAX;
-}
-
/* Parse the argument given in the command line of the application */
static int
eal_parse_args(int argc, char **argv)
@@ -378,45 +221,6 @@ eal_parse_args(int argc, char **argv)
return ret;
}
-static void
-eal_check_mem_on_local_socket(void)
-{
- const struct rte_memseg *ms;
- int i, socket_id;
-
- socket_id = rte_lcore_to_socket_id(rte_config.master_lcore);
-
- ms = rte_eal_get_physmem_layout();
-
- for (i = 0; i < RTE_MAX_MEMSEG; i++)
- if (ms[i].socket_id == socket_id &&
- ms[i].len > 0)
- return;
-
- RTE_LOG(WARNING, EAL, "WARNING: Master core has no "
- "memory on local socket!\n");
-}
-
-static int
-sync_func(__attribute__((unused)) void *arg)
-{
- return 0;
-}
-
-inline static void
-rte_eal_mcfg_complete(void)
-{
- /* ALL shared mem_config related INIT DONE */
- if (rte_config.process_type == RTE_PROC_PRIMARY)
- rte_config.mem_config->magic = RTE_MAGIC;
-}
-
-/* return non-zero if hugepages are enabled. */
-int rte_eal_has_hugepages(void)
-{
- return !internal_config.no_hugetlbfs;
-}
-
/* Abstraction for port I/0 privilege */
int
rte_eal_iopl_init(void)
@@ -437,9 +241,14 @@ rte_eal_init(int argc, char **argv)
int i, fctret, ret;
pthread_t thread_id;
static rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);
+ struct rte_config *rte_config;
char thread_name[RTE_THREAD_NAME_LEN];
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
+ rte_config = rte_eal_get_configuration();
+ if (rte_config == NULL)
+ return -1;
+
if (!rte_atomic32_test_and_set(&run_once))
return -1;
@@ -513,12 +322,12 @@ rte_eal_init(int argc, char **argv)
rte_eal_mcfg_complete();
- eal_thread_init_master(rte_config.master_lcore);
+ eal_thread_init_master(rte_config->master_lcore);
ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
RTE_LOG(DEBUG, EAL, "Master lcore %u is ready (tid=%p;cpuset=[%s%s])\n",
- rte_config.master_lcore, thread_id, cpuset,
+ rte_config->master_lcore, thread_id, cpuset,
ret == 0 ? "" : "...");
if (rte_eal_dev_init() < 0)
@@ -563,17 +372,3 @@ rte_eal_init(int argc, char **argv)
return fctret;
}
-
-/* get core role */
-enum rte_lcore_role_t
-rte_eal_lcore_role(unsigned lcore_id)
-{
- return (rte_config.lcore_role[lcore_id]);
-}
-
-enum rte_proc_type_t
-rte_eal_process_type(void)
-{
- return (rte_config.process_type);
-}
-
diff --git a/lib/librte_eal/common/eal_common_app_usage.c b/lib/librte_eal/common/eal_common_app_usage.c
new file mode 100644
index 0000000..5f64d35
--- /dev/null
+++ b/lib/librte_eal/common/eal_common_app_usage.c
@@ -0,0 +1,63 @@
+/*-
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ * Copyright(c) 2014 6WIND S.A.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <string.h>
+
+#include "eal_private.h"
+
+/* Allow the application to print its usage message too if set */
+rte_usage_hook_t rte_application_usage_hook = NULL;
+
+/* Get per-application usage message */
+rte_usage_hook_t
+rte_get_application_usage_hook(void)
+{
+ return rte_application_usage_hook;
+}
+
+/* Set a per-application usage message */
+rte_usage_hook_t
+rte_set_application_usage_hook(rte_usage_hook_t usage_func)
+{
+ rte_usage_hook_t old_func;
+
+ /* Will be NULL on the first call to denote the last usage routine. */
+ old_func = rte_application_usage_hook;
+ rte_application_usage_hook = usage_func;
+
+ return old_func;
+}
diff --git a/lib/librte_eal/common/eal_common_mem_cfg.c b/lib/librte_eal/common/eal_common_mem_cfg.c
new file mode 100644
index 0000000..9bf8d92
--- /dev/null
+++ b/lib/librte_eal/common/eal_common_mem_cfg.c
@@ -0,0 +1,217 @@
+/*-
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ * Copyright(c) 2014 6WIND S.A.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <string.h>
+#include <stdarg.h>
+#include <unistd.h>
+#include <pthread.h>
+#include <syslog.h>
+#include <getopt.h>
+#include <sys/file.h>
+#include <stddef.h>
+#include <errno.h>
+#include <limits.h>
+#include <errno.h>
+#include <sys/mman.h>
+#include <sys/queue.h>
+
+#include <rte_debug.h>
+#include <rte_eal_memconfig.h>
+#include <rte_log.h>
+
+#include "eal_private.h"
+#include "eal_thread.h"
+#include "eal_internal_cfg.h"
+#include "eal_filesystem.h"
+#include "eal_options.h"
+
+/* early configuration structure, when memory config is not mmapped */
+static struct rte_mem_config early_mem_config;
+
+/* define fd variable here, because file needs to be kept open for the
+ * duration of the program, as we hold a write lock on it in the primary proc */
+static int mem_cfg_fd = -1;
+
+static struct flock wr_lock = {
+ .l_type = F_WRLCK,
+ .l_whence = SEEK_SET,
+ .l_start = offsetof(struct rte_mem_config, memseg),
+ .l_len = sizeof(((struct rte_mem_config *)0)->memseg),
+};
+
+/* Address of global and public configuration */
+static struct rte_config rte_config = {
+ .mem_config = &early_mem_config,
+};
+
+/* Return a pointer to the configuration structure */
+struct rte_config *
+rte_eal_get_configuration(void)
+{
+ return &rte_config;
+}
+
+/* Return memory config file descriptor */
+int*
+eal_get_mem_cfg_fd(void)
+{
+ return &mem_cfg_fd;
+}
+
+/* create memory configuration in shared/mmap memory. Take out
+ * a write lock on the memsegs, so we can auto-detect primary/secondary.
+ * This means we never close the file while running (auto-close on exit).
+ * We also don't lock the whole file, so that in future we can use read-locks
+ * on other parts, e.g. memzones, to detect if there are running secondary
+ * processes. */
+static void
+rte_eal_config_create(void)
+{
+ void *rte_mem_cfg_addr;
+ int retval;
+
+ const char *pathname = eal_runtime_config_path();
+
+ if (internal_config.no_shconf)
+ return;
+
+ rte_mem_cfg_addr = rte_eal_get_mem_cfg_addr();
+
+ if (mem_cfg_fd < 0) {
+ mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0660);
+ if (mem_cfg_fd < 0)
+ rte_panic("Cannot open '%s' for rte_mem_config\n",
+ pathname);
+ }
+
+ retval = eal_ftruncate_and_fcntl(sizeof(*rte_config.mem_config));
+
+ if (retval == -1) {
+ close(mem_cfg_fd);
+ rte_panic("Cannot resize '%s' for rte_mem_config\n", pathname);
+ } else if (retval == -2) {
+ close(mem_cfg_fd);
+ rte_exit(EXIT_FAILURE, "Cannot create lock on '%s'. "
+ "Is another primary process running?\n", pathname);
+ }
+
+ rte_mem_cfg_addr = mmap(rte_mem_cfg_addr,
+ sizeof(*rte_config.mem_config), PROT_READ | PROT_WRITE,
+ MAP_SHARED, mem_cfg_fd, 0);
+
+ if (rte_mem_cfg_addr == MAP_FAILED)
+ rte_panic("Cannot mmap memory for rte_config\n");
+
+ memcpy(rte_mem_cfg_addr, &early_mem_config, sizeof(early_mem_config));
+ rte_config.mem_config = (struct rte_mem_config *) rte_mem_cfg_addr;
+
+ /* store address of the config in the config itself so that secondary
+ * processes could later map the config into this exact location
+ */
+ rte_config.mem_config->mem_cfg_addr = (uintptr_t) rte_mem_cfg_addr;
+}
+
+/* Sets up rte_config structure with the pointer to shared memory config.*/
+void
+rte_config_init(void)
+{
+ rte_config.process_type = internal_config.process_type;
+
+ switch (rte_config.process_type) {
+ case RTE_PROC_PRIMARY:
+ rte_eal_config_create();
+ break;
+ case RTE_PROC_SECONDARY:
+ rte_eal_config_attach();
+ rte_eal_mcfg_wait_complete(rte_config.mem_config);
+ rte_eal_config_reattach();
+ break;
+ case RTE_PROC_AUTO:
+ case RTE_PROC_INVALID:
+ rte_panic("Invalid process type\n");
+ }
+}
+
+inline void
+rte_eal_mcfg_complete(void)
+{
+ /* ALL shared mem_config related INIT DONE */
+ if (rte_config.process_type == RTE_PROC_PRIMARY)
+ rte_config.mem_config->magic = RTE_MAGIC;
+}
+
+/* Detect if we are a primary or a secondary process */
+enum rte_proc_type_t
+eal_proc_type_detect(void)
+{
+ enum rte_proc_type_t ptype = RTE_PROC_PRIMARY;
+ const char *pathname = eal_runtime_config_path();
+
+ /* if we can open the file but not get a write-lock we are
+ * a secondary process. NOTE: if we get a file handle back,
+ * we keep that open and don't close it to prevent a race
+ * condition between multiple opens
+ */
+ mem_cfg_fd = open(pathname, O_RDWR);
+ if ((mem_cfg_fd >= 0) &&
+ (fcntl(mem_cfg_fd, F_SETLK, &wr_lock) < 0))
+ ptype = RTE_PROC_SECONDARY;
+
+ RTE_LOG(INFO, EAL, "Auto-detected process type: %s\n",
+ ptype == RTE_PROC_PRIMARY ? "PRIMARY" : "SECONDARY");
+
+ return ptype;
+}
+
+/*
+ * Perform ftruncate and fcntl operations on
+ * memory config file descriptor.
+ */
+int
+eal_ftruncate_and_fcntl(size_t size)
+{
+ int retval;
+
+ retval = ftruncate(mem_cfg_fd, size);
+ if (retval < 0)
+ return -1;
+
+ retval = fcntl(mem_cfg_fd, F_SETLK, &wr_lock);
+ if (retval < 0)
+ return -2;
+ return 0;
+}
diff --git a/lib/librte_eal/common/eal_common_proc_type.c b/lib/librte_eal/common/eal_common_proc_type.c
new file mode 100644
index 0000000..f8bb47f
--- /dev/null
+++ b/lib/librte_eal/common/eal_common_proc_type.c
@@ -0,0 +1,58 @@
+/*-
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ * Copyright(c) 2014 6WIND S.A.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <string.h>
+#include <stdarg.h>
+#include <unistd.h>
+
+#include "eal_private.h"
+
+#include <rte_log.h>
+
+enum rte_proc_type_t
+rte_eal_process_type(void)
+{
+ struct rte_config *rte_config =
+ rte_eal_get_configuration();
+
+ if (rte_config == NULL) {
+ RTE_LOG(WARNING, EAL, "WARNING: rte_config NULL!\n");
+ return RTE_PROC_INVALID;
+ }
+
+ return rte_config->process_type;
+}
diff --git a/lib/librte_eal/common/eal_common_sysfs.c b/lib/librte_eal/common/eal_common_sysfs.c
new file mode 100644
index 0000000..64626e1
--- /dev/null
+++ b/lib/librte_eal/common/eal_common_sysfs.c
@@ -0,0 +1,163 @@
+/*-
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ * Copyright(c) 2014 6WIND S.A.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <string.h>
+#include <stdarg.h>
+#include <unistd.h>
+#include <pthread.h>
+#include <syslog.h>
+#include <getopt.h>
+#include <sys/file.h>
+#include <stddef.h>
+#include <errno.h>
+#include <limits.h>
+#include <errno.h>
+#include <sys/mman.h>
+#include <sys/queue.h>
+
+#include "eal_private.h"
+#include "eal_internal_cfg.h"
+#include "eal_filesystem.h"
+#include "eal_hugepages.h"
+#include "eal_options.h"
+
+#include <rte_log.h>
+#include <rte_memory.h>
+#include <rte_lcore.h>
+
+/* parse a sysfs (or other) file containing one integer value */
+int
+eal_parse_sysfs_value(const char *filename, unsigned long *val)
+{
+ FILE *f;
+ char buf[BUFSIZ];
+ char *end = NULL;
+
+ f = fopen(filename, "r");
+ if (f == NULL) {
+ RTE_LOG(ERR, EAL, "%s(): cannot open sysfs value %s\n",
+ __func__, filename);
+ return -1;
+ }
+
+ if (fgets(buf, sizeof(buf), f) == NULL) {
+ RTE_LOG(ERR, EAL, "%s(): cannot read sysfs value %s\n",
+ __func__, filename);
+ fclose(f);
+ return -1;
+ }
+ *val = strtoul(buf, &end, 0);
+ if ((buf[0] == '\0') || (end == NULL) || (*end != '\n')) {
+ RTE_LOG(ERR, EAL, "%s(): cannot parse sysfs value %s\n",
+ __func__, filename);
+ fclose(f);
+ return -1;
+ }
+ fclose(f);
+ return 0;
+}
+
+inline size_t
+eal_get_hugepage_mem_size(void)
+{
+ uint64_t size = 0;
+ unsigned i, j;
+
+ for (i = 0; i < internal_config.num_hugepage_sizes; i++) {
+ struct hugepage_info *hpi = &internal_config.hugepage_info[i];
+
+ if (hpi->hugedir != NULL) {
+ for (j = 0; j < RTE_MAX_NUMA_NODES; j++)
+ size += hpi->hugepage_sz * hpi->num_pages[j];
+ }
+ }
+
+ return (size < SIZE_MAX) ? (size_t)(size) : SIZE_MAX;
+}
+
+void
+eal_check_mem_on_local_socket(void)
+{
+ const struct rte_memseg *ms;
+ int i, socket_id;
+ struct rte_config *rte_config =
+ rte_eal_get_configuration();
+
+ if (rte_config == NULL) {
+ RTE_LOG(WARNING, EAL, "WARNING: rte_config NULL!\n");
+ return;
+ }
+
+ socket_id = rte_lcore_to_socket_id(rte_config->master_lcore);
+
+ ms = rte_eal_get_physmem_layout();
+
+ for (i = 0; i < RTE_MAX_MEMSEG; i++)
+ if (ms[i].socket_id == socket_id &&
+ ms[i].len > 0)
+ return;
+
+ RTE_LOG(WARNING, EAL, "WARNING: Master core has no "
+ "memory on local socket!\n");
+}
+
+int
+sync_func(__attribute__((unused)) void *arg)
+{
+ return 0;
+}
+
+/* return non-zero if hugepages are enabled. */
+int rte_eal_has_hugepages(void)
+{
+ return !internal_config.no_hugetlbfs;
+}
+
+/* get core role */
+enum rte_lcore_role_t
+rte_eal_lcore_role(unsigned lcore_id)
+{
+ struct rte_config *rte_config =
+ rte_eal_get_configuration();
+
+ if (rte_config == NULL) {
+ RTE_LOG(WARNING, EAL, "WARNING: rte_config NULL!\n");
+ return -1;
+ }
+
+ return rte_config->lcore_role[lcore_id];
+}
diff --git a/lib/librte_eal/common/eal_hugepages.h b/lib/librte_eal/common/eal_hugepages.h
index 38edac0..0b4d7a2 100644
--- a/lib/librte_eal/common/eal_hugepages.h
+++ b/lib/librte_eal/common/eal_hugepages.h
@@ -63,5 +63,6 @@ struct hugepage_file {
* for the EAL to use
*/
int eal_hugepage_info_init(void);
+inline size_t eal_get_hugepage_mem_size(void);
#endif /* EAL_HUGEPAGES_H */
diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h
index 4acf5a0..6dc977e 100644
--- a/lib/librte_eal/common/eal_private.h
+++ b/lib/librte_eal/common/eal_private.h
@@ -36,6 +36,8 @@
#include <stdio.h>
+#include <rte_eal.h>
+
/**
* Initialize the memzone subsystem (private to eal).
*
@@ -232,4 +234,80 @@ int rte_eal_dev_init(void);
*/
int rte_eal_check_module(const char *module_name);
+/**
+ * This function sets up rte_config structure
+ *
+ * This function is private to the EAL.
+ */
+void rte_config_init(void);
+
+/**
+ * This function checks memory on local socket(NUMA)
+ *
+ * This function is private to the EAL.
+ */
+void eal_check_mem_on_local_socket(void);
+
+/**
+ * This function updates shared mem_config INIT DONE
+ *
+ * This function is private to the EAL.
+ */
+inline void rte_eal_mcfg_complete(void);
+
+/**
+ *
+ * This function is private to the EAL.
+ */
+int sync_func(__attribute__((unused)) void *arg);
+
+/**
+ *
+ * This function is private to the EAL.
+ */
+inline void *rte_eal_get_mem_cfg_addr(void);
+
+/**
+ * Return a pointer to the configuration structure
+ *
+ * This function is private to the EAL.
+ */
+struct rte_config *rte_eal_get_configuration(void);
+
+/**
+ * Return memory config file descriptor
+ *
+ * This function is private to the EAL.
+ */
+int *eal_get_mem_cfg_fd(void);
+
+/**
+ * Perform ftruncate and fcntl operations on
+ * memory config file descriptor.
+ *
+ * This function is private to the EAL.
+ */
+int eal_ftruncate_and_fcntl(size_t size);
+
+/**
+ * Get per-application usage message
+ *
+ * This function is private to the EAL.
+ */
+rte_usage_hook_t rte_get_application_usage_hook(void);
+
+/**
+ * This function attaches shared memory config
+ *
+ * This function is private to the EAL.
+ */
+void rte_eal_config_attach(void);
+
+/**
+ * This function reattaches shared memory config
+ *
+ * This function is private to the EAL.
+ */
+void rte_eal_config_reattach(void);
+
#endif /* _EAL_PRIVATE_H_ */
diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h
index 1385a73..daf2ee0 100644
--- a/lib/librte_eal/common/include/rte_eal.h
+++ b/lib/librte_eal/common/include/rte_eal.h
@@ -51,6 +51,10 @@ extern "C" {
#define RTE_MAGIC 19820526 /**< Magic number written by the main partition when ready. */
+#define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
+
+#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10)
+
/**
* The lcore role (used in RTE or not).
*/
diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile
index cf2271c..f68370c 100644
--- a/lib/librte_eal/linuxapp/eal/Makefile
+++ b/lib/librte_eal/linuxapp/eal/Makefile
@@ -90,6 +90,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_devargs.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_dev.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_options.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_thread.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_sysfs.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_mem_cfg.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_proc_type.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_app_usage.c
CFLAGS_eal.o := -D_GNU_SOURCE
CFLAGS_eal_interrupts.o := -D_GNU_SOURCE
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 6335a41..fc4a2b7 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -84,13 +84,6 @@
#include "eal_hugepages.h"
#include "eal_options.h"
-#define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
-
-#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10)
-
-/* Allow the application to print its usage message too if set */
-static rte_usage_hook_t rte_application_usage_hook = NULL;
-
TAILQ_HEAD(shared_driver_list, shared_driver);
/* Definition for shared object drivers. */
@@ -105,25 +98,6 @@ struct shared_driver {
static struct shared_driver_list solib_list =
TAILQ_HEAD_INITIALIZER(solib_list);
-/* early configuration structure, when memory config is not mmapped */
-static struct rte_mem_config early_mem_config;
-
-/* define fd variable here, because file needs to be kept open for the
- * duration of the program, as we hold a write lock on it in the primary proc */
-static int mem_cfg_fd = -1;
-
-static struct flock wr_lock = {
- .l_type = F_WRLCK,
- .l_whence = SEEK_SET,
- .l_start = offsetof(struct rte_mem_config, memseg),
- .l_len = sizeof(early_mem_config.memseg),
-};
-
-/* Address of global and public configuration */
-static struct rte_config rte_config = {
- .mem_config = &early_mem_config,
-};
-
/* internal configuration (per-core) */
struct lcore_config lcore_config[RTE_MAX_LCORE];
@@ -133,196 +107,85 @@ struct internal_config internal_config;
/* used by rte_rdtsc() */
int rte_cycles_vmware_tsc_map;
-/* Return a pointer to the configuration structure */
-struct rte_config *
-rte_eal_get_configuration(void)
-{
- return &rte_config;
-}
-
-/* parse a sysfs (or other) file containing one integer value */
-int
-eal_parse_sysfs_value(const char *filename, unsigned long *val)
-{
- FILE *f;
- char buf[BUFSIZ];
- char *end = NULL;
-
- if ((f = fopen(filename, "r")) == NULL) {
- RTE_LOG(ERR, EAL, "%s(): cannot open sysfs value %s\n",
- __func__, filename);
- return -1;
- }
-
- if (fgets(buf, sizeof(buf), f) == NULL) {
- RTE_LOG(ERR, EAL, "%s(): cannot read sysfs value %s\n",
- __func__, filename);
- fclose(f);
- return -1;
- }
- *val = strtoul(buf, &end, 0);
- if ((buf[0] == '\0') || (end == NULL) || (*end != '\n')) {
- RTE_LOG(ERR, EAL, "%s(): cannot parse sysfs value %s\n",
- __func__, filename);
- fclose(f);
- return -1;
- }
- fclose(f);
- return 0;
-}
-
-
-/* create memory configuration in shared/mmap memory. Take out
- * a write lock on the memsegs, so we can auto-detect primary/secondary.
- * This means we never close the file while running (auto-close on exit).
- * We also don't lock the whole file, so that in future we can use read-locks
- * on other parts, e.g. memzones, to detect if there are running secondary
- * processes. */
-static void
-rte_eal_config_create(void)
+inline void *
+rte_eal_get_mem_cfg_addr(void)
{
- void *rte_mem_cfg_addr;
- int retval;
-
- const char *pathname = eal_runtime_config_path();
-
- if (internal_config.no_shconf)
- return;
+ void *mem_cfg_addr;
- /* map the config before hugepage address so that we don't waste a page */
if (internal_config.base_virtaddr != 0)
- rte_mem_cfg_addr = (void *)
+ mem_cfg_addr = (void *)
RTE_ALIGN_FLOOR(internal_config.base_virtaddr -
sizeof(struct rte_mem_config), sysconf(_SC_PAGE_SIZE));
else
- rte_mem_cfg_addr = NULL;
-
- if (mem_cfg_fd < 0){
- mem_cfg_fd = open(pathname, O_RDWR | O_CREAT, 0660);
- if (mem_cfg_fd < 0)
- rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
- }
-
- retval = ftruncate(mem_cfg_fd, sizeof(*rte_config.mem_config));
- if (retval < 0){
- close(mem_cfg_fd);
- rte_panic("Cannot resize '%s' for rte_mem_config\n", pathname);
- }
-
- retval = fcntl(mem_cfg_fd, F_SETLK, &wr_lock);
- if (retval < 0){
- close(mem_cfg_fd);
- rte_exit(EXIT_FAILURE, "Cannot create lock on '%s'. Is another primary "
- "process running?\n", pathname);
- }
-
- rte_mem_cfg_addr = mmap(rte_mem_cfg_addr, sizeof(*rte_config.mem_config),
- PROT_READ | PROT_WRITE, MAP_SHARED, mem_cfg_fd, 0);
-
- if (rte_mem_cfg_addr == MAP_FAILED){
- rte_panic("Cannot mmap memory for rte_config\n");
- }
- memcpy(rte_mem_cfg_addr, &early_mem_config, sizeof(early_mem_config));
- rte_config.mem_config = (struct rte_mem_config *) rte_mem_cfg_addr;
-
- /* store address of the config in the config itself so that secondary
- * processes could later map the config into this exact location */
- rte_config.mem_config->mem_cfg_addr = (uintptr_t) rte_mem_cfg_addr;
+ mem_cfg_addr = NULL;
+ return mem_cfg_addr;
}
/* attach to an existing shared memory config */
-static void
+void
rte_eal_config_attach(void)
{
struct rte_mem_config *mem_config;
+ struct rte_config *rte_config;
+ int *mem_cfg_fd = eal_get_mem_cfg_fd();
const char *pathname = eal_runtime_config_path();
if (internal_config.no_shconf)
return;
- if (mem_cfg_fd < 0){
- mem_cfg_fd = open(pathname, O_RDWR);
- if (mem_cfg_fd < 0)
+ rte_config = rte_eal_get_configuration();
+ if (rte_config == NULL)
+ return;
+
+ if (*mem_cfg_fd < 0) {
+ *mem_cfg_fd = open(pathname, O_RDWR);
+ if (*mem_cfg_fd < 0)
rte_panic("Cannot open '%s' for rte_mem_config\n", pathname);
}
/* map it as read-only first */
mem_config = (struct rte_mem_config *) mmap(NULL, sizeof(*mem_config),
- PROT_READ, MAP_SHARED, mem_cfg_fd, 0);
+ PROT_READ, MAP_SHARED, *mem_cfg_fd, 0);
if (mem_config == MAP_FAILED)
rte_panic("Cannot mmap memory for rte_config\n");
- rte_config.mem_config = mem_config;
+ rte_config->mem_config = mem_config;
}
/* reattach the shared config at exact memory location primary process has it */
-static void
+void
rte_eal_config_reattach(void)
{
struct rte_mem_config *mem_config;
void *rte_mem_cfg_addr;
+ struct rte_config *rte_config;
+ int *mem_cfg_fd = eal_get_mem_cfg_fd();
if (internal_config.no_shconf)
return;
+ rte_config = rte_eal_get_configuration();
+ if (rte_config == NULL)
+ return;
+
/* save the address primary process has mapped shared config to */
- rte_mem_cfg_addr = (void *) (uintptr_t) rte_config.mem_config->mem_cfg_addr;
+ rte_mem_cfg_addr =
+ (void *) (uintptr_t) rte_config->mem_config->mem_cfg_addr;
/* unmap original config */
- munmap(rte_config.mem_config, sizeof(struct rte_mem_config));
+ munmap(rte_config->mem_config, sizeof(struct rte_mem_config));
/* remap the config at proper address */
mem_config = (struct rte_mem_config *) mmap(rte_mem_cfg_addr,
- sizeof(*mem_config), PROT_READ | PROT_WRITE, MAP_SHARED,
- mem_cfg_fd, 0);
- close(mem_cfg_fd);
+ sizeof(*mem_config), PROT_READ | PROT_WRITE,
+ MAP_SHARED, *mem_cfg_fd, 0);
+ close(*mem_cfg_fd);
if (mem_config == MAP_FAILED || mem_config != rte_mem_cfg_addr)
rte_panic("Cannot mmap memory for rte_config\n");
- rte_config.mem_config = mem_config;
-}
-
-/* Detect if we are a primary or a secondary process */
-enum rte_proc_type_t
-eal_proc_type_detect(void)
-{
- enum rte_proc_type_t ptype = RTE_PROC_PRIMARY;
- const char *pathname = eal_runtime_config_path();
-
- /* if we can open the file but not get a write-lock we are a secondary
- * process. NOTE: if we get a file handle back, we keep that open
- * and don't close it to prevent a race condition between multiple opens */
- if (((mem_cfg_fd = open(pathname, O_RDWR)) >= 0) &&
- (fcntl(mem_cfg_fd, F_SETLK, &wr_lock) < 0))
- ptype = RTE_PROC_SECONDARY;
-
- RTE_LOG(INFO, EAL, "Auto-detected process type: %s\n",
- ptype == RTE_PROC_PRIMARY ? "PRIMARY" : "SECONDARY");
-
- return ptype;
-}
-
-/* Sets up rte_config structure with the pointer to shared memory config.*/
-static void
-rte_config_init(void)
-{
- rte_config.process_type = internal_config.process_type;
-
- switch (rte_config.process_type){
- case RTE_PROC_PRIMARY:
- rte_eal_config_create();
- break;
- case RTE_PROC_SECONDARY:
- rte_eal_config_attach();
- rte_eal_mcfg_wait_complete(rte_config.mem_config);
- rte_eal_config_reattach();
- break;
- case RTE_PROC_AUTO:
- case RTE_PROC_INVALID:
- rte_panic("Invalid process type\n");
- }
+ rte_config->mem_config = mem_config;
}
/* Unlocks hugepage directories that were locked by eal_hugepage_info_init */
@@ -348,6 +211,9 @@ eal_hugedirs_unlock(void)
static void
eal_usage(const char *prgname)
{
+ rte_usage_hook_t rte_application_usage_hook =
+ rte_get_application_usage_hook();
+
printf("\nUsage: %s ", prgname);
eal_common_usage();
printf("EAL Linux options:\n"
@@ -367,19 +233,6 @@ eal_usage(const char *prgname)
}
}
-/* Set a per-application usage message */
-rte_usage_hook_t
-rte_set_application_usage_hook( rte_usage_hook_t usage_func )
-{
- rte_usage_hook_t old_func;
-
- /* Will be NULL on the first call to denote the last usage routine. */
- old_func = rte_application_usage_hook;
- rte_application_usage_hook = usage_func;
-
- return old_func;
-}
-
static int
eal_parse_socket_mem(char *socket_mem)
{
@@ -481,24 +334,6 @@ eal_parse_vfio_intr(const char *mode)
return -1;
}
-static inline size_t
-eal_get_hugepage_mem_size(void)
-{
- uint64_t size = 0;
- unsigned i, j;
-
- for (i = 0; i < internal_config.num_hugepage_sizes; i++) {
- struct hugepage_info *hpi = &internal_config.hugepage_info[i];
- if (hpi->hugedir != NULL) {
- for (j = 0; j < RTE_MAX_NUMA_NODES; j++) {
- size += hpi->hugepage_sz * hpi->num_pages[j];
- }
- }
- }
-
- return (size < SIZE_MAX) ? (size_t)(size) : SIZE_MAX;
-}
-
/* Parse the argument given in the command line of the application */
static int
eal_parse_args(int argc, char **argv)
@@ -645,39 +480,6 @@ eal_parse_args(int argc, char **argv)
return ret;
}
-static void
-eal_check_mem_on_local_socket(void)
-{
- const struct rte_memseg *ms;
- int i, socket_id;
-
- socket_id = rte_lcore_to_socket_id(rte_config.master_lcore);
-
- ms = rte_eal_get_physmem_layout();
-
- for (i = 0; i < RTE_MAX_MEMSEG; i++)
- if (ms[i].socket_id == socket_id &&
- ms[i].len > 0)
- return;
-
- RTE_LOG(WARNING, EAL, "WARNING: Master core has no "
- "memory on local socket!\n");
-}
-
-static int
-sync_func(__attribute__((unused)) void *arg)
-{
- return 0;
-}
-
-inline static void
-rte_eal_mcfg_complete(void)
-{
- /* ALL shared mem_config related INIT DONE */
- if (rte_config.process_type == RTE_PROC_PRIMARY)
- rte_config.mem_config->magic = RTE_MAGIC;
-}
-
/*
* Request iopl privilege for all RPL, returns 0 on success
* iopl() call is mostly for the i386 architecture. For other architectures,
@@ -707,6 +509,12 @@ rte_eal_init(int argc, char **argv)
const char *logid;
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
+ struct rte_config *rte_config;
+
+ rte_config = rte_eal_get_configuration();
+ if (rte_config == NULL)
+ return -1;
+
if (!rte_atomic32_test_and_set(&run_once))
return -1;
@@ -804,12 +612,12 @@ rte_eal_init(int argc, char **argv)
RTE_LOG(WARNING, EAL, "%s\n", dlerror());
}
- eal_thread_init_master(rte_config.master_lcore);
+ eal_thread_init_master(rte_config->master_lcore);
ret = eal_thread_dump_affinity(cpuset, RTE_CPU_AFFINITY_STR_LEN);
RTE_LOG(DEBUG, EAL, "Master lcore %u is ready (tid=%x;cpuset=[%s%s])\n",
- rte_config.master_lcore, (int)thread_id, cpuset,
+ rte_config->master_lcore, (int)thread_id, cpuset,
ret == 0 ? "" : "...");
if (rte_eal_dev_init() < 0)
@@ -858,24 +666,6 @@ rte_eal_init(int argc, char **argv)
return fctret;
}
-/* get core role */
-enum rte_lcore_role_t
-rte_eal_lcore_role(unsigned lcore_id)
-{
- return (rte_config.lcore_role[lcore_id]);
-}
-
-enum rte_proc_type_t
-rte_eal_process_type(void)
-{
- return (rte_config.process_type);
-}
-
-int rte_eal_has_hugepages(void)
-{
- return ! internal_config.no_hugetlbfs;
-}
-
int
rte_eal_check_module(const char *module_name)
{
--
1.9.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v6 3/6] Move common functions in eal_lcore.c
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c Ravi Kerur
@ 2015-04-18 19:43 ` Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 4/6] Move common functions in eal_timer.c Ravi Kerur
` (3 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Ravi Kerur @ 2015-04-18 19:43 UTC (permalink / raw)
To: dev
Changes in v6
None.
Changes in v5
Rebase to latest code.
Changes in v4
Implement cpu_detected() for BSD.
Have common RTE_LOG for Linux and BSD in rte_eal_cpu_init().
Remove RTE_EXEC_ENV_BSDAPP in common file.
Changes in v3
Changed subject to be more explicit on file name inclusion.
Changes in v2
None
Changes in v1
Move common function in eal_lcore.c to librte_eal/common/
eal_common_lcore.c file.
Following function is moved to eal_common_lcore.c file
int rte_eal_cpu_init(void);
Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in
common function.
Makefile changes to reflect new file added.
Fix checkpatch warnings and errors.
Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
lib/librte_eal/bsdapp/eal/Makefile | 1 +
lib/librte_eal/bsdapp/eal/eal_lcore.c | 72 +++++----------------
lib/librte_eal/common/eal_common_lcore.c | 107 +++++++++++++++++++++++++++++++
lib/librte_eal/common/eal_private.h | 14 ++++
lib/librte_eal/linuxapp/eal/Makefile | 2 +
lib/librte_eal/linuxapp/eal/eal_lcore.c | 66 ++-----------------
6 files changed, 143 insertions(+), 119 deletions(-)
create mode 100644 lib/librte_eal/common/eal_common_lcore.c
diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
index 5076a05..1da0410 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -82,6 +82,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_sysfs.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_mem_cfg.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_proc_type.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_app_usage.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_lcore.c
CFLAGS_eal.o := -D_GNU_SOURCE
#CFLAGS_eal_thread.o := -D_GNU_SOURCE
diff --git a/lib/librte_eal/bsdapp/eal/eal_lcore.c b/lib/librte_eal/bsdapp/eal/eal_lcore.c
index 162fb4f..b47eb1b 100644
--- a/lib/librte_eal/bsdapp/eal/eal_lcore.c
+++ b/lib/librte_eal/bsdapp/eal/eal_lcore.c
@@ -44,11 +44,14 @@
#include "eal_thread.h"
/* No topology information available on FreeBSD including NUMA info */
-#define cpu_core_id(X) 0
-#define cpu_socket_id(X) 0
+unsigned
+eal_cpu_core_id(__rte_unused unsigned lcore_id)
+{
+ return 0;
+}
static int
-get_ncpus(void)
+eal_get_ncpus(void)
{
int mib[2] = {CTL_HW, HW_NCPU};
int ncpu;
@@ -59,63 +62,18 @@ get_ncpus(void)
return ncpu;
}
-/*
- * fill the cpu_info structure with as much info as we can get.
- * code is similar to linux version, but sadly available info is less.
- */
-int
-rte_eal_cpu_init(void)
+unsigned
+eal_cpu_socket_id(__rte_unused unsigned cpu_id)
{
- /* pointer to global configuration */
- struct rte_config *config = rte_eal_get_configuration();
- unsigned lcore_id;
- unsigned count = 0;
-
- const unsigned ncpus = get_ncpus();
- /*
- * Parse the maximum set of logical cores, detect the subset of running
- * ones and enable them by default.
- */
- for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
- /* init cpuset for per lcore config */
- CPU_ZERO(&lcore_config[lcore_id].cpuset);
-
- lcore_config[lcore_id].detected = (lcore_id < ncpus);
- if (lcore_config[lcore_id].detected == 0) {
- config->lcore_role[lcore_id] = ROLE_OFF;
- continue;
- }
-
- /* By default, lcore 1:1 map to cpu id */
- CPU_SET(lcore_id, &lcore_config[lcore_id].cpuset);
-
- /* By default, each detected core is enabled */
- config->lcore_role[lcore_id] = ROLE_RTE;
- lcore_config[lcore_id].core_id = cpu_core_id(lcore_id);
- lcore_config[lcore_id].socket_id = cpu_socket_id(lcore_id);
- if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES)
-#ifdef RTE_EAL_ALLOW_INV_SOCKET_ID
- lcore_config[lcore_id].socket_id = 0;
-#else
- rte_panic("Socket ID (%u) is greater than "
- "RTE_MAX_NUMA_NODES (%d)\n",
- lcore_config[lcore_id].socket_id, RTE_MAX_NUMA_NODES);
-#endif
- RTE_LOG(DEBUG, EAL, "Detected lcore %u\n",
- lcore_id);
- count++;
- }
- /* Set the count of enabled logical cores of the EAL configuration */
- config->lcore_count = count;
- RTE_LOG(DEBUG, EAL, "Support maximum %u logical core(s) by configuration.\n",
- RTE_MAX_LCORE);
- RTE_LOG(DEBUG, EAL, "Detected %u lcore(s)\n", config->lcore_count);
-
return 0;
}
-unsigned
-eal_cpu_socket_id(__rte_unused unsigned cpu_id)
+/* Check if a cpu is present by the presence of the
+ * cpu information for it.
+ */
+int
+eal_cpu_detected(unsigned lcore_id)
{
- return cpu_socket_id(cpu_id);
+ const unsigned ncpus = eal_get_ncpus();
+ return (lcore_id < ncpus);
}
diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
new file mode 100644
index 0000000..845140b
--- /dev/null
+++ b/lib/librte_eal/common/eal_common_lcore.c
@@ -0,0 +1,107 @@
+/*-
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <unistd.h>
+#include <limits.h>
+#include <string.h>
+#include <dirent.h>
+
+#include <rte_log.h>
+#include <rte_eal.h>
+#include <rte_lcore.h>
+#include <rte_common.h>
+#include <rte_debug.h>
+
+#include "eal_private.h"
+#include "eal_thread.h"
+
+/*
+ * Parse /sys/devices/system/cpu to get the number of physical and logical
+ * processors on the machine. The function will fill the cpu_info
+ * structure.
+ */
+int
+rte_eal_cpu_init(void)
+{
+ /* pointer to global configuration */
+ struct rte_config *config = rte_eal_get_configuration();
+ unsigned lcore_id;
+ unsigned count = 0;
+
+ /*
+ * Parse the maximum set of logical cores, detect the subset of running
+ * ones and enable them by default.
+ */
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ /* init cpuset for per lcore config */
+ CPU_ZERO(&lcore_config[lcore_id].cpuset);
+
+ /* in 1:1 mapping, record related cpu detected state */
+ lcore_config[lcore_id].detected = eal_cpu_detected(lcore_id);
+ if (lcore_config[lcore_id].detected == 0) {
+ config->lcore_role[lcore_id] = ROLE_OFF;
+ continue;
+ }
+
+ /* By default, lcore 1:1 map to cpu id */
+ CPU_SET(lcore_id, &lcore_config[lcore_id].cpuset);
+
+ /* By default, each detected core is enabled */
+ config->lcore_role[lcore_id] = ROLE_RTE;
+ lcore_config[lcore_id].core_id = eal_cpu_core_id(lcore_id);
+ lcore_config[lcore_id].socket_id = eal_cpu_socket_id(lcore_id);
+ if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES)
+#ifdef RTE_EAL_ALLOW_INV_SOCKET_ID
+ lcore_config[lcore_id].socket_id = 0;
+#else
+ rte_panic("Socket ID (%u) is greater than "
+ "RTE_MAX_NUMA_NODES (%d)\n",
+ lcore_config[lcore_id].socket_id,
+ RTE_MAX_NUMA_NODES);
+#endif
+
+ RTE_LOG(DEBUG, EAL, "Detected lcore %u as "
+ "core %u on socket %u\n",
+ lcore_id, lcore_config[lcore_id].core_id,
+ lcore_config[lcore_id].socket_id);
+ count++;
+ }
+ /* Set the count of enabled logical cores of the EAL configuration */
+ config->lcore_count = count;
+ RTE_LOG(DEBUG, EAL,
+ "Support maximum %u logical core(s) by configuration.\n",
+ RTE_MAX_LCORE);
+ RTE_LOG(DEBUG, EAL, "Detected %u lcore(s)\n", config->lcore_count);
+
+ return 0;
+}
diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h
index 6dc977e..3cc677b 100644
--- a/lib/librte_eal/common/eal_private.h
+++ b/lib/librte_eal/common/eal_private.h
@@ -310,4 +310,18 @@ void rte_eal_config_attach(void);
*/
void rte_eal_config_reattach(void);
+/**
+ * This function gets cpu core_id
+ *
+ * This function is private to the EAL.
+ */
+unsigned eal_cpu_core_id(unsigned lcore_id);
+
+/**
+ * This function check if cpu is present
+ *
+ * This function is private to the EAL.
+ */
+int eal_cpu_detected(unsigned lcore_id);
+
#endif /* _EAL_PRIVATE_H_ */
diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile
index f68370c..c8d2d54 100644
--- a/lib/librte_eal/linuxapp/eal/Makefile
+++ b/lib/librte_eal/linuxapp/eal/Makefile
@@ -94,6 +94,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_sysfs.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_mem_cfg.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_proc_type.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_app_usage.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_lcore.c
CFLAGS_eal.o := -D_GNU_SOURCE
CFLAGS_eal_interrupts.o := -D_GNU_SOURCE
@@ -110,6 +111,7 @@ CFLAGS_eal_pci_vfio_mp_sync.o := -D_GNU_SOURCE
CFLAGS_eal_common_whitelist.o := -D_GNU_SOURCE
CFLAGS_eal_common_options.o := -D_GNU_SOURCE
CFLAGS_eal_common_thread.o := -D_GNU_SOURCE
+CFLAGS_eal_common_lcore.o := -D_GNU_SOURCE
# workaround for a gcc bug with noreturn attribute
# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603
diff --git a/lib/librte_eal/linuxapp/eal/eal_lcore.c b/lib/librte_eal/linuxapp/eal/eal_lcore.c
index ef8c433..9af6d38 100644
--- a/lib/librte_eal/linuxapp/eal/eal_lcore.c
+++ b/lib/librte_eal/linuxapp/eal/eal_lcore.c
@@ -52,8 +52,8 @@
#define PHYS_PKG_FILE "topology/physical_package_id"
/* Check if a cpu is present by the presence of the cpu information for it */
-static int
-cpu_detected(unsigned lcore_id)
+int
+eal_cpu_detected(unsigned lcore_id)
{
char path[PATH_MAX];
int len = snprintf(path, sizeof(path), SYS_CPU_DIR
@@ -122,8 +122,8 @@ err:
}
/* Get the cpu core id value from the /sys/.../cpuX core_id value */
-static unsigned
-cpu_core_id(unsigned lcore_id)
+unsigned
+eal_cpu_core_id(unsigned lcore_id)
{
char path[PATH_MAX];
unsigned long id;
@@ -140,61 +140,3 @@ err:
"for lcore %u - assuming core 0\n", SYS_CPU_DIR, lcore_id);
return 0;
}
-
-/*
- * Parse /sys/devices/system/cpu to get the number of physical and logical
- * processors on the machine. The function will fill the cpu_info
- * structure.
- */
-int
-rte_eal_cpu_init(void)
-{
- /* pointer to global configuration */
- struct rte_config *config = rte_eal_get_configuration();
- unsigned lcore_id;
- unsigned count = 0;
-
- /*
- * Parse the maximum set of logical cores, detect the subset of running
- * ones and enable them by default.
- */
- for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
- /* init cpuset for per lcore config */
- CPU_ZERO(&lcore_config[lcore_id].cpuset);
-
- /* in 1:1 mapping, record related cpu detected state */
- lcore_config[lcore_id].detected = cpu_detected(lcore_id);
- if (lcore_config[lcore_id].detected == 0) {
- config->lcore_role[lcore_id] = ROLE_OFF;
- continue;
- }
-
- /* By default, lcore 1:1 map to cpu id */
- CPU_SET(lcore_id, &lcore_config[lcore_id].cpuset);
-
- /* By default, each detected core is enabled */
- config->lcore_role[lcore_id] = ROLE_RTE;
- lcore_config[lcore_id].core_id = cpu_core_id(lcore_id);
- lcore_config[lcore_id].socket_id = eal_cpu_socket_id(lcore_id);
- if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES)
-#ifdef RTE_EAL_ALLOW_INV_SOCKET_ID
- lcore_config[lcore_id].socket_id = 0;
-#else
- rte_panic("Socket ID (%u) is greater than "
- "RTE_MAX_NUMA_NODES (%d)\n",
- lcore_config[lcore_id].socket_id, RTE_MAX_NUMA_NODES);
-#endif
- RTE_LOG(DEBUG, EAL, "Detected lcore %u as core %u on socket %u\n",
- lcore_id,
- lcore_config[lcore_id].core_id,
- lcore_config[lcore_id].socket_id);
- count ++;
- }
- /* Set the count of enabled logical cores of the EAL configuration */
- config->lcore_count = count;
- RTE_LOG(DEBUG, EAL, "Support maximum %u logical core(s) by configuration.\n",
- RTE_MAX_LCORE);
- RTE_LOG(DEBUG, EAL, "Detected %u lcore(s)\n", config->lcore_count);
-
- return 0;
-}
--
1.9.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v6 4/6] Move common functions in eal_timer.c
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 3/6] Move common functions in eal_lcore.c Ravi Kerur
@ 2015-04-18 19:43 ` Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 5/6] Move common functions in eal_memory.c Ravi Kerur
` (2 subsequent siblings)
5 siblings, 0 replies; 15+ messages in thread
From: Ravi Kerur @ 2015-04-18 19:43 UTC (permalink / raw)
To: dev
Changes in v6
Added new line between Copyright and header file inclusion
in eal_common_timer.c.
Changes in v5
Rebase to latest code.
Changes in v4
Removed extern declaration of eal_tsc_resolution_hz,
instead provided _set_ API.
Make set_tsc_freq_from_clock as wrapper function for BSD.
Changes in v3
Changed subject to be more explicit on file name inclusion.
Changes in v2
Use common function name set_tsc_freq_from_sysctl for BSD and Linux.
Update comments about its actuality in function declaration.
Changes in v1
Move common functions in eal_timer.c to librte_eal/common/
eal_common_timer.c file.
Following functions are moved to eal_common_timer.c file
void rte_delay_us(unsigned us);
uint64_t rte_get_tsc_hz(void);
static void set_tsc_freq_fallback(void);
void set_tsc_freq(void);
Makefile changes to reflect new file added.
Fix checkpatch warnings and errors.
Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
lib/librte_eal/bsdapp/eal/Makefile | 1 +
lib/librte_eal/bsdapp/eal/eal_timer.c | 52 +++-------------
lib/librte_eal/common/eal_common_timer.c | 102 +++++++++++++++++++++++++++++++
lib/librte_eal/common/eal_private.h | 24 ++++++++
lib/librte_eal/linuxapp/eal/Makefile | 1 +
lib/librte_eal/linuxapp/eal/eal_timer.c | 55 ++---------------
6 files changed, 140 insertions(+), 95 deletions(-)
create mode 100644 lib/librte_eal/common/eal_common_timer.c
diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile
index 1da0410..d8e6ced 100644
--- a/lib/librte_eal/bsdapp/eal/Makefile
+++ b/lib/librte_eal/bsdapp/eal/Makefile
@@ -83,6 +83,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_mem_cfg.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_proc_type.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_app_usage.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_lcore.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_timer.c
CFLAGS_eal.o := -D_GNU_SOURCE
#CFLAGS_eal_thread.o := -D_GNU_SOURCE
diff --git a/lib/librte_eal/bsdapp/eal/eal_timer.c b/lib/librte_eal/bsdapp/eal/eal_timer.c
index 7147abe..ee7a5ac 100644
--- a/lib/librte_eal/bsdapp/eal/eal_timer.c
+++ b/lib/librte_eal/bsdapp/eal/eal_timer.c
@@ -55,29 +55,12 @@
enum timer_source eal_timer_source = EAL_TIMER_TSC;
-/* The frequency of the RDTSC timer resolution */
-static uint64_t eal_tsc_resolution_hz = 0;
-
-void
-rte_delay_us(unsigned us)
-{
- const uint64_t start = rte_get_timer_cycles();
- const uint64_t ticks = (uint64_t)us * rte_get_timer_hz() / 1E6;
- while ((rte_get_timer_cycles() - start) < ticks)
- rte_pause();
-}
-
-uint64_t
-rte_get_tsc_hz(void)
-{
- return eal_tsc_resolution_hz;
-}
-
static int
set_tsc_freq_from_sysctl(void)
{
size_t sz;
int tmp;
+ uint64_t tsc_hz;
sz = sizeof(tmp);
tmp = 0;
@@ -94,42 +77,23 @@ set_tsc_freq_from_sysctl(void)
else if (tmp != 1)
RTE_LOG(WARNING, EAL, "TSC is not invariant\n");
- sz = sizeof(eal_tsc_resolution_hz);
- if (sysctlbyname("machdep.tsc_freq", &eal_tsc_resolution_hz, &sz, NULL, 0)) {
+ sz = sizeof(tsc_hz);
+ if (sysctlbyname("machdep.tsc_freq", &tsc_hz, &sz, NULL, 0)) {
RTE_LOG(WARNING, EAL, "%s\n", strerror(errno));
return -1;
}
+ rte_set_tsc_hz(tsc_hz);
return 0;
}
-static void
-set_tsc_freq_fallback(void)
-{
- RTE_LOG(WARNING, EAL, "WARNING: clock_gettime cannot use "
- "CLOCK_MONOTONIC_RAW and HPET is not available"
- " - clock timings may be less accurate.\n");
- /* assume that the sleep(1) will sleep for 1 second */
- uint64_t start = rte_rdtsc();
- sleep(1);
- eal_tsc_resolution_hz = rte_rdtsc() - start;
-}
-
/*
- * This function measures the TSC frequency. It uses a variety of approaches.
- *
- * 1. Read the TSC frequency value provided by the kernel
- * 2. If above does not work, just sleep for 1 second and tune off that,
- * printing a warning about inaccuracy of timing
+ * Wrapper function to get TSC frequency from sysctl.
*/
-static void
-set_tsc_freq(void)
+int
+set_tsc_freq_from_clock(void)
{
- if (set_tsc_freq_from_sysctl() < 0)
- set_tsc_freq_fallback();
-
- RTE_LOG(INFO, EAL, "TSC frequency is ~%"PRIu64" KHz\n",
- eal_tsc_resolution_hz/1000);
+ return set_tsc_freq_from_sysctl();
}
int
diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c
new file mode 100644
index 0000000..5fddd6e
--- /dev/null
+++ b/lib/librte_eal/common/eal_common_timer.c
@@ -0,0 +1,102 @@
+/*-
+ * BSD LICENSE
+ *
+ * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Intel Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <string.h>
+#include <stdio.h>
+#include <unistd.h>
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/sysctl.h>
+#include <errno.h>
+
+#include <rte_common.h>
+#include <rte_log.h>
+#include <rte_cycles.h>
+
+#include "eal_private.h"
+#include "eal_internal_cfg.h"
+
+/* The frequency of the RDTSC timer resolution */
+uint64_t eal_tsc_resolution_hz = 0;
+
+void
+rte_delay_us(unsigned us)
+{
+ const uint64_t start = rte_get_timer_cycles();
+ const uint64_t ticks = (uint64_t)us * rte_get_timer_hz() / 1E6;
+
+ while ((rte_get_timer_cycles() - start) < ticks)
+ rte_pause();
+}
+
+uint64_t
+rte_get_tsc_hz(void)
+{
+ return eal_tsc_resolution_hz;
+}
+
+void
+rte_set_tsc_hz(uint64_t tsc_hz)
+{
+ eal_tsc_resolution_hz = tsc_hz;
+}
+
+static void
+set_tsc_freq_fallback(void)
+{
+ RTE_LOG(WARNING, EAL, "WARNING: clock_gettime cannot use "
+ "CLOCK_MONOTONIC_RAW and HPET is not available"
+ " - clock timings may be less accurate.\n");
+ /* assume that the sleep(1) will sleep for 1 second */
+ uint64_t start = rte_rdtsc();
+
+ sleep(1);
+ eal_tsc_resolution_hz = rte_rdtsc() - start;
+}
+
+/*
+ * This function measures the TSC frequency. It uses a variety of approaches.
+ *
+ * 1. Read the TSC frequency value provided by the kernel
+ * 2. If above does not work, just sleep for 1 second and tune off that,
+ * printing a warning about inaccuracy of timing
+ */
+void
+set_tsc_freq(void)
+{
+ if (set_tsc_freq_from_clock() < 0)
+ set_tsc_freq_fallback();
+
+ RTE_LOG(INFO, EAL, "TSC frequency is ~%"PRIu64" KHz\n",
+ eal_tsc_resolution_hz/1000);
+}
diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h
index 3cc677b..0311638 100644
--- a/lib/librte_eal/common/eal_private.h
+++ b/lib/librte_eal/common/eal_private.h
@@ -324,4 +324,28 @@ unsigned eal_cpu_core_id(unsigned lcore_id);
*/
int eal_cpu_detected(unsigned lcore_id);
+/**
+ * This function measures TSC frequency
+ *
+ * This function is private to the EAL.
+ */
+void set_tsc_freq(void);
+
+/**
+ * This function sets TSC frequency from sysctl
+ * for BSD and from clock for Linux.
+ * Is a wrapper function for BSD which will
+ * internally call set_tsc_freq_from_sysctl.
+ *
+ * This function is private to the EAL.
+ */
+int set_tsc_freq_from_clock(void);
+
+/**
+ * This function sets TSC frequency
+ *
+ * This function is private to the EAL.
+ */
+void rte_set_tsc_hz(uint64_t tsc_hz);
+
#endif /* _EAL_PRIVATE_H_ */
diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile
index c8d2d54..89180e8 100644
--- a/lib/librte_eal/linuxapp/eal/Makefile
+++ b/lib/librte_eal/linuxapp/eal/Makefile
@@ -95,6 +95,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_mem_cfg.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_proc_type.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_app_usage.c
SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_lcore.c
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_timer.c
CFLAGS_eal.o := -D_GNU_SOURCE
CFLAGS_eal_interrupts.o := -D_GNU_SOURCE
diff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c b/lib/librte_eal/linuxapp/eal/eal_timer.c
index b19b18e..26e148a 100644
--- a/lib/librte_eal/linuxapp/eal/eal_timer.c
+++ b/lib/librte_eal/linuxapp/eal/eal_timer.c
@@ -58,9 +58,6 @@
enum timer_source eal_timer_source = EAL_TIMER_HPET;
-/* The frequency of the RDTSC timer resolution */
-static uint64_t eal_tsc_resolution_hz = 0;
-
#ifdef RTE_LIBEAL_USE_HPET
#define DEV_HPET "/dev/hpet"
@@ -161,23 +158,6 @@ rte_get_hpet_cycles(void)
#endif
-
-void
-rte_delay_us(unsigned us)
-{
- const uint64_t start = rte_get_timer_cycles();
- const uint64_t ticks = (uint64_t)us * rte_get_timer_hz() / 1E6;
- while ((rte_get_timer_cycles() - start) < ticks)
- rte_pause();
-}
-
-uint64_t
-rte_get_tsc_hz(void)
-{
- return eal_tsc_resolution_hz;
-}
-
-
#ifdef RTE_LIBEAL_USE_HPET
/*
* Open and mmap /dev/hpet (high precision event timer) that will
@@ -288,7 +268,7 @@ check_tsc_flags(void)
fclose(stream);
}
-static int
+int
set_tsc_freq_from_clock(void)
{
#ifdef CLOCK_MONOTONIC_RAW
@@ -297,6 +277,7 @@ set_tsc_freq_from_clock(void)
struct timespec sleeptime = {.tv_nsec = 5E8 }; /* 1/2 second */
struct timespec t_start, t_end;
+ uint64_t tsc_hz;
if (clock_gettime(CLOCK_MONOTONIC_RAW, &t_start) == 0) {
uint64_t ns, end, start = rte_rdtsc();
@@ -307,42 +288,14 @@ set_tsc_freq_from_clock(void)
ns += (t_end.tv_nsec - t_start.tv_nsec);
double secs = (double)ns/NS_PER_SEC;
- eal_tsc_resolution_hz = (uint64_t)((end - start)/secs);
+ tsc_hz = (uint64_t)((end - start)/secs);
+ rte_set_tsc_hz(tsc_hz);
return 0;
}
#endif
return -1;
}
-static void
-set_tsc_freq_fallback(void)
-{
- RTE_LOG(WARNING, EAL, "WARNING: clock_gettime cannot use "
- "CLOCK_MONOTONIC_RAW and HPET is not available"
- " - clock timings may be less accurate.\n");
- /* assume that the sleep(1) will sleep for 1 second */
- uint64_t start = rte_rdtsc();
- sleep(1);
- eal_tsc_resolution_hz = rte_rdtsc() - start;
-}
-/*
- * This function measures the TSC frequency. It uses a variety of approaches.
- *
- * 1. If kernel provides CLOCK_MONOTONIC_RAW we use that to tune the TSC value
- * 2. If kernel does not provide that, and we have HPET support, tune using HPET
- * 3. Lastly, if neither of the above can be used, just sleep for 1 second and
- * tune off that, printing a warning about inaccuracy of timing
- */
-static void
-set_tsc_freq(void)
-{
- if (set_tsc_freq_from_clock() < 0)
- set_tsc_freq_fallback();
-
- RTE_LOG(INFO, EAL, "TSC frequency is ~%"PRIu64" KHz\n",
- eal_tsc_resolution_hz/1000);
-}
-
int
rte_eal_timer_init(void)
{
--
1.9.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v6 5/6] Move common functions in eal_memory.c
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
` (2 preceding siblings ...)
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 4/6] Move common functions in eal_timer.c Ravi Kerur
@ 2015-04-18 19:43 ` Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 6/6] Move common functions in eal_pci.c Ravi Kerur
2015-04-21 14:25 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Bruce Richardson
5 siblings, 0 replies; 15+ messages in thread
From: Ravi Kerur @ 2015-04-18 19:43 UTC (permalink / raw)
To: dev
Changes in v6
Removed unnecessary comments in function declaration.
Changes in v5
Rebase to latest code.
Changes in v4
Make rte_eal_hugepage_init and rte_eal_hugepage_attach as
wrapper functions for BSD.
Changes in v3
Changed subject to be more explicit on file name inclusion.
Changes in v2
Use common function names rte_eal_hugepage_init and
rte_eal_hugepage_attach for BSD and Linux. Update comments about its
actuality in function declaration.
Changes in v1
Move common functions in eal_memory.c to librte_eal/common/
eal_common_memory.c file.
Following functions are moved to eal_common_memory.c file
static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void);
Fix checkpatch warnings and errors.
Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
lib/librte_eal/bsdapp/eal/eal_memory.c | 47 +++++++++++--------------------
lib/librte_eal/common/eal_common_memory.c | 38 +++++++++++++++++++++++--
lib/librte_eal/common/eal_private.h | 20 +++++++++++--
lib/librte_eal/linuxapp/eal/eal_memory.c | 36 ++---------------------
4 files changed, 72 insertions(+), 69 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c
index 33ebd0f..77c27b3 100644
--- a/lib/librte_eal/bsdapp/eal/eal_memory.c
+++ b/lib/librte_eal/bsdapp/eal/eal_memory.c
@@ -59,7 +59,7 @@ rte_mem_virt2phy(const void *virtaddr)
return RTE_BAD_PHYS_ADDR;
}
-static int
+static inline int
rte_eal_contigmem_init(void)
{
struct rte_mem_config *mcfg;
@@ -131,7 +131,16 @@ rte_eal_contigmem_init(void)
return 0;
}
-static int
+/*
+ * Wrapper function to initialize contigmem.
+ */
+int
+rte_eal_hugepage_init(void)
+{
+ return rte_eal_contigmem_init();
+}
+
+static inline int
rte_eal_contigmem_attach(void)
{
const struct hugepage_info *hpi;
@@ -192,35 +201,11 @@ error:
return -1;
}
-
-static int
-rte_eal_memdevice_init(void)
-{
- struct rte_config *config;
-
- if (rte_eal_process_type() == RTE_PROC_SECONDARY)
- return 0;
-
- config = rte_eal_get_configuration();
- config->mem_config->nchannel = internal_config.force_nchannel;
- config->mem_config->nrank = internal_config.force_nrank;
-
- return 0;
-}
-
-/* init memory subsystem */
+/*
+ * Wrapper function to attach contigmem.
+ */
int
-rte_eal_memory_init(void)
+rte_eal_hugepage_attach(void)
{
- RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n");
- const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
- rte_eal_contigmem_init() :
- rte_eal_contigmem_attach();
- if (retval < 0)
- return -1;
-
- if (internal_config.no_shconf == 0 && rte_eal_memdevice_init() < 0)
- return -1;
-
- return 0;
+ return rte_eal_contigmem_attach();
}
diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
index 9a07b1e..10ff0bc 100644
--- a/lib/librte_eal/common/eal_common_memory.c
+++ b/lib/librte_eal/common/eal_common_memory.c
@@ -45,6 +45,7 @@
#include <rte_log.h>
#include "eal_private.h"
+#include "eal_internal_cfg.h"
/*
* Return a pointer to a read-only table of struct rte_physmem_desc
@@ -69,7 +70,7 @@ rte_eal_get_physmem_size(void)
/* get pointer to global configuration */
mcfg = rte_eal_get_configuration()->mem_config;
- for (i=0; i<RTE_MAX_MEMSEG; i++) {
+ for (i = 0; i < RTE_MAX_MEMSEG; i++) {
if (mcfg->memseg[i].addr == NULL)
break;
@@ -89,7 +90,7 @@ rte_dump_physmem_layout(FILE *f)
/* get pointer to global configuration */
mcfg = rte_eal_get_configuration()->mem_config;
- for (i=0; i<RTE_MAX_MEMSEG; i++) {
+ for (i = 0; i < RTE_MAX_MEMSEG; i++) {
if (mcfg->memseg[i].addr == NULL)
break;
@@ -118,3 +119,36 @@ unsigned rte_memory_get_nrank(void)
{
return rte_eal_get_configuration()->mem_config->nrank;
}
+
+static int
+rte_eal_memdevice_init(void)
+{
+ struct rte_config *config;
+
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY)
+ return 0;
+
+ config = rte_eal_get_configuration();
+ config->mem_config->nchannel = internal_config.force_nchannel;
+ config->mem_config->nrank = internal_config.force_nrank;
+
+ return 0;
+}
+
+/* init memory subsystem */
+int
+rte_eal_memory_init(void)
+{
+ RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n");
+ const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
+ rte_eal_hugepage_init() :
+ rte_eal_hugepage_attach();
+
+ if (retval < 0)
+ return -1;
+
+ if (internal_config.no_shconf == 0 && rte_eal_memdevice_init() < 0)
+ return -1;
+
+ return 0;
+}
diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h
index 0311638..5fd9b50 100644
--- a/lib/librte_eal/common/eal_private.h
+++ b/lib/librte_eal/common/eal_private.h
@@ -334,8 +334,6 @@ void set_tsc_freq(void);
/**
* This function sets TSC frequency from sysctl
* for BSD and from clock for Linux.
- * Is a wrapper function for BSD which will
- * internally call set_tsc_freq_from_sysctl.
*
* This function is private to the EAL.
*/
@@ -348,4 +346,22 @@ int set_tsc_freq_from_clock(void);
*/
void rte_set_tsc_hz(uint64_t tsc_hz);
+/**
+ * This function prepares physical memory mapping
+ * i.e. hugepages on Linux and
+ * contigmem on BSD.
+ *
+ * This function is private to the EAL.
+ */
+int rte_eal_hugepage_init(void);
+
+/**
+ * This function creates memory mapping in secondary
+ * i.e. hugepages on Linux and
+ * contigmem on BSD.
+ *
+ * This function is private to the EAL.
+ */
+int rte_eal_hugepage_attach(void);
+
#endif /* _EAL_PRIVATE_H_ */
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
index 5f9f92e..c83a2cb 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -1030,7 +1030,7 @@ calc_num_pages_per_socket(uint64_t * memory,
* 6. unmap the first mapping
* 7. fill memsegs in configuration with contiguous zones
*/
-static int
+int
rte_eal_hugepage_init(void)
{
struct rte_mem_config *mcfg;
@@ -1368,7 +1368,7 @@ getFileSize(int fd)
* configuration and finds the hugepages which form that segment, mapping them
* in order to form a contiguous block in the virtual memory space
*/
-static int
+int
rte_eal_hugepage_attach(void)
{
const struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
@@ -1529,35 +1529,3 @@ error:
return -1;
}
-static int
-rte_eal_memdevice_init(void)
-{
- struct rte_config *config;
-
- if (rte_eal_process_type() == RTE_PROC_SECONDARY)
- return 0;
-
- config = rte_eal_get_configuration();
- config->mem_config->nchannel = internal_config.force_nchannel;
- config->mem_config->nrank = internal_config.force_nrank;
-
- return 0;
-}
-
-
-/* init memory subsystem */
-int
-rte_eal_memory_init(void)
-{
- RTE_LOG(INFO, EAL, "Setting up memory...\n");
- const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
- rte_eal_hugepage_init() :
- rte_eal_hugepage_attach();
- if (retval < 0)
- return -1;
-
- if (internal_config.no_shconf == 0 && rte_eal_memdevice_init() < 0)
- return -1;
-
- return 0;
-}
--
1.9.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v6 6/6] Move common functions in eal_pci.c
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
` (3 preceding siblings ...)
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 5/6] Move common functions in eal_memory.c Ravi Kerur
@ 2015-04-18 19:43 ` Ravi Kerur
2015-04-21 14:25 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Bruce Richardson
5 siblings, 0 replies; 15+ messages in thread
From: Ravi Kerur @ 2015-04-18 19:43 UTC (permalink / raw)
To: dev
Changes in v6
Split changes due to complexity. v6 includes moving
rte_eal_pci_probe_one_driver function and its associated
utility functions only.
Changes in v5
Rebase to latest code.
Removed RTE_EXEC_ENV_BSDAPP from earlier changes.
Changes in v4
Move common functions in eal_pci.c to librte_eal/common/
eal_common_pci.c file.
Following functions are moved to eal_common_pci.c file.
void *pci_map_resource(void *requested_addr, const int vfio_fd,
const char *devname, off_t offset, size_t size);
int pci_addr_comparison(struct rte_pci_addr *addr,
struct rte_pci_addr *addr2);
int rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,
struct rte_pci_device *dev);
Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in
common function.
Fix checkpatch warnings and errors.
Changes in v3
N/A
Changes in v2
N/A
Changes in v1
N/A
Signed-off-by: Ravi Kerur <rkerur@gmail.com>
---
lib/librte_eal/bsdapp/eal/eal_pci.c | 72 +++++---------------------------
lib/librte_eal/common/eal_common_pci.c | 72 ++++++++++++++++++++++++++++++++
lib/librte_eal/common/eal_private.h | 39 +++++++++++++-----
lib/librte_eal/linuxapp/eal/eal_pci.c | 75 +---------------------------------
4 files changed, 113 insertions(+), 145 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 30f0232..f21b5b6 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -111,7 +111,7 @@ static struct rte_tailq_elem rte_uio_tailq = {
EAL_REGISTER_TAILQ(rte_uio_tailq)
/* unbind kernel driver for this device */
-static int
+int
pci_unbind_kernel_driver(struct rte_pci_device *dev __rte_unused)
{
RTE_LOG(ERR, EAL, "RTE_PCI_DRV_FORCE_UNBIND flag is not implemented "
@@ -274,6 +274,13 @@ pci_uio_map_resource(struct rte_pci_device *dev)
return (0);
}
+/* map the PCI resource of a PCI device in virtual memory */
+int
+pci_map_device(struct rte_pci_device *dev)
+{
+ return pci_uio_map_resource(dev);
+}
+
/* Scan one pci sysfs entry, and fill the devices list from it. */
static int
pci_scan_one(int dev_pci_fd, struct pci_conf *conf)
@@ -426,68 +433,11 @@ error:
}
/*
- * If vendor/device ID match, call the devinit() function of the
- * driver.
+ * This function is a no-op in BSD.
*/
-int
-rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *dev)
+void
+pci_config_space_set(struct rte_pci_device *dev __rte_unused)
{
- struct rte_pci_id *id_table;
- int ret;
-
- for (id_table = dr->id_table ; id_table->vendor_id != 0; id_table++) {
-
- /* check if device's identifiers match the driver's ones */
- if (id_table->vendor_id != dev->id.vendor_id &&
- id_table->vendor_id != PCI_ANY_ID)
- continue;
- if (id_table->device_id != dev->id.device_id &&
- id_table->device_id != PCI_ANY_ID)
- continue;
- if (id_table->subsystem_vendor_id != dev->id.subsystem_vendor_id &&
- id_table->subsystem_vendor_id != PCI_ANY_ID)
- continue;
- if (id_table->subsystem_device_id != dev->id.subsystem_device_id &&
- id_table->subsystem_device_id != PCI_ANY_ID)
- continue;
-
- struct rte_pci_addr *loc = &dev->addr;
-
- RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
- loc->domain, loc->bus, loc->devid, loc->function,
- dev->numa_node);
-
- RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
- dev->id.device_id, dr->name);
-
- /* no initialization when blacklisted, return without error */
- if (dev->devargs != NULL &&
- dev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {
-
- RTE_LOG(DEBUG, EAL, " Device is blacklisted, not initializing\n");
- return 0;
- }
-
- if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
- /* map resources for devices that use igb_uio */
- ret = pci_uio_map_resource(dev);
- if (ret != 0)
- return ret;
- } else if (dr->drv_flags & RTE_PCI_DRV_FORCE_UNBIND &&
- rte_eal_process_type() == RTE_PROC_PRIMARY) {
- /* unbind current driver */
- if (pci_unbind_kernel_driver(dev) < 0)
- return -1;
- }
-
- /* reference driver structure */
- dev->driver = dr;
-
- /* call the driver devinit() function */
- return dr->devinit(dr, dev);
- }
- /* return positive value if driver is not found */
- return 1;
}
/* Init the PCI EAL subsystem */
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 808b87b..29b0b63 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -99,6 +99,78 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)
}
/*
+ * If vendor/device ID match, call the devinit() function of the
+ * driver.
+ */
+static int
+rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,
+ struct rte_pci_device *dev)
+{
+ int ret;
+ struct rte_pci_id *id_table;
+
+ for (id_table = dr->id_table ; id_table->vendor_id != 0; id_table++) {
+
+ /* check if device's identifiers match the driver's ones */
+ if (id_table->vendor_id != dev->id.vendor_id &&
+ id_table->vendor_id != PCI_ANY_ID)
+ continue;
+ if (id_table->device_id != dev->id.device_id &&
+ id_table->device_id != PCI_ANY_ID)
+ continue;
+ if (id_table->subsystem_vendor_id != dev->id.subsystem_vendor_id &&
+ id_table->subsystem_vendor_id != PCI_ANY_ID)
+ continue;
+ if (id_table->subsystem_device_id != dev->id.subsystem_device_id &&
+ id_table->subsystem_device_id != PCI_ANY_ID)
+ continue;
+
+ struct rte_pci_addr *loc = &dev->addr;
+
+ RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
+ loc->domain, loc->bus, loc->devid, loc->function,
+ dev->numa_node);
+
+ RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
+ dev->id.device_id, dr->name);
+
+ /* no initialization when blacklisted, return without error */
+ if (dev->devargs != NULL &&
+ dev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {
+ RTE_LOG(DEBUG, EAL, " Device is blacklisted, not initializing\n");
+ return 1;
+ }
+
+ if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
+#ifdef RTE_PCI_CONFIG
+ /*
+ * Set PCIe config space for high performance.
+ * Return value can be ignored.
+ */
+ pci_config_space_set(dev);
+#endif
+ /* map resources for devices that use igb_uio */
+ ret = pci_map_device(dev);
+ if (ret != 0)
+ return ret;
+ } else if (dr->drv_flags & RTE_PCI_DRV_FORCE_UNBIND &&
+ rte_eal_process_type() == RTE_PROC_PRIMARY) {
+ /* unbind current driver */
+ if (pci_unbind_kernel_driver(dev) < 0)
+ return -1;
+ }
+
+ /* reference driver structure */
+ dev->driver = dr;
+
+ /* call the driver devinit() function */
+ return dr->devinit(dr, dev);
+ }
+ /* return positive value if driver is not found */
+ return 1;
+}
+
+/*
* If vendor/device ID match, call the devinit() function of all
* registered driver for the given device. Return -1 if initialization
* failed, return 1 if no driver is found for this device.
diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h
index 5fd9b50..6eb8a6c 100644
--- a/lib/librte_eal/common/eal_private.h
+++ b/lib/librte_eal/common/eal_private.h
@@ -156,17 +156,6 @@ struct rte_pci_driver;
struct rte_pci_device;
/**
- * Mmap memory for single PCI device
- *
- * This function is private to EAL.
- *
- * @return
- * 0 on success, negative on error
- */
-int rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,
- struct rte_pci_device *dev);
-
-/**
* Munmap memory for single PCI device
*
* This function is private to EAL.
@@ -364,4 +353,32 @@ int rte_eal_hugepage_init(void);
*/
int rte_eal_hugepage_attach(void);
+/**
+ * This function unbinds kernel driver for this device
+ *
+ * This function is private to the EAL.
+ */
+int
+pci_unbind_kernel_driver(struct rte_pci_device *dev);
+
+/**
+ * This function maps resources for devices
+ * that use igb_uio on Linux and it's a
+ * wrapper for pci_uio_map_resource on BSD.
+ *
+ * This function is private to the EAL.
+ */
+int
+pci_map_device(struct rte_pci_device *dev);
+
+/**
+ * This function sets PCIe config space for
+ * high performance.
+ * It's a NO-OP on BSD.
+ *
+ * This function is private to the EAL.
+ */
+void
+pci_config_space_set(struct rte_pci_device *dev);
+
#endif /* _EAL_PRIVATE_H_ */
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 9cb0ffd..85c728d 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -57,7 +57,7 @@
*/
/* unbind kernel driver for this device */
-static int
+int
pci_unbind_kernel_driver(struct rte_pci_device *dev)
{
int n;
@@ -563,7 +563,7 @@ pci_config_space_set(struct rte_pci_device *dev)
}
#endif
-static int
+int
pci_map_device(struct rte_pci_device *dev)
{
int ret = -1;
@@ -616,77 +616,6 @@ pci_unmap_device(struct rte_pci_device *dev)
}
#endif /* RTE_LIBRTE_EAL_HOTPLUG */
-/*
- * If vendor/device ID match, call the devinit() function of the
- * driver.
- */
-int
-rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *dev)
-{
- int ret;
- struct rte_pci_id *id_table;
-
- for (id_table = dr->id_table ; id_table->vendor_id != 0; id_table++) {
-
- /* check if device's identifiers match the driver's ones */
- if (id_table->vendor_id != dev->id.vendor_id &&
- id_table->vendor_id != PCI_ANY_ID)
- continue;
- if (id_table->device_id != dev->id.device_id &&
- id_table->device_id != PCI_ANY_ID)
- continue;
- if (id_table->subsystem_vendor_id != dev->id.subsystem_vendor_id &&
- id_table->subsystem_vendor_id != PCI_ANY_ID)
- continue;
- if (id_table->subsystem_device_id != dev->id.subsystem_device_id &&
- id_table->subsystem_device_id != PCI_ANY_ID)
- continue;
-
- struct rte_pci_addr *loc = &dev->addr;
-
- RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
- loc->domain, loc->bus, loc->devid, loc->function,
- dev->numa_node);
-
- RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
- dev->id.device_id, dr->name);
-
- /* no initialization when blacklisted, return without error */
- if (dev->devargs != NULL &&
- dev->devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) {
- RTE_LOG(DEBUG, EAL, " Device is blacklisted, not initializing\n");
- return 1;
- }
-
- if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
-#ifdef RTE_PCI_CONFIG
- /*
- * Set PCIe config space for high performance.
- * Return value can be ignored.
- */
- pci_config_space_set(dev);
-#endif
- /* map resources for devices that use igb_uio */
- ret = pci_map_device(dev);
- if (ret != 0)
- return ret;
- } else if (dr->drv_flags & RTE_PCI_DRV_FORCE_UNBIND &&
- rte_eal_process_type() == RTE_PROC_PRIMARY) {
- /* unbind current driver */
- if (pci_unbind_kernel_driver(dev) < 0)
- return -1;
- }
-
- /* reference driver structure */
- dev->driver = dr;
-
- /* call the driver devinit() function */
- return dr->devinit(dr, dev);
- }
- /* return positive value if driver is not found */
- return 1;
-}
-
#ifdef RTE_LIBRTE_EAL_HOTPLUG
/*
* If vendor/device ID match, call the devuninit() function of the
--
1.9.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
` (4 preceding siblings ...)
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 6/6] Move common functions in eal_pci.c Ravi Kerur
@ 2015-04-21 14:25 ` Bruce Richardson
2015-04-21 19:28 ` Ravi Kerur
5 siblings, 1 reply; 15+ messages in thread
From: Bruce Richardson @ 2015-04-21 14:25 UTC (permalink / raw)
To: Ravi Kerur; +Cc: dev
On Sat, Apr 18, 2015 at 12:43:06PM -0700, Ravi Kerur wrote:
> Changes in v6
> Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file.
> Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD
> respectively. Plan to use _getname_ in RTE_LOG when available.
> Use existing rte_get_systid() in RTE_LOG to print thread_id.
Hi Ravi
I think the change to add names to the threads might be better in an existing
patch as it is separate from the change of making the code common.
[The code changes for the names also seems to have issues with it, as
described in comments below]
>
> Changes in v5
> Rebase to latest code.
>
> Changes in v4
> None
>
> Changes in v3
> Changed subject to be more explicit on file name inclusion.
>
> Changes in v2
> None
>
> Changes in v1
> eal_thread.c has minor differences between Linux and BSD, move
> entire file into common directory.
> Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences.
> Rename eal_thread.c to eal_common_thread.c
> Makefile changes to reflect file move and name change.
> Fix checkpatch warnings.
>
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> ---
> examples/vhost/main.c | 18 ++-
> examples/vhost_xen/main.c | 18 ++-
> lib/librte_eal/bsdapp/eal/Makefile | 2 +-
> lib/librte_eal/bsdapp/eal/eal.c | 7 +
> lib/librte_eal/bsdapp/eal/eal_thread.c | 152 ---------------------
> lib/librte_eal/common/eal_common_thread.c | 147 +++++++++++++++++++-
> lib/librte_eal/common/eal_thread.h | 5 +
> lib/librte_eal/linuxapp/eal/Makefile | 2 +
> lib/librte_eal/linuxapp/eal/eal.c | 10 ++
> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 ++
> lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 22 ++-
> lib/librte_eal/linuxapp/eal/eal_thread.c | 152 +--------------------
> lib/librte_eal/linuxapp/eal/eal_timer.c | 15 +-
> 13 files changed, 250 insertions(+), 311 deletions(-)
>
<<<snip>>>
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> @@ -34,6 +34,7 @@
> #include <string.h>
> #include <fcntl.h>
> #include <sys/socket.h>
> +#include <pthread.h>
>
> /* sys/un.h with __USE_MISC uses strlen, which is unsafe */
> #ifdef __USE_MISC
> @@ -54,6 +55,7 @@
>
> #include "eal_filesystem.h"
> #include "eal_pci_init.h"
> +#include "eal_thread.h"
>
> /**
> * @file
> @@ -374,20 +376,36 @@ int
> pci_vfio_mp_sync_setup(void)
> {
> int ret;
> + char thread_name[RTE_THREAD_NAME_LEN];
>
> if (vfio_mp_sync_socket_setup() < 0) {
> RTE_LOG(ERR, EAL, "Failed to set up local socket!\n");
> return -1;
> }
>
> + snprintf(thread_name, RTE_THREAD_NAME_LEN,
> + "pci-vfio-mp-sync");
This string is too long. According to the man page (Fedora Linux):
"The thread name is a meaningful C language string, whose length is restricted to 16 charac‐
ters, including the terminating null byte ('\0')."
I make the string 16+ null, i.e. 17 in total.
> +
> ret = pthread_create(&socket_thread, NULL,
> pci_vfio_mp_sync_thread, NULL);
> if (ret) {
> - RTE_LOG(ERR, EAL, "Failed to create thread for communication with "
> - "secondary processes!\n");
> + RTE_LOG(ERR, EAL,
> + "Failed to create thread for communication with "
> + "secondary processes!\n");
Should not split the error message string across multiple lines as it breaks
git grep searches for the error message.
> + close(mp_socket_fd);
> + return -1;
> + }
> +
> + ret = pthread_setname_np(socket_thread, thread_name);
> +
> + if (ret) {
> + RTE_LOG(ERR, EAL,
> + "Failed to set thread name for "
> + "secondary processes!\n");
> close(mp_socket_fd);
> return -1;
Do we really want to return with an error here. Right now I can't run any apps
since I get an error on init of PCI - due to the name string being too long for
Linux. (Things seem fine on BSD). Failing to name a thread doesn't seem to be
a fatal error IMHO.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c Ravi Kerur
@ 2015-04-21 14:36 ` Bruce Richardson
2015-04-21 19:13 ` Ravi Kerur
0 siblings, 1 reply; 15+ messages in thread
From: Bruce Richardson @ 2015-04-21 14:36 UTC (permalink / raw)
To: Ravi Kerur; +Cc: dev
On Sat, Apr 18, 2015 at 12:43:07PM -0700, Ravi Kerur wrote:
> Changes in v6
> Split eal_common_system.c and eal_common_runtime.c into
> eal_common_sysfs.c
> eal_common_mem_cfg.c
> eal_common_proc_type.c
> eal_comm_app_usage.c
> based on functionality.
>
> Changes in v5
> Rebase to latest code.
>
> Changes in v4
> Remove eal_externs.h file, instead use _get_ and _set_ APIS
> to access those variables.
> Split eal_common.c into eal_common_system.c and
> and eal_common_runtime.c
> rte_eal prefix functions are moved to _runtime_ and
> eal prefix functions are moved to _system_ files respectively.
>
> Changes in v3
> Changed subject to be more explicit on file name inclusion.
>
> Changes in v2
> In function rte_eal_config_create remove #ifdef _BSDAPP_
> and initialize mem_cfg_addr unconditionally.
>
> Changes in v1
> Move common functions in eal.c to librte_eal/common/eal_common.c.
>
> Following functions are moved to eal_common.c file.
>
> struct rte_config *rte_eal_get_configuration(void);
> int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> static void rte_eal_config_create(void);
> enum rte_proc_type_t eal_proc_type_detect(void);
> void rte_eal_config_init(void);
> rte_usage_hook_t rte_set_application_usage_hook(rte_usage_hook_t
> usage_func);
> inline size_t eal_get_hugepage_mem_size(void);
> void eal_check_mem_on_local_socket(void);
> int sync_func(__attribute__((unused)) void *arg);
> inline void rte_eal_mcfg_complete(void);
> int rte_eal_has_hugepages(void);
> enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);
> enum rte_proc_type_t rte_eal_process_type(void);
>
> Makefile changes to reflect new files added.
> Fix checkpatch warnings and errors.
>
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> ---
> lib/librte_eal/bsdapp/eal/Makefile | 4 +
> lib/librte_eal/bsdapp/eal/eal.c | 271 +++---------------------
> lib/librte_eal/common/eal_common_app_usage.c | 63 ++++++
> lib/librte_eal/common/eal_common_mem_cfg.c | 217 ++++++++++++++++++++
> lib/librte_eal/common/eal_common_proc_type.c | 58 ++++++
> lib/librte_eal/common/eal_common_sysfs.c | 163 +++++++++++++++
> lib/librte_eal/common/eal_hugepages.h | 1 +
> lib/librte_eal/common/eal_private.h | 78 +++++++
> lib/librte_eal/common/include/rte_eal.h | 4 +
> lib/librte_eal/linuxapp/eal/Makefile | 4 +
> lib/librte_eal/linuxapp/eal/eal.c | 296 ++++-----------------------
> 11 files changed, 668 insertions(+), 491 deletions(-)
> create mode 100644 lib/librte_eal/common/eal_common_app_usage.c
> create mode 100644 lib/librte_eal/common/eal_common_mem_cfg.c
> create mode 100644 lib/librte_eal/common/eal_common_proc_type.c
> create mode 100644 lib/librte_eal/common/eal_common_sysfs.c
>
On applying this patch in the series I'm getting compiler errors. With clang on
linux (and BSD), I get errors about undefined inline functions e.g.:
In file included from /home/bruce/dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:84:
/home/bruce/dpdk.org/lib/librte_eal/common/eal_hugepages.h:66:15: error: inline function 'eal_get_hugepage_mem_size' is not defined [-Werror,-Wundefined-inline]
inline size_t eal_get_hugepage_mem_size(void);
^
/home/bruce/dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:549:29: note: used here
internal_config.memory = eal_get_hugepage_mem_size();
ICC is also giving a (different error):
CC eal_common_sysfs.o
/home/bruce/dpdk.org/lib/librte_eal/common/eal_common_sysfs.c(159): error #188: enumerated type mixed with another type
return -1;
Regards,
/Bruce
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c
2015-04-21 14:36 ` Bruce Richardson
@ 2015-04-21 19:13 ` Ravi Kerur
2015-04-22 9:21 ` Bruce Richardson
0 siblings, 1 reply; 15+ messages in thread
From: Ravi Kerur @ 2015-04-21 19:13 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Tue, Apr 21, 2015 at 7:36 AM, Bruce Richardson <
bruce.richardson@intel.com> wrote:
> On Sat, Apr 18, 2015 at 12:43:07PM -0700, Ravi Kerur wrote:
> > Changes in v6
> > Split eal_common_system.c and eal_common_runtime.c into
> > eal_common_sysfs.c
> > eal_common_mem_cfg.c
> > eal_common_proc_type.c
> > eal_comm_app_usage.c
> > based on functionality.
> >
> > Changes in v5
> > Rebase to latest code.
> >
> > Changes in v4
> > Remove eal_externs.h file, instead use _get_ and _set_ APIS
> > to access those variables.
> > Split eal_common.c into eal_common_system.c and
> > and eal_common_runtime.c
> > rte_eal prefix functions are moved to _runtime_ and
> > eal prefix functions are moved to _system_ files respectively.
> >
> > Changes in v3
> > Changed subject to be more explicit on file name inclusion.
> >
> > Changes in v2
> > In function rte_eal_config_create remove #ifdef _BSDAPP_
> > and initialize mem_cfg_addr unconditionally.
> >
> > Changes in v1
> > Move common functions in eal.c to librte_eal/common/eal_common.c.
> >
> > Following functions are moved to eal_common.c file.
> >
> > struct rte_config *rte_eal_get_configuration(void);
> > int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> > static void rte_eal_config_create(void);
> > enum rte_proc_type_t eal_proc_type_detect(void);
> > void rte_eal_config_init(void);
> > rte_usage_hook_t rte_set_application_usage_hook(rte_usage_hook_t
> > usage_func);
> > inline size_t eal_get_hugepage_mem_size(void);
> > void eal_check_mem_on_local_socket(void);
> > int sync_func(__attribute__((unused)) void *arg);
> > inline void rte_eal_mcfg_complete(void);
> > int rte_eal_has_hugepages(void);
> > enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);
> > enum rte_proc_type_t rte_eal_process_type(void);
> >
> > Makefile changes to reflect new files added.
> > Fix checkpatch warnings and errors.
> >
> > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > ---
> > lib/librte_eal/bsdapp/eal/Makefile | 4 +
> > lib/librte_eal/bsdapp/eal/eal.c | 271
> +++---------------------
> > lib/librte_eal/common/eal_common_app_usage.c | 63 ++++++
> > lib/librte_eal/common/eal_common_mem_cfg.c | 217 ++++++++++++++++++++
> > lib/librte_eal/common/eal_common_proc_type.c | 58 ++++++
> > lib/librte_eal/common/eal_common_sysfs.c | 163 +++++++++++++++
> > lib/librte_eal/common/eal_hugepages.h | 1 +
> > lib/librte_eal/common/eal_private.h | 78 +++++++
> > lib/librte_eal/common/include/rte_eal.h | 4 +
> > lib/librte_eal/linuxapp/eal/Makefile | 4 +
> > lib/librte_eal/linuxapp/eal/eal.c | 296
> ++++-----------------------
> > 11 files changed, 668 insertions(+), 491 deletions(-)
> > create mode 100644 lib/librte_eal/common/eal_common_app_usage.c
> > create mode 100644 lib/librte_eal/common/eal_common_mem_cfg.c
> > create mode 100644 lib/librte_eal/common/eal_common_proc_type.c
> > create mode 100644 lib/librte_eal/common/eal_common_sysfs.c
> >
> On applying this patch in the series I'm getting compiler errors. With
> clang on
> linux (and BSD), I get errors about undefined inline functions e.g.:
>
> In file included from /home/bruce/
> dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:84:
> /home/bruce/dpdk.org/lib/librte_eal/common/eal_hugepages.h:66:15: error:
> inline function 'eal_get_hugepage_mem_size' is not defined
> [-Werror,-Wundefined-inline]
> inline size_t eal_get_hugepage_mem_size(void);
> ^
> /home/bruce/dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:549:29:
> note: used here
> internal_config.memory =
> eal_get_hugepage_mem_size();
>
> ICC is also giving a (different error):
>
> CC eal_common_sysfs.o
> /home/bruce/dpdk.org/lib/librte_eal/common/eal_common_sysfs.c(159):
> error #188: enumerated type mixed with another type
> return -1;
>
>
Thanks Bruce for reporting these errors. My plan was to wait for final "OK"
from Thomas for v6 patches esp. on changes for split in eal.c and eal_pci.c
files. Currently my testing includes
1. Compiling with gcc 4.8.2 on Ubuntu and freeBSD
2. "make test" and testpmd on Linux
3. Basic testpmd on freeBSD
I will definitely fix these before sending out next version.
Regarding installation of "ICC" compiler, I had tried following Intel
reference
https://software.intel.com/en-us/articles/intel-compilers-linux-installation-help
At least my understanding was it required License from Intel. Please let me
know for any alternate way of getting ICC.
Thanks,
Ravi
> Regards,
> /Bruce
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c
2015-04-21 14:25 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Bruce Richardson
@ 2015-04-21 19:28 ` Ravi Kerur
2015-04-22 9:03 ` Bruce Richardson
0 siblings, 1 reply; 15+ messages in thread
From: Ravi Kerur @ 2015-04-21 19:28 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Tue, Apr 21, 2015 at 7:25 AM, Bruce Richardson <
bruce.richardson@intel.com> wrote:
> On Sat, Apr 18, 2015 at 12:43:06PM -0700, Ravi Kerur wrote:
> > Changes in v6
> > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file.
> > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD
> > respectively. Plan to use _getname_ in RTE_LOG when available.
> > Use existing rte_get_systid() in RTE_LOG to print thread_id.
>
> Hi Ravi
>
> I think the change to add names to the threads might be better in an
> existing
> patch as it is separate from the change of making the code common.
> [The code changes for the names also seems to have issues with it, as
> described in comments below]
>
Hi Bruce,
Thanks for your comments. Linux/FreeBSD has different APIs
pthread_setname_np and pthread_getname_np in Linux
pthread_set_name_np in FreeBSD. FreeBSD has no "_get_name_" counterpart API.
API signatures are different as well. Current plan is to use
"_setname_"/"_set_name_" appropriately and leave out "_getname_" until it
is available in FreeBSD.
Are you suggesting to use separate patch for set/get pthread names?
More inline.
> >
> > Changes in v5
> > Rebase to latest code.
> >
> > Changes in v4
> > None
> >
> > Changes in v3
> > Changed subject to be more explicit on file name inclusion.
> >
> > Changes in v2
> > None
> >
> > Changes in v1
> > eal_thread.c has minor differences between Linux and BSD, move
> > entire file into common directory.
> > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences.
> > Rename eal_thread.c to eal_common_thread.c
> > Makefile changes to reflect file move and name change.
> > Fix checkpatch warnings.
> >
> > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > ---
> > examples/vhost/main.c | 18 ++-
> > examples/vhost_xen/main.c | 18 ++-
> > lib/librte_eal/bsdapp/eal/Makefile | 2 +-
> > lib/librte_eal/bsdapp/eal/eal.c | 7 +
> > lib/librte_eal/bsdapp/eal/eal_thread.c | 152
> ---------------------
> > lib/librte_eal/common/eal_common_thread.c | 147
> +++++++++++++++++++-
> > lib/librte_eal/common/eal_thread.h | 5 +
> > lib/librte_eal/linuxapp/eal/Makefile | 2 +
> > lib/librte_eal/linuxapp/eal/eal.c | 10 ++
> > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 ++
> > lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 22 ++-
> > lib/librte_eal/linuxapp/eal/eal_thread.c | 152
> +--------------------
> > lib/librte_eal/linuxapp/eal/eal_timer.c | 15 +-
> > 13 files changed, 250 insertions(+), 311 deletions(-)
> >
>
> <<<snip>>>
>
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> > @@ -34,6 +34,7 @@
> > #include <string.h>
> > #include <fcntl.h>
> > #include <sys/socket.h>
> > +#include <pthread.h>
> >
> > /* sys/un.h with __USE_MISC uses strlen, which is unsafe */
> > #ifdef __USE_MISC
> > @@ -54,6 +55,7 @@
> >
> > #include "eal_filesystem.h"
> > #include "eal_pci_init.h"
> > +#include "eal_thread.h"
> >
> > /**
> > * @file
> > @@ -374,20 +376,36 @@ int
> > pci_vfio_mp_sync_setup(void)
> > {
> > int ret;
> > + char thread_name[RTE_THREAD_NAME_LEN];
> >
> > if (vfio_mp_sync_socket_setup() < 0) {
> > RTE_LOG(ERR, EAL, "Failed to set up local socket!\n");
> > return -1;
> > }
> >
> > + snprintf(thread_name, RTE_THREAD_NAME_LEN,
> > + "pci-vfio-mp-sync");
>
> This string is too long. According to the man page (Fedora Linux):
> "The thread name is a meaningful C language string, whose length is
> restricted to 16 charac‐
> ters, including the terminating null byte ('\0')."
> I make the string 16+ null, i.e. 17 in total.
>
My mistake, will fix it.
>
> > +
> > ret = pthread_create(&socket_thread, NULL,
> > pci_vfio_mp_sync_thread, NULL);
> > if (ret) {
> > - RTE_LOG(ERR, EAL, "Failed to create thread for
> communication with "
> > - "secondary processes!\n");
> > + RTE_LOG(ERR, EAL,
> > + "Failed to create thread for communication with "
> > + "secondary processes!\n");
>
> Should not split the error message string across multiple lines as it
> breaks
> git grep searches for the error message.
>
Will fix it.
>
> > + close(mp_socket_fd);
> > + return -1;
> > + }
> > +
> > + ret = pthread_setname_np(socket_thread, thread_name);
> > +
> > + if (ret) {
> > + RTE_LOG(ERR, EAL,
> > + "Failed to set thread name for "
> > + "secondary processes!\n");
> > close(mp_socket_fd);
> > return -1;
>
> Do we really want to return with an error here. Right now I can't run any
> apps
> since I get an error on init of PCI - due to the name string being too
> long for
> Linux. (Things seem fine on BSD). Failing to name a thread doesn't seem to
> be
> a fatal error IMHO.
>
>
When I coded understanding was that pthread _set_ APIs should not fail
(excluding bugs whilst calling the API), since _get_ APIs will be called
subsequently for logging and debugging it will not be of any help if I let
program continue after _set_ failure. I will change the code to just log an
error and return success.
Thanks,
Ravi
> Regards,
> /Bruce
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c
2015-04-21 19:28 ` Ravi Kerur
@ 2015-04-22 9:03 ` Bruce Richardson
2015-04-22 15:39 ` Ravi Kerur
0 siblings, 1 reply; 15+ messages in thread
From: Bruce Richardson @ 2015-04-22 9:03 UTC (permalink / raw)
To: Ravi Kerur; +Cc: dev
On Tue, Apr 21, 2015 at 12:28:24PM -0700, Ravi Kerur wrote:
> On Tue, Apr 21, 2015 at 7:25 AM, Bruce Richardson <
> bruce.richardson@intel.com> wrote:
>
> > On Sat, Apr 18, 2015 at 12:43:06PM -0700, Ravi Kerur wrote:
> > > Changes in v6
> > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file.
> > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD
> > > respectively. Plan to use _getname_ in RTE_LOG when available.
> > > Use existing rte_get_systid() in RTE_LOG to print thread_id.
> >
> > Hi Ravi
> >
> > I think the change to add names to the threads might be better in an
> > existing
> > patch as it is separate from the change of making the code common.
> > [The code changes for the names also seems to have issues with it, as
> > described in comments below]
> >
>
> Hi Bruce,
>
> Thanks for your comments. Linux/FreeBSD has different APIs
>
> pthread_setname_np and pthread_getname_np in Linux
> pthread_set_name_np in FreeBSD. FreeBSD has no "_get_name_" counterpart API.
>
> API signatures are different as well. Current plan is to use
> "_setname_"/"_set_name_" appropriately and leave out "_getname_" until it
> is available in FreeBSD.
>
> Are you suggesting to use separate patch for set/get pthread names?
Yes, I think that would be better. Have one patch just for moving the code
to a common location, then a second patch for adding in thread names since its
really a discrete unit of work. Apart from the bug with Linux vfio thread, the
idea and implementation looks really good, and something we would like to have.
/Bruce
>
> More inline.
>
>
> > >
> > > Changes in v5
> > > Rebase to latest code.
> > >
> > > Changes in v4
> > > None
> > >
> > > Changes in v3
> > > Changed subject to be more explicit on file name inclusion.
> > >
> > > Changes in v2
> > > None
> > >
> > > Changes in v1
> > > eal_thread.c has minor differences between Linux and BSD, move
> > > entire file into common directory.
> > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences.
> > > Rename eal_thread.c to eal_common_thread.c
> > > Makefile changes to reflect file move and name change.
> > > Fix checkpatch warnings.
> > >
> > > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > > ---
> > > examples/vhost/main.c | 18 ++-
> > > examples/vhost_xen/main.c | 18 ++-
> > > lib/librte_eal/bsdapp/eal/Makefile | 2 +-
> > > lib/librte_eal/bsdapp/eal/eal.c | 7 +
> > > lib/librte_eal/bsdapp/eal/eal_thread.c | 152
> > ---------------------
> > > lib/librte_eal/common/eal_common_thread.c | 147
> > +++++++++++++++++++-
> > > lib/librte_eal/common/eal_thread.h | 5 +
> > > lib/librte_eal/linuxapp/eal/Makefile | 2 +
> > > lib/librte_eal/linuxapp/eal/eal.c | 10 ++
> > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 ++
> > > lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 22 ++-
> > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152
> > +--------------------
> > > lib/librte_eal/linuxapp/eal/eal_timer.c | 15 +-
> > > 13 files changed, 250 insertions(+), 311 deletions(-)
> > >
> >
> > <<<snip>>>
> >
> > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> > > @@ -34,6 +34,7 @@
> > > #include <string.h>
> > > #include <fcntl.h>
> > > #include <sys/socket.h>
> > > +#include <pthread.h>
> > >
> > > /* sys/un.h with __USE_MISC uses strlen, which is unsafe */
> > > #ifdef __USE_MISC
> > > @@ -54,6 +55,7 @@
> > >
> > > #include "eal_filesystem.h"
> > > #include "eal_pci_init.h"
> > > +#include "eal_thread.h"
> > >
> > > /**
> > > * @file
> > > @@ -374,20 +376,36 @@ int
> > > pci_vfio_mp_sync_setup(void)
> > > {
> > > int ret;
> > > + char thread_name[RTE_THREAD_NAME_LEN];
> > >
> > > if (vfio_mp_sync_socket_setup() < 0) {
> > > RTE_LOG(ERR, EAL, "Failed to set up local socket!\n");
> > > return -1;
> > > }
> > >
> > > + snprintf(thread_name, RTE_THREAD_NAME_LEN,
> > > + "pci-vfio-mp-sync");
> >
> > This string is too long. According to the man page (Fedora Linux):
> > "The thread name is a meaningful C language string, whose length is
> > restricted to 16 charac‐
> > ters, including the terminating null byte ('\0')."
> > I make the string 16+ null, i.e. 17 in total.
> >
>
> My mistake, will fix it.
>
> >
> > > +
> > > ret = pthread_create(&socket_thread, NULL,
> > > pci_vfio_mp_sync_thread, NULL);
> > > if (ret) {
> > > - RTE_LOG(ERR, EAL, "Failed to create thread for
> > communication with "
> > > - "secondary processes!\n");
> > > + RTE_LOG(ERR, EAL,
> > > + "Failed to create thread for communication with "
> > > + "secondary processes!\n");
> >
> > Should not split the error message string across multiple lines as it
> > breaks
> > git grep searches for the error message.
> >
>
> Will fix it.
>
> >
> > > + close(mp_socket_fd);
> > > + return -1;
> > > + }
> > > +
> > > + ret = pthread_setname_np(socket_thread, thread_name);
> > > +
> > > + if (ret) {
> > > + RTE_LOG(ERR, EAL,
> > > + "Failed to set thread name for "
> > > + "secondary processes!\n");
> > > close(mp_socket_fd);
> > > return -1;
> >
> > Do we really want to return with an error here. Right now I can't run any
> > apps
> > since I get an error on init of PCI - due to the name string being too
> > long for
> > Linux. (Things seem fine on BSD). Failing to name a thread doesn't seem to
> > be
> > a fatal error IMHO.
> >
> >
> When I coded understanding was that pthread _set_ APIs should not fail
> (excluding bugs whilst calling the API), since _get_ APIs will be called
> subsequently for logging and debugging it will not be of any help if I let
> program continue after _set_ failure. I will change the code to just log an
> error and return success.
>
> Thanks,
> Ravi
>
>
> > Regards,
> > /Bruce
> >
> >
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c
2015-04-21 19:13 ` Ravi Kerur
@ 2015-04-22 9:21 ` Bruce Richardson
2015-04-22 15:37 ` Ravi Kerur
0 siblings, 1 reply; 15+ messages in thread
From: Bruce Richardson @ 2015-04-22 9:21 UTC (permalink / raw)
To: Ravi Kerur; +Cc: dev
On Tue, Apr 21, 2015 at 12:13:22PM -0700, Ravi Kerur wrote:
> On Tue, Apr 21, 2015 at 7:36 AM, Bruce Richardson <
> bruce.richardson@intel.com> wrote:
>
> > On Sat, Apr 18, 2015 at 12:43:07PM -0700, Ravi Kerur wrote:
> > > Changes in v6
> > > Split eal_common_system.c and eal_common_runtime.c into
> > > eal_common_sysfs.c
> > > eal_common_mem_cfg.c
> > > eal_common_proc_type.c
> > > eal_comm_app_usage.c
> > > based on functionality.
> > >
> > > Changes in v5
> > > Rebase to latest code.
> > >
> > > Changes in v4
> > > Remove eal_externs.h file, instead use _get_ and _set_ APIS
> > > to access those variables.
> > > Split eal_common.c into eal_common_system.c and
> > > and eal_common_runtime.c
> > > rte_eal prefix functions are moved to _runtime_ and
> > > eal prefix functions are moved to _system_ files respectively.
> > >
> > > Changes in v3
> > > Changed subject to be more explicit on file name inclusion.
> > >
> > > Changes in v2
> > > In function rte_eal_config_create remove #ifdef _BSDAPP_
> > > and initialize mem_cfg_addr unconditionally.
> > >
> > > Changes in v1
> > > Move common functions in eal.c to librte_eal/common/eal_common.c.
> > >
> > > Following functions are moved to eal_common.c file.
> > >
> > > struct rte_config *rte_eal_get_configuration(void);
> > > int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> > > static void rte_eal_config_create(void);
> > > enum rte_proc_type_t eal_proc_type_detect(void);
> > > void rte_eal_config_init(void);
> > > rte_usage_hook_t rte_set_application_usage_hook(rte_usage_hook_t
> > > usage_func);
> > > inline size_t eal_get_hugepage_mem_size(void);
> > > void eal_check_mem_on_local_socket(void);
> > > int sync_func(__attribute__((unused)) void *arg);
> > > inline void rte_eal_mcfg_complete(void);
> > > int rte_eal_has_hugepages(void);
> > > enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);
> > > enum rte_proc_type_t rte_eal_process_type(void);
> > >
> > > Makefile changes to reflect new files added.
> > > Fix checkpatch warnings and errors.
> > >
> > > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > > ---
> > > lib/librte_eal/bsdapp/eal/Makefile | 4 +
> > > lib/librte_eal/bsdapp/eal/eal.c | 271
> > +++---------------------
> > > lib/librte_eal/common/eal_common_app_usage.c | 63 ++++++
> > > lib/librte_eal/common/eal_common_mem_cfg.c | 217 ++++++++++++++++++++
> > > lib/librte_eal/common/eal_common_proc_type.c | 58 ++++++
> > > lib/librte_eal/common/eal_common_sysfs.c | 163 +++++++++++++++
> > > lib/librte_eal/common/eal_hugepages.h | 1 +
> > > lib/librte_eal/common/eal_private.h | 78 +++++++
> > > lib/librte_eal/common/include/rte_eal.h | 4 +
> > > lib/librte_eal/linuxapp/eal/Makefile | 4 +
> > > lib/librte_eal/linuxapp/eal/eal.c | 296
> > ++++-----------------------
> > > 11 files changed, 668 insertions(+), 491 deletions(-)
> > > create mode 100644 lib/librte_eal/common/eal_common_app_usage.c
> > > create mode 100644 lib/librte_eal/common/eal_common_mem_cfg.c
> > > create mode 100644 lib/librte_eal/common/eal_common_proc_type.c
> > > create mode 100644 lib/librte_eal/common/eal_common_sysfs.c
> > >
> > On applying this patch in the series I'm getting compiler errors. With
> > clang on
> > linux (and BSD), I get errors about undefined inline functions e.g.:
> >
> > In file included from /home/bruce/
> > dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:84:
> > /home/bruce/dpdk.org/lib/librte_eal/common/eal_hugepages.h:66:15: error:
> > inline function 'eal_get_hugepage_mem_size' is not defined
> > [-Werror,-Wundefined-inline]
> > inline size_t eal_get_hugepage_mem_size(void);
> > ^
> > /home/bruce/dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:549:29:
> > note: used here
> > internal_config.memory =
> > eal_get_hugepage_mem_size();
> >
> > ICC is also giving a (different error):
> >
> > CC eal_common_sysfs.o
> > /home/bruce/dpdk.org/lib/librte_eal/common/eal_common_sysfs.c(159):
> > error #188: enumerated type mixed with another type
> > return -1;
> >
> >
> Thanks Bruce for reporting these errors. My plan was to wait for final "OK"
> from Thomas for v6 patches esp. on changes for split in eal.c and eal_pci.c
> files. Currently my testing includes
>
> 1. Compiling with gcc 4.8.2 on Ubuntu and freeBSD
> 2. "make test" and testpmd on Linux
> 3. Basic testpmd on freeBSD
>
> I will definitely fix these before sending out next version.
>
> Regarding installation of "ICC" compiler, I had tried following Intel
> reference
>
> https://software.intel.com/en-us/articles/intel-compilers-linux-installation-help
>
> At least my understanding was it required License from Intel. Please let me
> know for any alternate way of getting ICC.
>
> Thanks,
> Ravi
>
>
I'm just flagging the ICC error as an FYI, given that you are fixing other
compiler errors anyway. Since ICC is an Intel product and we
don't expect all contributors to have it, we in Intel will take responsibility
for submitting patches to ensure ICC compiles the DPDK code ok.
/Bruce
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c
2015-04-22 9:21 ` Bruce Richardson
@ 2015-04-22 15:37 ` Ravi Kerur
0 siblings, 0 replies; 15+ messages in thread
From: Ravi Kerur @ 2015-04-22 15:37 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Wed, Apr 22, 2015 at 2:21 AM, Bruce Richardson <
bruce.richardson@intel.com> wrote:
> On Tue, Apr 21, 2015 at 12:13:22PM -0700, Ravi Kerur wrote:
> > On Tue, Apr 21, 2015 at 7:36 AM, Bruce Richardson <
> > bruce.richardson@intel.com> wrote:
> >
> > > On Sat, Apr 18, 2015 at 12:43:07PM -0700, Ravi Kerur wrote:
> > > > Changes in v6
> > > > Split eal_common_system.c and eal_common_runtime.c into
> > > > eal_common_sysfs.c
> > > > eal_common_mem_cfg.c
> > > > eal_common_proc_type.c
> > > > eal_comm_app_usage.c
> > > > based on functionality.
> > > >
> > > > Changes in v5
> > > > Rebase to latest code.
> > > >
> > > > Changes in v4
> > > > Remove eal_externs.h file, instead use _get_ and _set_ APIS
> > > > to access those variables.
> > > > Split eal_common.c into eal_common_system.c and
> > > > and eal_common_runtime.c
> > > > rte_eal prefix functions are moved to _runtime_ and
> > > > eal prefix functions are moved to _system_ files respectively.
> > > >
> > > > Changes in v3
> > > > Changed subject to be more explicit on file name inclusion.
> > > >
> > > > Changes in v2
> > > > In function rte_eal_config_create remove #ifdef _BSDAPP_
> > > > and initialize mem_cfg_addr unconditionally.
> > > >
> > > > Changes in v1
> > > > Move common functions in eal.c to librte_eal/common/eal_common.c.
> > > >
> > > > Following functions are moved to eal_common.c file.
> > > >
> > > > struct rte_config *rte_eal_get_configuration(void);
> > > > int eal_parse_sysfs_value(const char *filename, unsigned long *val);
> > > > static void rte_eal_config_create(void);
> > > > enum rte_proc_type_t eal_proc_type_detect(void);
> > > > void rte_eal_config_init(void);
> > > > rte_usage_hook_t rte_set_application_usage_hook(rte_usage_hook_t
> > > > usage_func);
> > > > inline size_t eal_get_hugepage_mem_size(void);
> > > > void eal_check_mem_on_local_socket(void);
> > > > int sync_func(__attribute__((unused)) void *arg);
> > > > inline void rte_eal_mcfg_complete(void);
> > > > int rte_eal_has_hugepages(void);
> > > > enum rte_lcore_role_t rte_eal_lcore_role(unsigned lcore_id);
> > > > enum rte_proc_type_t rte_eal_process_type(void);
> > > >
> > > > Makefile changes to reflect new files added.
> > > > Fix checkpatch warnings and errors.
> > > >
> > > > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > > > ---
> > > > lib/librte_eal/bsdapp/eal/Makefile | 4 +
> > > > lib/librte_eal/bsdapp/eal/eal.c | 271
> > > +++---------------------
> > > > lib/librte_eal/common/eal_common_app_usage.c | 63 ++++++
> > > > lib/librte_eal/common/eal_common_mem_cfg.c | 217
> ++++++++++++++++++++
> > > > lib/librte_eal/common/eal_common_proc_type.c | 58 ++++++
> > > > lib/librte_eal/common/eal_common_sysfs.c | 163 +++++++++++++++
> > > > lib/librte_eal/common/eal_hugepages.h | 1 +
> > > > lib/librte_eal/common/eal_private.h | 78 +++++++
> > > > lib/librte_eal/common/include/rte_eal.h | 4 +
> > > > lib/librte_eal/linuxapp/eal/Makefile | 4 +
> > > > lib/librte_eal/linuxapp/eal/eal.c | 296
> > > ++++-----------------------
> > > > 11 files changed, 668 insertions(+), 491 deletions(-)
> > > > create mode 100644 lib/librte_eal/common/eal_common_app_usage.c
> > > > create mode 100644 lib/librte_eal/common/eal_common_mem_cfg.c
> > > > create mode 100644 lib/librte_eal/common/eal_common_proc_type.c
> > > > create mode 100644 lib/librte_eal/common/eal_common_sysfs.c
> > > >
> > > On applying this patch in the series I'm getting compiler errors. With
> > > clang on
> > > linux (and BSD), I get errors about undefined inline functions e.g.:
> > >
> > > In file included from /home/bruce/
> > > dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:84:
> > > /home/bruce/dpdk.org/lib/librte_eal/common/eal_hugepages.h:66:15:
> error:
> > > inline function 'eal_get_hugepage_mem_size' is not defined
> > > [-Werror,-Wundefined-inline]
> > > inline size_t eal_get_hugepage_mem_size(void);
> > > ^
> > > /home/bruce/dpdk.org/lib/librte_eal/linuxapp/eal/eal.c:549:29:
> > > note: used here
> > > internal_config.memory =
> > > eal_get_hugepage_mem_size();
> > >
> > > ICC is also giving a (different error):
> > >
> > > CC eal_common_sysfs.o
> > > /home/bruce/dpdk.org/lib/librte_eal/common/eal_common_sysfs.c(159):
> > > error #188: enumerated type mixed with another type
> > > return -1;
> > >
> > >
> > Thanks Bruce for reporting these errors. My plan was to wait for final
> "OK"
> > from Thomas for v6 patches esp. on changes for split in eal.c and
> eal_pci.c
> > files. Currently my testing includes
> >
> > 1. Compiling with gcc 4.8.2 on Ubuntu and freeBSD
> > 2. "make test" and testpmd on Linux
> > 3. Basic testpmd on freeBSD
> >
> > I will definitely fix these before sending out next version.
> >
> > Regarding installation of "ICC" compiler, I had tried following Intel
> > reference
> >
> >
> https://software.intel.com/en-us/articles/intel-compilers-linux-installation-help
> >
> > At least my understanding was it required License from Intel. Please let
> me
> > know for any alternate way of getting ICC.
> >
> > Thanks,
> > Ravi
> >
> >
> I'm just flagging the ICC error as an FYI, given that you are fixing other
> compiler errors anyway. Since ICC is an Intel product and we
> don't expect all contributors to have it, we in Intel will take
> responsibility
> for submitting patches to ensure ICC compiles the DPDK code ok.
>
Thanks Bruce, I will make sure I fix reported ICC errors in v7.
>
> /Bruce
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c
2015-04-22 9:03 ` Bruce Richardson
@ 2015-04-22 15:39 ` Ravi Kerur
0 siblings, 0 replies; 15+ messages in thread
From: Ravi Kerur @ 2015-04-22 15:39 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Wed, Apr 22, 2015 at 2:03 AM, Bruce Richardson <
bruce.richardson@intel.com> wrote:
> On Tue, Apr 21, 2015 at 12:28:24PM -0700, Ravi Kerur wrote:
> > On Tue, Apr 21, 2015 at 7:25 AM, Bruce Richardson <
> > bruce.richardson@intel.com> wrote:
> >
> > > On Sat, Apr 18, 2015 at 12:43:06PM -0700, Ravi Kerur wrote:
> > > > Changes in v6
> > > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file.
> > > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD
> > > > respectively. Plan to use _getname_ in RTE_LOG when available.
> > > > Use existing rte_get_systid() in RTE_LOG to print thread_id.
> > >
> > > Hi Ravi
> > >
> > > I think the change to add names to the threads might be better in an
> > > existing
> > > patch as it is separate from the change of making the code common.
> > > [The code changes for the names also seems to have issues with it, as
> > > described in comments below]
> > >
> >
> > Hi Bruce,
> >
> > Thanks for your comments. Linux/FreeBSD has different APIs
> >
> > pthread_setname_np and pthread_getname_np in Linux
> > pthread_set_name_np in FreeBSD. FreeBSD has no "_get_name_" counterpart
> API.
> >
> > API signatures are different as well. Current plan is to use
> > "_setname_"/"_set_name_" appropriately and leave out "_getname_" until it
> > is available in FreeBSD.
> >
> > Are you suggesting to use separate patch for set/get pthread names?
>
> Yes, I think that would be better. Have one patch just for moving the code
> to a common location, then a second patch for adding in thread names since
> its
> really a discrete unit of work. Apart from the bug with Linux vfio thread,
> the
> idea and implementation looks really good, and something we would like to
> have.
>
Thanks Bruce. I will take care of removing it from EAL common patch series
and send out a separate patch for this.
>
> /Bruce
>
> >
> > More inline.
> >
> >
> > > >
> > > > Changes in v5
> > > > Rebase to latest code.
> > > >
> > > > Changes in v4
> > > > None
> > > >
> > > > Changes in v3
> > > > Changed subject to be more explicit on file name inclusion.
> > > >
> > > > Changes in v2
> > > > None
> > > >
> > > > Changes in v1
> > > > eal_thread.c has minor differences between Linux and BSD, move
> > > > entire file into common directory.
> > > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences.
> > > > Rename eal_thread.c to eal_common_thread.c
> > > > Makefile changes to reflect file move and name change.
> > > > Fix checkpatch warnings.
> > > >
> > > > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > > > ---
> > > > examples/vhost/main.c | 18 ++-
> > > > examples/vhost_xen/main.c | 18 ++-
> > > > lib/librte_eal/bsdapp/eal/Makefile | 2 +-
> > > > lib/librte_eal/bsdapp/eal/eal.c | 7 +
> > > > lib/librte_eal/bsdapp/eal/eal_thread.c | 152
> > > ---------------------
> > > > lib/librte_eal/common/eal_common_thread.c | 147
> > > +++++++++++++++++++-
> > > > lib/librte_eal/common/eal_thread.h | 5 +
> > > > lib/librte_eal/linuxapp/eal/Makefile | 2 +
> > > > lib/librte_eal/linuxapp/eal/eal.c | 10 ++
> > > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 ++
> > > > lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 22 ++-
> > > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152
> > > +--------------------
> > > > lib/librte_eal/linuxapp/eal/eal_timer.c | 15 +-
> > > > 13 files changed, 250 insertions(+), 311 deletions(-)
> > > >
> > >
> > > <<<snip>>>
> > >
> > > > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> > > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c
> > > > @@ -34,6 +34,7 @@
> > > > #include <string.h>
> > > > #include <fcntl.h>
> > > > #include <sys/socket.h>
> > > > +#include <pthread.h>
> > > >
> > > > /* sys/un.h with __USE_MISC uses strlen, which is unsafe */
> > > > #ifdef __USE_MISC
> > > > @@ -54,6 +55,7 @@
> > > >
> > > > #include "eal_filesystem.h"
> > > > #include "eal_pci_init.h"
> > > > +#include "eal_thread.h"
> > > >
> > > > /**
> > > > * @file
> > > > @@ -374,20 +376,36 @@ int
> > > > pci_vfio_mp_sync_setup(void)
> > > > {
> > > > int ret;
> > > > + char thread_name[RTE_THREAD_NAME_LEN];
> > > >
> > > > if (vfio_mp_sync_socket_setup() < 0) {
> > > > RTE_LOG(ERR, EAL, "Failed to set up local socket!\n");
> > > > return -1;
> > > > }
> > > >
> > > > + snprintf(thread_name, RTE_THREAD_NAME_LEN,
> > > > + "pci-vfio-mp-sync");
> > >
> > > This string is too long. According to the man page (Fedora Linux):
> > > "The thread name is a meaningful C language string, whose length is
> > > restricted to 16 charac‐
> > > ters, including the terminating null byte ('\0')."
> > > I make the string 16+ null, i.e. 17 in total.
> > >
> >
> > My mistake, will fix it.
> >
> > >
> > > > +
> > > > ret = pthread_create(&socket_thread, NULL,
> > > > pci_vfio_mp_sync_thread, NULL);
> > > > if (ret) {
> > > > - RTE_LOG(ERR, EAL, "Failed to create thread for
> > > communication with "
> > > > - "secondary processes!\n");
> > > > + RTE_LOG(ERR, EAL,
> > > > + "Failed to create thread for communication
> with "
> > > > + "secondary processes!\n");
> > >
> > > Should not split the error message string across multiple lines as it
> > > breaks
> > > git grep searches for the error message.
> > >
> >
> > Will fix it.
> >
> > >
> > > > + close(mp_socket_fd);
> > > > + return -1;
> > > > + }
> > > > +
> > > > + ret = pthread_setname_np(socket_thread, thread_name);
> > > > +
> > > > + if (ret) {
> > > > + RTE_LOG(ERR, EAL,
> > > > + "Failed to set thread name for "
> > > > + "secondary processes!\n");
> > > > close(mp_socket_fd);
> > > > return -1;
> > >
> > > Do we really want to return with an error here. Right now I can't run
> any
> > > apps
> > > since I get an error on init of PCI - due to the name string being too
> > > long for
> > > Linux. (Things seem fine on BSD). Failing to name a thread doesn't
> seem to
> > > be
> > > a fatal error IMHO.
> > >
> > >
> > When I coded understanding was that pthread _set_ APIs should not fail
> > (excluding bugs whilst calling the API), since _get_ APIs will be called
> > subsequently for logging and debugging it will not be of any help if I
> let
> > program continue after _set_ failure. I will change the code to just log
> an
> > error and return success.
> >
> > Thanks,
> > Ravi
> >
> >
> > > Regards,
> > > /Bruce
> > >
> > >
>
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-04-22 15:39 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-18 19:42 [dpdk-dev] [PATCH v6 0/6] Move common functions in EAL Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 2/6] Move common functions in eal.c Ravi Kerur
2015-04-21 14:36 ` Bruce Richardson
2015-04-21 19:13 ` Ravi Kerur
2015-04-22 9:21 ` Bruce Richardson
2015-04-22 15:37 ` Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 3/6] Move common functions in eal_lcore.c Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 4/6] Move common functions in eal_timer.c Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 5/6] Move common functions in eal_memory.c Ravi Kerur
2015-04-18 19:43 ` [dpdk-dev] [PATCH v6 6/6] Move common functions in eal_pci.c Ravi Kerur
2015-04-21 14:25 ` [dpdk-dev] [PATCH v6 1/6] Move common functions in eal_thread.c Bruce Richardson
2015-04-21 19:28 ` Ravi Kerur
2015-04-22 9:03 ` Bruce Richardson
2015-04-22 15:39 ` Ravi Kerur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).