From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EC399A0562;
	Tue,  2 Mar 2021 20:33:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 89C3440FDF;
	Tue,  2 Mar 2021 20:33:28 +0100 (CET)
Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com
 [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id 5E2E24014E
 for <dev@dpdk.org>; Tue,  2 Mar 2021 20:33:27 +0100 (CET)
Received: by mail-oo1-f52.google.com with SMTP id l5so5087299ooj.7
 for <dev@dpdk.org>; Tue, 02 Mar 2021 11:33:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=hYO6ezW0ZM95U53m8YHe1nQbod/xmUX5XSq/cSaYJe4=;
 b=cB1TOGkoEqU831FZTyEbLANhwcfr0DDGPPy6Q/GHua+bfYUY+7Cd6ez/1wPeALaVBm
 W1RZhw6FagkxDCoPUcLwvr4GseqSvTVjDfZ74C0Ml0Nkso1HBHDpnrEnN2S8up+o50E2
 30Cs4iC4PqzMxsdDy09MWQOutQcXuIIuNGlbnuOuLs9Q2OAuefxRGf/3NCxR796LcjK8
 M6o/kiC/Mt52GXouZQhtj8W1T0mWY56rjN+wBx/B8P0k17egMCtpG4wHvLYjyzAmtqFD
 M15fAlWqy/F+bq8ELMxQSQMRuwodkxVcGdtf70rj/6GHayh1jZAUHrmbMTTxGrexl0Hb
 wn0A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=hYO6ezW0ZM95U53m8YHe1nQbod/xmUX5XSq/cSaYJe4=;
 b=Yx9UnZL1Qx1H9qTw02IszATXMOHeMigL4kUh4QkcXsk0qPgvtwqoleT66o3Ei43eWn
 Uzzbd9wSO3mES669oHpU4pHTbdqaEhklf4o+/DNJOn8i9Hl30ZSJTry50Gg8zGUGP3lT
 1zPR5Po8B55RDYPOCb4M4BltXeKMG7cnZ8thqWNfaG6phJGQkMVsC04wM2hNGMtdc8SC
 Qq657FLCzFv1qGVd8W1OapOsM8aFtdr8rTw3tGoEKTv0hwnAwHKYOYpZxR6aEhkra3UG
 mX4dpBi0l4cXAzguTADl4cs7qtUQxt2cnC+3UVNsG5Th/fmP+K6wnHpJA9ZtrT67r/C0
 jMVw==
X-Gm-Message-State: AOAM5339jLo8zlrMBnK6/4CdlziSGoQR5pvmBrex5jpMDUXmcTxA2t0A
 TuPdubKwzeR5jdveq1HRyvCxC1VlgfYLhsq3BklQCZzWrKVhKA==
X-Google-Smtp-Source: ABdhPJy0BKafELAj/4qocwaBDZmbDH/69MTx+3+oPBmAaSchDhRIdcajtAwbaAMPJtYwpqcRzqA4+3q5mAf6pJY54R8=
X-Received: by 2002:a4a:c706:: with SMTP id n6mr18122239ooq.19.1614713606259; 
 Tue, 02 Mar 2021 11:33:26 -0800 (PST)
MIME-Version: 1.0
From: Ravi Kerur <rkerur@gmail.com>
Date: Tue, 2 Mar 2021 11:33:15 -0800
Message-ID: <CAFb4SLAes4Qj4g56OL9vfCEa6yxGPBgYy-fZeksrdSh_ucssgw@mail.gmail.com>
To: dpdk-dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: [dpdk-dev] Q on l3fwd-acl and acl library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello,

I am using l3fwd-acl example code and would like to know the intention of
ACL_DENY_SIGNATURE in the code.

Is ACL rules programmed to drop packets and not for any other
functionality? I see that userdata is ignored for ACL and programmed with
ACL_DENY_SIGNATURE + count. After classification, results are checked and
packets forwarded or dropped as in send_one_packet

static inline void
send_one_packet(struct rte_mbuf *m, uint32_t res)
{
        if (likely((res & ACL_DENY_SIGNATURE) == 0 && res != 0)) {
                /* forward packets */
                send_single_packet(m,
                        (uint8_t)(res - FWD_PORT_SHIFT));
...
}

In the ACL case, "res" is always (ACL_DENY_SIGNATURE + acl_cnt) and packets
are dropped.

Is this correct?

Looking at the acl library I did not see statistics associated with the
rules so the library doesn't provide anything related to statistics?

Finally, I see the acl library has api 'rte_acl_add_rules' but nothing on
modifying/deleting existing rules?

Thanks,
Ravi