From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com
 [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id EABCB593A
 for <dev@dpdk.org>; Mon,  5 Jan 2015 19:56:05 +0100 (CET)
Received: by mail-pd0-f173.google.com with SMTP id ft15so28644041pdb.18
 for <dev@dpdk.org>; Mon, 05 Jan 2015 10:56:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=ahnHzddoe3e5U7T1apuGNvYsoHNXS0AiphAkm08IzN0=;
 b=KFp+OQ9vA7BC+vqtGtHr+bO9YFntsr2JsauDkTMejy2zgj8Xy6qcM1C9JWp4BWe61M
 1U/dxgqI5wXwTa50EUlBQrEkEWyY3MrEw5Dp8ai8bLbnZL5wrLlUfAwnVHKoH6mmv5ky
 s7IufnOvaGfDmaZjLxgzUUmME3XMuzDnSgg+BqYoBjHH6dkPZ7XAvBR5azr7N3Lo6D+k
 JI2OLzIXbhXH1LA1HBkjYgb1lEvOmR2+fborCG7Zk1X3r/eHAw9AUlzKig08iCFn05BR
 BP5TIQAd9XhNaLxrbD+8hpQt2H2sD9+CU6APb4H9hcZ1GoLgeI/lHnFxhnAA/Pbl43uR
 oo/w==
MIME-Version: 1.0
X-Received: by 10.66.156.229 with SMTP id wh5mr149004133pab.119.1420484164852; 
 Mon, 05 Jan 2015 10:56:04 -0800 (PST)
Received: by 10.70.114.233 with HTTP; Mon, 5 Jan 2015 10:56:04 -0800 (PST)
In-Reply-To: <20293089.lIc3yRvdMZ@xps13>
References: <1419521597-31978-1-git-send-email-rkerur@gmail.com>
 <1419521597-31978-5-git-send-email-rkerur@gmail.com>
 <20293089.lIc3yRvdMZ@xps13>
Date: Mon, 5 Jan 2015 10:56:04 -0800
Message-ID: <CAFb4SLAr=_28qSe9ss7G2iS=fcKi00TmyGR1vQiSBWDek1A3Og@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/7] Move EAL common functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jan 2015 18:56:06 -0000

Inline <rk>

On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> 2014-12-25 10:33, Ravi Kerur:
> > Move common functions in eal.c to librte_eal/common directory.
> [...]
> >  lib/librte_eal/common/eal_common.c    | 328
> ++++++++++++++++++++++++++++++++++
> >  lib/librte_eal/common/eal_externs.h   |  42 +++++
>
> I don't agree with these new files.
> We must try to keep a semantic organization. The file eal_common_options.c
> would be better for option-related functions.
> Maybe that the split between system config, runtime config and internal
> config
> must be reworked.
>
> By the way, it would be nice to avoid extern variables.
>

<rk> I have taken care of your comments and will generate v4 patch.
Currently I have moved common functions in eal.c into
"eal_common_system_options.c" file. Are you suggesting that we further
divide "eal_common_options.c" and "eal_common_system_options.c(new file
added)" into 3 separate files i.e.

eal_common_system_options.c
eal_common_runtime_options.c
eal_common_internal_options.c

Thanks.


>
> --
> Thomas
>