From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 142B55921 for ; Mon, 5 Jan 2015 17:40:09 +0100 (CET) Received: by mail-pa0-f44.google.com with SMTP id et14so29004081pad.17 for ; Mon, 05 Jan 2015 08:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=oKEuzwOCs9eTudRtGsBvyRwDg5dpMqYxN+MLjPZnJ/8=; b=GUgHq/1BHQ3qq7OE/H4+zDxM69HdyfbNHowPOf76G1nGMUAm3SLGZyxhuDzcs/UW5n 75PmZxjoesCX0APVVrZabspSwCuhge2M7ubPZywYxlYe1DnZao3ZVWsNykBrK4I7PzlP fEPSQgJ48CzGMjOMXDGI4aT+TvwCAhwzear6+w1/CTJyd447hVh3yiqq5ZrMx3tAn+Cy ulFOnlC0CKnhzlwGMbbDMvkjJeyanrpVWuUsHIN/QpEZKePy8LKcfuyHdFP4X8CXYa8v 3MVe8ANoi5zihKD9y/JRNna5wRTzHIJU4u05afhIodW1YynlXz52Jso7iFveEMx3i/hF ef3w== MIME-Version: 1.0 X-Received: by 10.70.52.234 with SMTP id w10mr70659952pdo.50.1420476008203; Mon, 05 Jan 2015 08:40:08 -0800 (PST) Received: by 10.70.114.233 with HTTP; Mon, 5 Jan 2015 08:40:08 -0800 (PST) In-Reply-To: <1475634.GuJD5gSMru@xps13> References: <1475634.GuJD5gSMru@xps13> Date: Mon, 5 Jan 2015 08:40:08 -0800 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 16:40:09 -0000 Inline On Mon, Jan 5, 2015 at 12:55 AM, Thomas Monjalon wrote: > 2015-01-04 15:28, Ravi Kerur: > > We have a Gigabyte H97N motherboard which has I217 Intel chipset which > uses > > e100e drivers. I looked into lib/librte_pmd_e1000 directory and I do see > > that e1000e code is integrated but missing some support for read/write > from > > flash_address and other minor things. I have made changes shown below and > > have done some testing with testpmd utility and now have following > questions > > > > 1. What amount of testing is required to qualify patch as successfully > > tested on new chipsets > > There is no good answer to this question. Generally, you must be sure that > you don't break anything. > So you must test the code paths you have changed. > yes I have done testing on Ubuntu for I217 using testpmd. > > > 2. FreeBSD testing, currently we have Ubuntu 14.04 installed on existing > > H97N motherboard and testing is done solely on Linux. We plan to get > > another motherboard which will have I218 chipset and still deciding > whether > > to go with FreeBSD or Ubuntu. So the question I have is what amount of > > testing should be done on FreeBSD? I don't think > setup.sh/dpdk_nic_bind.py > > works on FreeBSD yet hence the question on testing. > > FreeBSD testing is required when patching common EAL, scripts or makefiles. > > > > lib/librte_pmd_e1000/e1000/e1000_api.c | 21 > +++++++++++++++++++++ > > > lib/librte_pmd_e1000/e1000/e1000_api.h | 1 + > > > lib/librte_pmd_e1000/e1000/e1000_osdep.h | 24 > +++++++++++++++++++----- > > These files are part of the base driver. > The rule is to not patch them and try to do the changes in PMD only. > There can be exceptions if an Intel maintainer acknowledges it. > Changes in these files are modifying existing macros E1000_READ_FLASH_REG, E1000_WRITE_FLASH_REG ... If it is not recommended to modify these files, should I move macros into some PMD file? Thanks. > > -- > Thomas >