From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 4F5B558DD for ; Tue, 6 Jan 2015 18:35:21 +0100 (CET) Received: by mail-pd0-f175.google.com with SMTP id g10so30825464pdj.34 for ; Tue, 06 Jan 2015 09:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Pzdg86z3oaV0NOM2FRJyaua3Fo+/ASsqnfR0CmCmBgo=; b=qZOWCYbR+xsVKN6k0tXCk71hvHtzsjXBY36Ye2RcjoEo8TeGfm6JyQQcbS0deDF0UC iz30UPFyy7D9KIGE6ZQrBC0RqdHFfnYas8+EzFzw0p0Onvc+Ak4CAaUe+8k6PVR0RHc8 XQDvGo+Ab3C7uVVH3WgubhBESKfr0Ac9unZMQ1BDSvO/AlrRYzfFJGNmdjYriolZ4lRS 6omZD1i/JJLj6ReO4RfzB0TE6508hvK4XYX04fCzqFH3KKvgvUnmHi6AAVEcOrkEsVD2 UgYNu0ldWOSXPc525phy0BeSqsEV3n8jpaKpdXTtYt+lj9pFl9bslO6A1/dnrwdc7Tv3 5JiA== MIME-Version: 1.0 X-Received: by 10.70.52.234 with SMTP id w10mr80759406pdo.50.1420565720587; Tue, 06 Jan 2015 09:35:20 -0800 (PST) Received: by 10.70.114.233 with HTTP; Tue, 6 Jan 2015 09:35:20 -0800 (PST) In-Reply-To: <3095360.cfZ4UIMKPn@xps13> References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <20293089.lIc3yRvdMZ@xps13> <3095360.cfZ4UIMKPn@xps13> Date: Tue, 6 Jan 2015 09:35:20 -0800 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 4/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2015 17:35:21 -0000 Inline On Mon, Jan 5, 2015 at 12:38 PM, Thomas Monjalon wrote: > 2015-01-05 10:56, Ravi Kerur: > > On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon < > thomas.monjalon@6wind.com> > > wrote: > > > 2014-12-25 10:33, Ravi Kerur: > > > > Move common functions in eal.c to librte_eal/common directory. > > > [...] > > > > lib/librte_eal/common/eal_common.c | 328 > ++++++++++++++++++++++++++++++++++ > > > > lib/librte_eal/common/eal_externs.h | 42 +++++ > > > > > > I don't agree with these new files. > > > We must try to keep a semantic organization. The file > eal_common_options.c > > > would be better for option-related functions. > > > Maybe that the split between system config, runtime config and internal > > > config > > > must be reworked. > > > > > > By the way, it would be nice to avoid extern variables. > > > > I have taken care of your comments and will generate v4 patch. > > Please do not forget v4 word and changelog when sending patches. > Check http://dpdk.org/dev#send > > > Currently I have moved common functions in eal.c into > > "eal_common_system_options.c" file. Are you suggesting that we further > > divide "eal_common_options.c" and "eal_common_system_options.c(new file > > added)" into 3 separate files i.e. > > > > eal_common_system_options.c > > eal_common_runtime_options.c > > eal_common_internal_options.c > > You are already doing big changes. So let's iterate with existing files and > avoid creating new ones. > eal_common_options.c must be kept. But if some code is not really related > to > runtime options, we could consider adding a new file eal_common_config.c, > not > sure about this one. > > -- > i have divided eal_common.c (new file which was added in v1 PATCH) into eal_common_system.c and eal_common_runtime.c and have moved appropriate functions into it. If file names are not appropriate or changes are not worth doing the split, I will merge them back into eal_common_config.c. Thanks. > Thomas >