From: Ravi Kerur <rkerur@gmail.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] rte_memcpy.h
Date: Tue, 14 Apr 2015 14:25:59 -0700 [thread overview]
Message-ID: <CAFb4SLBKSbXLEyJS_WpKVrptq8bA84OFaZNvCbYNFb9bX9z3yg@mail.gmail.com> (raw)
DPDK team,
I am looking at rte_memcpy.h implementation and I wasn't sure whether
coding in that file is done for any specific reason. I see superfluous type
casting in functions and instead of using loop for offset changes during
copy, separate invocation (same function) is done repeatedly.
I modified the code to remove unnecessary type casting and used loop for
offset changes. I compared the code generated by gcc (4.8.2) and in both
cases it looked same. In addition, "make test" for memcpy performance gave
similar results. I will send out a patch so you can check the changes I did
and let me know if it is good to make those changes.
Thanks,
Ravi
reply other threads:[~2015-04-14 21:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFb4SLBKSbXLEyJS_WpKVrptq8bA84OFaZNvCbYNFb9bX9z3yg@mail.gmail.com \
--to=rkerur@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).