From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id A13CCC2DC
 for <dev@dpdk.org>; Tue, 14 Apr 2015 23:35:05 +0200 (CEST)
Received: by pdbqa5 with SMTP id qa5so26663129pdb.1
 for <dev@dpdk.org>; Tue, 14 Apr 2015 14:35:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=b8mZmrZYZAebUdYdbVj8KlPPNEj+kwPnu/ZEe26FOXM=;
 b=UEU08QywYtCuUQ2ekL7wzcoJJsBhmcEvFJK4AQtxaDJftIyrkKoPu0/9IMvh1wfbVW
 taewCTm9ilIsheG4/0rCpmFHLOvmayysnFR9lMTCpaJIGMbtqblIZb9i5vZZeBj6ypJO
 eFNLSWpDirBEk8UcgZc/p/gaM4knn4oeVyTxG4espvS8zRlT+YFM5mwZXcl6vlj5geNq
 /59q4jw+5fSgQEErUvgK50vQr5tkh/RmeKZ5dhh3tjbjqjnM2ywVG1FdAsj/iX3/Qwgn
 /ksGXWp57fJmiRNLnYqPQQNV4BOQrzwV46kIYwk3fHQZmS6E/GIyBWJlKzpFb3mujQSi
 sJ1A==
MIME-Version: 1.0
X-Received: by 10.70.37.45 with SMTP id v13mr18512478pdj.50.1429047304765;
 Tue, 14 Apr 2015 14:35:04 -0700 (PDT)
Received: by 10.70.123.2 with HTTP; Tue, 14 Apr 2015 14:35:04 -0700 (PDT)
In-Reply-To: <1653003.yPkaDFgZKF@xps13>
References: <1428608301-31033-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-2-git-send-email-rkerur@gmail.com>
 <1653003.yPkaDFgZKF@xps13>
Date: Tue, 14 Apr 2015 14:35:04 -0700
Message-ID: <CAFb4SLBUrSviEu3+f-vv3j4OktjodM5Dy0AUbxrpa2QtxpAVWQ@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2015 21:35:06 -0000

On Tue, Apr 14, 2015 at 6:59 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> Hi Ravi,
>
> 2015-04-09 12:40, Ravi Kerur:
> > --- a/lib/librte_eal/common/eal_common_thread.c
> > +++ b/lib/librte_eal/common/eal_common_thread.c
> [...]
> > +#ifdef RTE_EXEC_ENV_BSDAPP
> > +#include <pthread_np.h>
> > +#include <sys/thr.h>
> > +#else /* RTE_EXEC_ENV_BSDAPP */
> >  #include <pthread.h>
> > +#endif /* RTE_EXEC_ENV_BSDAPP */
> [...]
> > +#ifdef RTE_EXEC_ENV_BSDAPP
> > +     RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%p;cpuset=[%s%s])\n",
> > +             lcore_id, thread_id, cpuset, ret == 0 ? "" : "...");
> > +#else /* RTE_EXEC_ENV_BSDAPP */
> > +     RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%x;cpuset=[%s%s])\n",
> > +             lcore_id, (int)thread_id, cpuset, ret == 0 ? "" : "...");
> > +#endif /* RTE_EXEC_ENV_BSDAPP */
>
> These lines should stay in bsdapp and linuxapp directory.
> You can add a new function to eal_thread.h to format the thread id,
> so you'll be able to use %s in generic log above.
>

Thomas, sure will make the changes. I will wait for additional comments if
any for other patches and send v6 together.

Thanks.