From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com
 [209.85.218.43]) by dpdk.org (Postfix) with ESMTP id C40459E5
 for <dev@dpdk.org>; Tue, 15 Sep 2015 13:28:13 +0200 (CEST)
Received: by oibi136 with SMTP id i136so93384354oib.3
 for <dev@dpdk.org>; Tue, 15 Sep 2015 04:28:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=4E99FQBEsYAEmnnIsTZ/wtWjl0WBUdvWbsZeO7bXunE=;
 b=PpH5NWY47tt0vNZSc1LDess9xqdm2durc3ET9MRTomRHURcFqDU2j4t5k2wK+h+8Rd
 ySD6dDKDGEOzq2/5FDfKuwSWjYWd9yTqnkB+6jSKncVAfus1Qa8PM+ap0DgnbNEVJCYR
 nmgoL5McnTLmABpbA37AGNJcnr/gZn5smsYsAcOrfe/hG+L1pbd64gXwj+6ZkyAnwo8g
 USsoQl3dYis2CsR2oej24NF+hjNGR+4Akl9ePBk04/wnLjPejDMlirc1bthmDVP1p+yi
 qVLVlzfg4Hca5pr9g8kvVmvFVWU2SEiTLhZiKyIukI9l2xJrw8zh70vMBk3NZQ60HeKg
 +6aQ==
MIME-Version: 1.0
X-Received: by 10.202.178.131 with SMTP id b125mr15781177oif.65.1442316493159; 
 Tue, 15 Sep 2015 04:28:13 -0700 (PDT)
Received: by 10.202.65.197 with HTTP; Tue, 15 Sep 2015 04:28:13 -0700 (PDT)
In-Reply-To: <CALwxeUtHL+bzd92XeUcgeO4w6=J7XRPLb1NO3+2=vWY5-MiwMA@mail.gmail.com>
References: <1440013341-29659-1-git-send-email-rkerur@gmail.com>
 <1440013376-29715-1-git-send-email-rkerur@gmail.com>
 <55D53655.1040808@igel.co.jp>
 <CAFb4SLBpa8LF2K6-tjK+bk20tKsoJLd2nwDqdmySJg=A9402Eg@mail.gmail.com>
 <55D69C00.2020609@igel.co.jp>
 <CAFb4SLCuS70jtY+bsNM9e0=YoeBC614BD8XNyNhVeJPofAJ4aQ@mail.gmail.com>
 <CALwxeUtHL+bzd92XeUcgeO4w6=J7XRPLb1NO3+2=vWY5-MiwMA@mail.gmail.com>
Date: Tue, 15 Sep 2015 04:28:13 -0700
Message-ID: <CAFb4SLBZV3N8_SVB3Nra+3v4Np0at4DN52wYwiHBe9PEGzG5LA@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: David Marchand <david.marchand@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Sep 2015 11:28:14 -0000

Hi David,


On Thu, Sep 3, 2015 at 7:04 AM, David Marchand <david.marchand@6wind.com>
wrote:

> Hello Ravi, Tetsuya,
>
> On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur <rkerur@gmail.com> wrote:
>
>> Let us know how you want us to fix this? To fix rte_eal_vdev_init and
>> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches
>> mentioned in earlier discussion. In addition to those we have another
>> approach with changes isolated only to rte_ether component. I am attaching
>> diffs (preliminary) with this email. Please let us know your inputs since
>> it involves EAL component.
>>
>
> - This patch looks like a good ethdev cleanup (even if it really lacks
> some context / commit log).
>
> I wonder just why you only take the first part of the name in
> rte_eth_dev_get_port_by_name().
> Would not this match, let's say, both toto and toto0 vdevs ?
> Is this intended ?
>
> It was not intended, i will look into it.

>
> - In the end, with this patch, do we still need to update eal ?
> Looking at the code, I am not sure anymore.
>

Approach 3 (preliminary diffs sent as an attachment) doesn't involve EAL
but the other two solutions do. So please let us know which one you prefer.
I will send updated patch.

Thanks,
Ravi


>
>
>
> --
> David Marchand
>