Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

[Ravi Kerur <rkerur@gmail.com>]

Sorry for the inconvenience. I was not aware of "make test" utility which
does more elaborate testing. I will make a note of it and make sure future
patches will go through it. I had done basic testing with testpmd as the
changes were minimal.

Thanks,
Ravi

On Mon, Jan 19, 2015 at 1:13 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> 2015-01-19 08:21, David Marchand:
> > On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin <helin.zhang@intel.com>
> wrote:
> >
> > > It seems that your fix result in cannot launching applications.
> > > I don't suspect the correction of your fix, but somewhere else needs
> to be
> > > corrected together with your fix.
> > >
> > > Logs:
> > > /************************************************************
> > > RING: Cannot reserve memory for tailq
> >
> > I have a quick fix for this one (rte_malloc_socket refuses 0 alignment),
> > but looking at the change, I would say there are a lot of places to be
> > checked.
> > Were those places checked during review ?
>
> http://dpdk.org/browse/dpdk/commit/?id=2fc8d6daa4c7a
> This case demonstrates that an Acked-by line is not always sufficient
> to apply a patch.
>
> > Kerur, did you run a make test ?
> > All tests fail for me because of rte_malloc_socket.
>
> My dream would be to have a machine receiving patches, applying them in a
> sandbox,
> run some basic tests and reports failures.
>
> It should be fixed now:
>         http://dpdk.org/browse/dpdk/commit/?id=8e3e06501660
>
> --
> Thomas
>