From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 056385A82 for ; Mon, 19 Jan 2015 18:07:48 +0100 (CET) Received: by mail-pa0-f53.google.com with SMTP id kq14so39857854pab.12 for ; Mon, 19 Jan 2015 09:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mSaODwXNPZ8obdM8OVsBCTXXXVMgvbIXGI5JW1J2kP8=; b=iKJMlX2rAvfb8q5Ls0Up61B6eJEwyMOCSq1bdHmxxIv2qcME0jSfcNKbHYKc8z3+7d K48t+jOhUT17dS5OOFVnNUCaSxWosLPBpcqxaiNjE9EzZoFmdqnOFqJaUqpLmhDbdnFP AZ7EgercZGGbraS/3g46rm+lsvmTfkhIoYOoYN3D/DFl8Z2fQD7SbMNkyGiWKqVXKSC6 MEJT4kQtdVcYl0kFJ8E1hAuP/eFzfwngdFhDPPesPPN+Vo+ZW4CY2Y75R3+LC/XnYjl2 s3GvheFpT5oMa80FcPVAtw9qP3mz8LOnZBO/uImj4CwF3FwvkhAWx6c5Pj/bLfcjxfp7 pbMQ== MIME-Version: 1.0 X-Received: by 10.70.140.167 with SMTP id rh7mr46721121pdb.108.1421687267079; Mon, 19 Jan 2015 09:07:47 -0800 (PST) Received: by 10.70.91.166 with HTTP; Mon, 19 Jan 2015 09:07:47 -0800 (PST) In-Reply-To: <7022282.sJULtgJP1R@xps13> References: <1419694115-1892-1-git-send-email-rkerur@gmail.com> <7022282.sJULtgJP1R@xps13> Date: Mon, 19 Jan 2015 09:07:47 -0800 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2015 17:07:48 -0000 Sorry for the inconvenience. I was not aware of "make test" utility which does more elaborate testing. I will make a note of it and make sure future patches will go through it. I had done basic testing with testpmd as the changes were minimal. Thanks, Ravi On Mon, Jan 19, 2015 at 1:13 AM, Thomas Monjalon wrote: > 2015-01-19 08:21, David Marchand: > > On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin > wrote: > > > > > It seems that your fix result in cannot launching applications. > > > I don't suspect the correction of your fix, but somewhere else needs > to be > > > corrected together with your fix. > > > > > > Logs: > > > /************************************************************ > > > RING: Cannot reserve memory for tailq > > > > I have a quick fix for this one (rte_malloc_socket refuses 0 alignment), > > but looking at the change, I would say there are a lot of places to be > > checked. > > Were those places checked during review ? > > http://dpdk.org/browse/dpdk/commit/?id=2fc8d6daa4c7a > This case demonstrates that an Acked-by line is not always sufficient > to apply a patch. > > > Kerur, did you run a make test ? > > All tests fail for me because of rte_malloc_socket. > > My dream would be to have a machine receiving patches, applying them in a > sandbox, > run some basic tests and reports failures. > > It should be fixed now: > http://dpdk.org/browse/dpdk/commit/?id=8e3e06501660 > > -- > Thomas >