From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by dpdk.org (Postfix) with ESMTP id 6E51A9A81 for ; Fri, 17 Apr 2015 00:12:58 +0200 (CEST) Received: by oica37 with SMTP id a37so55836558oic.0 for ; Thu, 16 Apr 2015 15:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Tnj8AnXYLVf12qZET0wvHs55nFHehP1SVXorO1/MuhM=; b=R9x2UyWtAb2i6YSv8O1qhCvQN04Gi7QRPaKPVhiP03lDiezbe3IYrENxvDyjc6IKA1 cxHl4U3MpdbdPo1Qe7ZSe0UyQjxgvhEdvrrLW6lYyzIE+008tA/x90pULW5pa9ZT85fF d/IWRY+vjxSIYrXGYOZb8RZbtetW+/6zqZh1hsv/C/5Sz9vq0tu4voiFV2LAOo6n5kC6 /bP3W8pu+uXc+wufQxKTb5pnoIZI+UrAaIUHZK6QZxXxwe4KD1Qq+5kvwboVx3Fs06mH mmctpKKlHurmXmNRzHYQWfYMTJu6utvZAAX7jvWikzAgJ453V4sECbrDj0yW6u6DhS6t bsFg== MIME-Version: 1.0 X-Received: by 10.182.204.6 with SMTP id ku6mr28071038obc.48.1429222378014; Thu, 16 Apr 2015 15:12:58 -0700 (PDT) Received: by 10.202.179.6 with HTTP; Thu, 16 Apr 2015 15:12:57 -0700 (PDT) In-Reply-To: <1432996.oUgD5RRFGj@xps13> References: <1428608301-31033-1-git-send-email-rkerur@gmail.com> <1428608412-31191-1-git-send-email-rkerur@gmail.com> <1428608412-31191-7-git-send-email-rkerur@gmail.com> <1432996.oUgD5RRFGj@xps13> Date: Thu, 16 Apr 2015 15:12:57 -0700 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 22:12:58 -0000 On Thu, Apr 16, 2015 at 2:02 AM, Thomas Monjalon wrote: > This patch is very sensible and difficult to follow. > I'm really afraid that some nasty bugs could be hidden. > Please could you try to split it in several steps? > Thanks > Sure, will drop eal_pci_uio.c and eal_pci_vfio.c changes and will send out new version. > > 2015-04-09 12:40, Ravi Kerur: > > Changes in v5 > > Rebase to latest code. > > Removed RTE_EXEC_ENV_BSDAPP from earlier changes. > > > > Changes in v4 > > Move common functions in eal_pci.c to librte_eal/common/ > > eal_common_pci.c file. > > > > Following functions are moved to eal_common_pci.c file. > > > > void *pci_map_resource(void *requested_addr, const int vfio_fd, > > const char *devname, off_t offset, size_t size); > > int pci_addr_comparison(struct rte_pci_addr *addr, > > struct rte_pci_addr *addr2); > > int rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, > > struct rte_pci_device *dev); > > > > Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in > > common function. > > Fix checkpatch warnings and errors. > > > > Changes in v3 > > N/A > > > > Changes in v2 > > N/A > > > > Changes in v1 > > N/A > > > > Signed-off-by: Ravi Kerur > > --- > > lib/librte_eal/bsdapp/eal/eal_pci.c | 122 > ++++----------------------- > > lib/librte_eal/common/eal_common_pci.c | 130 > ++++++++++++++++++++++++++++- > > lib/librte_eal/common/eal_private.h | 48 +++++++++++ > > lib/librte_eal/linuxapp/eal/eal_pci.c | 100 +--------------------- > > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 6 -- > > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 36 ++------ > > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 17 ++-- > > 7 files changed, 212 insertions(+), 247 deletions(-) > >