From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) by dpdk.org (Postfix) with ESMTP id DE583C36C for ; Fri, 17 Apr 2015 00:11:48 +0200 (CEST) Received: by oblw8 with SMTP id w8so54989538obl.0 for ; Thu, 16 Apr 2015 15:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Q9xjj7WbHh7a82/3N2MOiNiYGD7aITXkjybY+uyJfKg=; b=oGn3x+g5jK7k0XWhLNHbN1FRL/ImKwyCj6SLxpbS8CHS0w6KFfmALekQLADrl8Qh39 Ko2oNfKSoyq2HgXKahpvF4RkKMbPw9SiSFGb8fxjj/wYn2yfsAhnigvE5GSGlhAjcWIw uqQuHOZLT6bbr1X3H/3Odgn3oJChtP8w00Rm0bhwBK4G5zJJLbkyWneynoXyx1lKLa1x wxoVzlUQ8OL3HRm2t38Rld/ZT9qkoOfkZsj9Ei2zgSSdn+z6YQhhq5AniDwQcsl5bxaJ Id1colharjFWeiADrvcJ+pRPeNP4I+fZ0pNdRp2HZ6X1CoE2uOKW3zKqtEN7ITl/hC+v TA8w== MIME-Version: 1.0 X-Received: by 10.182.24.5 with SMTP id q5mr27377766obf.8.1429222308031; Thu, 16 Apr 2015 15:11:48 -0700 (PDT) Received: by 10.202.179.6 with HTTP; Thu, 16 Apr 2015 15:11:47 -0700 (PDT) In-Reply-To: <119098819.UXtPphdbAd@xps13> References: <1428608301-31033-1-git-send-email-rkerur@gmail.com> <1428608412-31191-1-git-send-email-rkerur@gmail.com> <1428608412-31191-6-git-send-email-rkerur@gmail.com> <119098819.UXtPphdbAd@xps13> Date: Thu, 16 Apr 2015 15:11:47 -0700 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 22:11:49 -0000 On Thu, Apr 16, 2015 at 1:52 AM, Thomas Monjalon wrote: > 2015-04-09 12:40, Ravi Kerur: > > Changes in v5 > > Rebase to latest code. > > > > Changes in v4 > > Make rte_eal_hugepage_init and rte_eal_hugepage_attach as > > wrapper functions for BSD. > > > > Changes in v3 > > Changed subject to be more explicit on file name inclusion. > > > > Changes in v2 > > Use common function names rte_eal_hugepage_init and > > rte_eal_hugepage_attach for BSD and Linux. Update comments about its > > actuality in function declaration. > > > > Changes in v1 > > Move common functions in eal_memory.c to librte_eal/common/ > > eal_common_memory.c file. > > > > Following functions are moved to eal_common_memory.c file > > > > static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void); > > > > Fix checkpatch warnings and errors. > > > > Signed-off-by: Ravi Kerur > [...] > > +/** > > + * This function prepares physical memory mapping > > + * i.e. hugepages on Linux and > > + * contigmem on BSD. > > OK > > > + * It is a wrapper function for BSD which will > > + * internally call contigmem_init. > > Please avoid such comment which is difficult to maintain and not really > useful. > > > + * It is a wrapper function for BSD which will > > + * internally call contigmem_attach. > > Same comment. > > Except the above comments, it seems goods. > Acked-by: Thomas Monjalon > > Thanks > Will fix comments in next version.