From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by dpdk.org (Postfix) with ESMTP id 692488E66 for ; Wed, 23 Sep 2015 23:22:05 +0200 (CEST) Received: by obbbh8 with SMTP id bh8so43959289obb.0 for ; Wed, 23 Sep 2015 14:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3m+oQoXxrWLwLm3txD5x68e4f+9fpFgLOBY/IuymhOU=; b=yX0Ou0FbLuHO+evPw2VN10AaGOkYYib5ygr0txfKqKNq35GSECygFarJkzAuZds6zy zknm4CeIxIlzlS3a5EpEFkKnvmY3eExicU0gHvBNmBDCiTHiwHJZfKBESjhzv3jxpQd1 C16Lt2rIVfDUfUxSnwIM3TrX9GkgxOEhMCmLVaSxgb3sjfQKk/bu29DkikP6Z++WNjZ9 61GXHCFbhoXFotm4TBCWuDT4bwaUbnjr/1mW3X6NmfNUfVDv1p0rFxefi9/Dfb/KY71V 5tM9oUPP3ivRJ5e/OPO7AgStcpCJbJXvezIXXkplY5aGxUNka6Kk0wQzXEKEyCRSyJEQ kg/A== MIME-Version: 1.0 X-Received: by 10.60.74.103 with SMTP id s7mr20162728oev.86.1443043324796; Wed, 23 Sep 2015 14:22:04 -0700 (PDT) Received: by 10.202.65.197 with HTTP; Wed, 23 Sep 2015 14:22:04 -0700 (PDT) In-Reply-To: References: <1440013341-29659-1-git-send-email-rkerur@gmail.com> <1440013376-29715-1-git-send-email-rkerur@gmail.com> <55D53655.1040808@igel.co.jp> <55D69C00.2020609@igel.co.jp> Date: Wed, 23 Sep 2015 14:22:04 -0700 Message-ID: From: Ravi Kerur To: David Marchand Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 21:22:05 -0000 Hi David, Tetsuya, I have sent V3 (changes isolated to rte_ether component) for formal review. Please look into it and let me know your inputs. @David: I looked at "rte_eth_dev_get_port_by_name()", this function is similar to "rte_eth_dev_get_name_by_port" and I have used same logic. Let me know if this not correct I can fix both. Thanks, Ravi On Tue, Sep 15, 2015 at 4:28 AM, Ravi Kerur wrote: > Hi David, > > > On Thu, Sep 3, 2015 at 7:04 AM, David Marchand > wrote: > >> Hello Ravi, Tetsuya, >> >> On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur wrote: >> >>> Let us know how you want us to fix this? To fix rte_eal_vdev_init and >>> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches >>> mentioned in earlier discussion. In addition to those we have another >>> approach with changes isolated only to rte_ether component. I am attaching >>> diffs (preliminary) with this email. Please let us know your inputs since >>> it involves EAL component. >>> >> >> - This patch looks like a good ethdev cleanup (even if it really lacks >> some context / commit log). >> >> I wonder just why you only take the first part of the name in >> rte_eth_dev_get_port_by_name(). >> Would not this match, let's say, both toto and toto0 vdevs ? >> Is this intended ? >> >> It was not intended, i will look into it. > >> >> - In the end, with this patch, do we still need to update eal ? >> Looking at the code, I am not sure anymore. >> > > Approach 3 (preliminary diffs sent as an attachment) doesn't involve EAL > but the other two solutions do. So please let us know which one you prefer. > I will send updated patch. > > Thanks, > Ravi > > >> >> >> >> -- >> David Marchand >> > >