From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by dpdk.org (Postfix) with ESMTP id 27CB45A3E for ; Fri, 24 Apr 2015 17:14:05 +0200 (CEST) Received: by oica37 with SMTP id a37so42993435oic.0 for ; Fri, 24 Apr 2015 08:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WODGruHEZQaCDbFr9O07RJB5iPurxzcaCdi9MsWoIZA=; b=n18LJNFltcNYAQiPBR/b4rYr9UDXy7xNCuBBKMVBQ9XJKOdaOtfa8cRKlmn/qGot5X SJRhi26dXGVqhO5lwa/vf1iux1QV3/qMfl1yu4gTVPztly0stMzjES3fxZalFOD+PziH 2HUMlGCR2UpdNdfL+8mgQjdPW3FAxujw6YVJF2Al35U8WYiLpqS/Nr+O+v6FhgiL3EMi zE6EZv6Eac+gR2zqy8ksKgdTesiD54OZC4zt2goXUpQY84TULu8yurFL24lbEbmRKsnX wg6Sn5kmDEhkFbbBIY6xoApjYRvO2G/rEZcUO9mkViP69t7ZRaUhi+5MRlZ90vRFS21O k8vg== MIME-Version: 1.0 X-Received: by 10.202.98.193 with SMTP id w184mr7355067oib.96.1429888444390; Fri, 24 Apr 2015 08:14:04 -0700 (PDT) Received: by 10.202.179.195 with HTTP; Fri, 24 Apr 2015 08:14:04 -0700 (PDT) In-Reply-To: <20150424135114.GA32445@hmsreliant.think-freely.org> References: <1429824909-9360-1-git-send-email-rkerur@gmail.com> <1429824936-9399-1-git-send-email-rkerur@gmail.com> <20150424135114.GA32445@hmsreliant.think-freely.org> Date: Fri, 24 Apr 2015 08:14:04 -0700 Message-ID: From: Ravi Kerur To: Neil Horman Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2015 15:14:05 -0000 On Fri, Apr 24, 2015 at 6:51 AM, Neil Horman wrote: > On Thu, Apr 23, 2015 at 02:35:31PM -0700, Ravi Kerur wrote: > > Changes in v7 > > Remove _setname_ pthread calls. > > Use rte_gettid() API in RTE_LOG to print thread_id. > > > > Changes in v6 > > Remove RTE_EXEC_ENV_BSDAPP from eal_common_thread.c file. > > Add pthread_setname_np/pthread_set_name_np for Linux/FreeBSD > > respectively. Plan to use _getname_ in RTE_LOG when available. > > Use existing rte_get_systid() in RTE_LOG to print thread_id. > > > > Changes in v5 > > Rebase to latest code. > > > > Changes in v4 > > None > > > > Changes in v3 > > Changed subject to be more explicit on file name inclusion. > > > > Changes in v2 > > None > > > > Changes in v1 > > eal_thread.c has minor differences between Linux and BSD, move > > entire file into common directory. > > Use RTE_EXEC_ENV_BSDAPP to differentiate on minor differences. > > Rename eal_thread.c to eal_common_thread.c > > Makefile changes to reflect file move and name change. > > Fix checkpatch warnings. > > > > Signed-off-by: Ravi Kerur > > --- > > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > > lib/librte_eal/bsdapp/eal/eal_thread.c | 152 > ------------------------------ > > lib/librte_eal/common/eal_common_thread.c | 147 > ++++++++++++++++++++++++++++- > > lib/librte_eal/linuxapp/eal/eal_thread.c | 152 > +----------------------------- > > 4 files changed, 148 insertions(+), 305 deletions(-) > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > b/lib/librte_eal/bsdapp/eal/Makefile > > index 2357cfa..55971b9 100644 > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > @@ -87,7 +87,7 @@ CFLAGS_eal_common_log.o := -D_GNU_SOURCE > > # workaround for a gcc bug with noreturn attribute > > # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603 > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > -CFLAGS_eal_thread.o += -Wno-return-type > > +CFLAGS_eal_common_thread.o += -Wno-return-type > > CFLAGS_eal_hpet.o += -Wno-return-type > > endif > > > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c > b/lib/librte_eal/bsdapp/eal/eal_thread.c > > index 9a03437..5714b8f 100644 > > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > > @@ -35,163 +35,11 @@ > > #include > > #include > > #include > > -#include > > -#include > > -#include > > -#include > > #include > > > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > -#include > > - > > #include "eal_private.h" > > #include "eal_thread.h" > > > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; > NAK, these are exported symbols, you can't remove them without going > through the > deprecation process. > > They are not removed/deleted, they are moved from eal_thread.c to eal_common_thread.c file since it is common to both Linux and BSD. Thanks Ravi Regards > Neil > >