From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com
 [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 0ED7A2A9
 for <dev@dpdk.org>; Thu, 25 Dec 2014 20:13:10 +0100 (CET)
Received: by mail-pa0-f50.google.com with SMTP id bj1so12104972pad.37
 for <dev@dpdk.org>; Thu, 25 Dec 2014 11:13:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=0yZreUCiiJW53MVp3lf2hp5eXo7ewxF+JOCLmIk0slc=;
 b=lnbnh27UnvT+90ceBrflfn/5g/FA/pq9mrVXfhj+VpvSGQbi1OlU/bkDNWeTpoPMTd
 +PH35338Ny16cRQdF8BhPqEGs1uVEXbHq5Oum/ougLlsNBQSVYBBTJyxQvO8ldPq9ws0
 r9Aq/wr0zfQUwq2EASPlAto4gTzIskMOcndgzQEvhwUm8lN+i9jnz3MmxyUR2PEeopxI
 33Jl69wb7K6Uq+pwO6+/Bx9jVtHrPrDrmjNo6cNNbaHhvWzk6kxFpN3gLn9DeVuHMQUt
 3TzuJplBT2eMzMsePhBKrday9UmSHVYa5A106ufhbJJjeRF+w6xw5NfkGy8czTvQgi7p
 Xwkg==
MIME-Version: 1.0
X-Received: by 10.70.43.138 with SMTP id w10mr62411136pdl.50.1419534789146;
 Thu, 25 Dec 2014 11:13:09 -0800 (PST)
Received: by 10.70.114.233 with HTTP; Thu, 25 Dec 2014 11:13:09 -0800 (PST)
In-Reply-To: <20141225174146.GE3199@localhost.localdomain>
References: <1419521597-31978-1-git-send-email-rkerur@gmail.com>
 <1419521597-31978-4-git-send-email-rkerur@gmail.com>
 <20141225174146.GE3199@localhost.localdomain>
Date: Thu, 25 Dec 2014 11:13:09 -0800
Message-ID: <CAFb4SLCP_bN=hDC-8H0BN+VnSr51ozfz2=jH3aU_Pe=b9t2v2Q@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/7] Move EAL common functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Dec 2014 19:13:10 -0000

Inline <rk>

On Thu, Dec 25, 2014 at 9:41 AM, Neil Horman <nhorman@tuxdriver.com> wrote:

> On Thu, Dec 25, 2014 at 10:33:13AM -0500, Ravi Kerur wrote:
> > eal_thread.c has minor difference between Linux and BSD, move
> > into common directory.
> > Use RTE_EXEC_ENV_BSDAPP to differentiate minor difference.
> > Rename eal_thread.c to eal_common_thread.c
> > Makefile changes to reflect file move and name change.
> > Fix checkpatch warnings.
> >
> Don't you want to add RTE_EXEC_ENV_BSDAPP=y to config/common_bsdapp?
>

<rk> Its already defined in common/common_bsdapp.

>
> Neil
>
>