From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f45.google.com (mail-oi0-f45.google.com [209.85.218.45]) by dpdk.org (Postfix) with ESMTP id AA7D929B6 for ; Wed, 24 Feb 2016 05:00:54 +0100 (CET) Received: by mail-oi0-f45.google.com with SMTP id j125so4901822oih.0 for ; Tue, 23 Feb 2016 20:00:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=JnDrge2FN4wiGNgbtGnP95v/I9NMhNLr5lukE7PqnAo=; b=dZF3r2y41HCKr16yeYX7Lqhjyx05DmSe23I8460KpV16d6UGsECbel1WW7Fa/R6iyV 5ApotwbyJKr5NhSJwUg9eQHf1rQ9Hbnxy4QVYErfyRuoYX2jqRasYqkGRSjIOXPkPH+3 pP491dlYYn+cQxWaUBnJMeXAtao6ZHzpIoZjA6B19MnPCo9DaOxrQ/zdnA+TDGa+J8PH 8sEV8+OfZcSmytDgGHk8WDy2/nQuUZ+s7NO22qQmhjYE/Qka/Z4yf13e1hxWZIwziRrN PCjoK9sI5hvRthVBsNlSwGEWsNJXPve6XA8qgYK8lyb3cfh0ZXlMvWP95YD5oUbAAdDi YNWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=JnDrge2FN4wiGNgbtGnP95v/I9NMhNLr5lukE7PqnAo=; b=XNBqLs391TB1iHPbDfnKsVP2wPk1dk8r7DmZsRmN1tYhQr5OvLDZ0ChW1XhpobsDVZ i/HCz8kaMehzCS0AQSW6qJNGI8m+P1+NtxX15yBk+EpaS6g74hVH+v4a7Kv7BrsgE1zd r36UotzbkF/N7AX2H3MzupyRfxSLTddeXBrgCSkwFi18/8Qi3nOiNz2wSy6pxIESxeLz WtcOEETI+93142xpDXR88Z+WwlTJMTsYe2glT91TPFTGLGP2dr7IlpKBg/lChbYQjTcP TDuaK2egLK/TeXDf3Ni2AP51Zh1yjEAqIMwo/qGwpi94ezJyRdyarjaX1USE8zmCBkaX TDvQ== X-Gm-Message-State: AG10YOQ4x1xhIHajcsm4FLge283U5YLuAjqzAKjPOLgAYiOkanAb7Da/e6KjTLC8x0WhXZykpEfREhfwYIeOIw== MIME-Version: 1.0 X-Received: by 10.202.89.68 with SMTP id n65mr29661684oib.138.1456286454185; Tue, 23 Feb 2016 20:00:54 -0800 (PST) Received: by 10.202.172.71 with HTTP; Tue, 23 Feb 2016 20:00:54 -0800 (PST) In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941033C7CA2@SHSMSX103.ccr.corp.intel.com> References: <1431979303-1346-2-git-send-email-rkerur@gmail.com> <1453950506-28067-1-git-send-email-zhihong.wang@intel.com> <8F6C2BD409508844A0EFC19955BE0941033C7CA2@SHSMSX103.ccr.corp.intel.com> Date: Tue, 23 Feb 2016 20:00:54 -0800 Message-ID: From: Ravi Kerur To: "Wang, Zhihong" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [dpdk-dev, v3] Implement memcmp using Intel SIMD instrinsics. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 04:00:55 -0000 On Tue, Feb 23, 2016 at 4:22 AM, Wang, Zhihong wrote: > > > It'd be great if you could format this patch into a patch set with > several > > > little ones. :-) > > > Also, the kernel checkpatch is very helpful. > > > Good coding style and patch organization make it easy for in-depth > reviews. > > > > > Combination of scalar and vector (32/64/128) was done to get optimal > performance numbers. If there is enough interest in this I can work on it > and provide an updated patch set. > > That'll be very helpful! Looking forward to your patch :) > BTW, have you tested real example performance with your patch? > Yes it was tested with hash functions in dpdk code.I will work on it and send updated patch. Thanks for your inputs I will incorporate them in next patch series.