From: Ravi Kerur <rkerur@gmail.com>
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Clean up rte_memcpy.h file
Date: Wed, 15 Apr 2015 14:00:51 -0700 [thread overview]
Message-ID: <CAFb4SLCa06Z1++fx4SHNX67C9Vkj-KtvhETK=O+e9FNqLPCnQg@mail.gmail.com> (raw)
In-Reply-To: <552E05FB.30504@intel.com>
On Tue, Apr 14, 2015 at 11:32 PM, Pawel Wodkowski <
pawelx.wodkowski@intel.com> wrote:
> On 2015-04-14 23:31, Ravi Kerur wrote:
>
>> +
>> + for (i = 0; i < 8; i++) {
>> + ymm = _mm256_loadu_si256((const __m256i *)(src +
>> i * 32));
>> + _mm256_storeu_si256((__m256i *)(dst + i * 32),
>> ymm);
>> + }
>> +
>> n -= 256;
>> - ymm1 = _mm256_loadu_si256((const __m256i *)((const
>> uint8_t *)src + 1 * 32));
>> - ymm2 = _mm256_loadu_si256((const __m256i *)((const
>> uint8_t *)src + 2 * 32));
>> - ymm3 = _mm256_loadu_si256((const __m256i *)((const
>> uint8_t *)src + 3 * 32));
>> - ymm4 = _mm256_loadu_si256((const __m256i *)((const
>> uint8_t *)src + 4 * 32));
>> - ymm5 = _mm256_loadu_si256((const __m256i *)((const
>> uint8_t *)src + 5 * 32));
>> - ymm6 = _mm256_loadu_si256((const __m256i *)((const
>> uint8_t *)src + 6 * 32));
>> - ymm7 = _mm256_loadu_si256((const __m256i *)((const
>> uint8_t *)src + 7 * 32));
>> - src = (const uint8_t *)src + 256;
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 0 * 32),
>> ymm0);
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 1 * 32),
>> ymm1);
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 2 * 32),
>> ymm2);
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 3 * 32),
>> ymm3);
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 4 * 32),
>> ymm4);
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 5 * 32),
>> ymm5);
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 6 * 32),
>> ymm6);
>> - _mm256_storeu_si256((__m256i *)((uint8_t *)dst + 7 * 32),
>> ymm7);
>> - dst = (uint8_t *)dst + 256;
>> + src = src + 256;
>> + dst = dst + 256;
>> }
>>
>
> Did you perform a performance test on that part?
>
>
I ran "make test" which runs "memcpy perf" results were given in
"cover-letter". I am pasting it here again.
/**********************With changes*************************************/
Start memcpy_perf: Success [00m 00s]
Memcpy performance autotest: Success [09m 36s] [17m 45s]
/**********************Without changes**********************************/
Start memcpy_perf: Success [00m 00s]
Memcpy performance autotest: Success [09m 35s] [13m 57s]
--
> Pawel
>
prev parent reply other threads:[~2015-04-15 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 21:30 [dpdk-dev] [PATCH] Cleanup rte_memcpy.h Ravi Kerur
2015-04-14 21:31 ` [dpdk-dev] [PATCH] Clean up rte_memcpy.h file Ravi Kerur
2015-04-15 2:53 ` Stephen Hemminger
2015-04-15 21:04 ` Ravi Kerur
2015-04-15 6:32 ` Pawel Wodkowski
2015-04-15 21:00 ` Ravi Kerur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFb4SLCa06Z1++fx4SHNX67C9Vkj-KtvhETK=O+e9FNqLPCnQg@mail.gmail.com' \
--to=rkerur@gmail.com \
--cc=dev@dpdk.org \
--cc=pawelx.wodkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).