From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f172.google.com (mail-ob0-f172.google.com [209.85.214.172]) by dpdk.org (Postfix) with ESMTP id 184D9234 for ; Wed, 30 Sep 2015 21:14:21 +0200 (CEST) Received: by obbzf10 with SMTP id zf10so39828812obb.2 for ; Wed, 30 Sep 2015 12:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ySrU9SJU/wKxdq/UAnFZoDDwZw98ktyb4yDXFeQgdm0=; b=Voh5GQxUTW91WJe4fWtOWj8/d9TvwD3wxDHl/+n9plLBGRfqjFAVRC+a7MX4N6vRuY 4F6MAGc8L+rSOIoZ2xSyaiwCmcZd5W9YEonau4IMZpM7SFMWpBMccJxYEJPhBt5qWhvC 7BTcui87X+enNVqnTIzj5dIorfYrlQAeu1y/orkZTISB/isD16p9PReVj1Bjr6vh2k6u 7XnwzFzm7G7YoAX81xBIEEi7+K+yjmJtUEY1h/9UuNeGv4hmK4MtSai963Vewa0xB2lq STbwmg1trDRrNV+gJN8j0sH13weVoEFcfzIjMq+/eZLLuTgi9sl8RkkmufxUcORFEdiB DAyw== MIME-Version: 1.0 X-Received: by 10.60.220.227 with SMTP id pz3mr3389282oec.13.1443640460510; Wed, 30 Sep 2015 12:14:20 -0700 (PDT) Received: by 10.202.65.5 with HTTP; Wed, 30 Sep 2015 12:14:20 -0700 (PDT) In-Reply-To: <560A0643.7050800@igel.co.jp> References: <1440013341-29659-1-git-send-email-rkerur@gmail.com> <1440013376-29715-1-git-send-email-rkerur@gmail.com> <55D53655.1040808@igel.co.jp> <55D69C00.2020609@igel.co.jp> <560A0643.7050800@igel.co.jp> Date: Wed, 30 Sep 2015 12:14:20 -0700 Message-ID: From: Ravi Kerur To: Tetsuya Mukawa Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] Change rte_eal_vdev_init to update port_id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2015 19:14:21 -0000 Hi Tetsuya, On Mon, Sep 28, 2015 at 8:32 PM, Tetsuya Mukawa wrote: > On 2015/09/24 6:22, Ravi Kerur wrote: > > Hi David, Tetsuya, > > > > I have sent V3 (changes isolated to rte_ether component) for formal > review. > > Please look into it and let me know your inputs. > > Hi Ravi, > > I've checked the patch. > I guess your patch is good. > > > > > @David: I looked at "rte_eth_dev_get_port_by_name()", this function is > > similar to "rte_eth_dev_get_name_by_port" and I have used same logic. Let > > me know if this not correct I can fix both. > > Do you comment about rte_eth_dev_get_port_by_name and > rte_eth_dev_get_port_by_addr? > If so, I guess we don't need to merge. > > I just mentioned that new functions are using same logic as existing function. Thanks, Ravi > > Thanks, > > Ravi > > > > > > On Tue, Sep 15, 2015 at 4:28 AM, Ravi Kerur wrote: > > > >> Hi David, > >> > >> > >> On Thu, Sep 3, 2015 at 7:04 AM, David Marchand < > david.marchand@6wind.com> > >> wrote: > >> > >>> Hello Ravi, Tetsuya, > >>> > >>> On Tue, Aug 25, 2015 at 7:59 PM, Ravi Kerur wrote: > >>> > >>>> Let us know how you want us to fix this? To fix rte_eal_vdev_init and > >>>> rte_eal_pci_probe_one to return allocated port_id we had 2 approaches > >>>> mentioned in earlier discussion. In addition to those we have another > >>>> approach with changes isolated only to rte_ether component. I am > attaching > >>>> diffs (preliminary) with this email. Please let us know your inputs > since > >>>> it involves EAL component. > >>>> > >>> - This patch looks like a good ethdev cleanup (even if it really lacks > >>> some context / commit log). > >>> > >>> I wonder just why you only take the first part of the name in > >>> rte_eth_dev_get_port_by_name(). > >>> Would not this match, let's say, both toto and toto0 vdevs ? > >>> Is this intended ? > >>> > >>> It was not intended, i will look into it. > >>> - In the end, with this patch, do we still need to update eal ? > >>> Looking at the code, I am not sure anymore. > >>> > >> Approach 3 (preliminary diffs sent as an attachment) doesn't involve EAL > >> but the other two solutions do. So please let us know which one you > prefer. > >> I will send updated patch. > >> > >> Thanks, > >> Ravi > >> > >> > >>> > >>> > >>> -- > >>> David Marchand > >>> > >> > >