From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
 [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id CB4CF5938
 for <dev@dpdk.org>; Mon,  5 Jan 2015 17:21:50 +0100 (CET)
Received: by mail-pa0-f53.google.com with SMTP id kq14so29058181pab.40
 for <dev@dpdk.org>; Mon, 05 Jan 2015 08:21:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=WpRVnu9Ow99DujWkSSuIvICfoNELWfLw49FDsgs5J1I=;
 b=fwAkDl2nSWdW91jCRfaS9Pa2XZpBhoDDF6aiP6zgaY4QAmeCFnOBdQHQbj5V4hgiZy
 macOUXOYX55i+S/dMcDTCIxVYQoSEhJbwCGa0UOhMhYNKZZR8AsWdBSUOLJ67+oiY5Tk
 AR4j1aTFLq90tCa3J544bOEtlRwdEg2Z1e/1YrsD1q2DNK9UfaNyLUN5GL2wddW+vHq0
 0vqbm/psLmPOPGWfzgKSTFIi0dtgXG9Nhakzfx2ejBtccopzg7n12IxKGYAUb+yRJmiu
 ED6cZ0TH2ZSvDPv90IG7XaMsfgNMCCrySUFMya4gSXWqRdVgXiF6et5tRQpfJIFmB4OY
 3kTQ==
MIME-Version: 1.0
X-Received: by 10.66.166.171 with SMTP id zh11mr148529754pab.85.1420474909949; 
 Mon, 05 Jan 2015 08:21:49 -0800 (PST)
Received: by 10.70.114.233 with HTTP; Mon, 5 Jan 2015 08:21:49 -0800 (PST)
In-Reply-To: <20293089.lIc3yRvdMZ@xps13>
References: <1419521597-31978-1-git-send-email-rkerur@gmail.com>
 <1419521597-31978-5-git-send-email-rkerur@gmail.com>
 <20293089.lIc3yRvdMZ@xps13>
Date: Mon, 5 Jan 2015 08:21:49 -0800
Message-ID: <CAFb4SLCeAF-p9hx7ULMqMuzB-4L+L9QVWoF_UuUuwxp=RBLcJA@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/7] Move EAL common functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jan 2015 16:21:51 -0000

Thanks Thomas for the reviews, do you want me to send "v4" version of this
patch series or start a different patch series?

Thanks,
Ravi

On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> 2014-12-25 10:33, Ravi Kerur:
> > Move common functions in eal.c to librte_eal/common directory.
> [...]
> >  lib/librte_eal/common/eal_common.c    | 328
> ++++++++++++++++++++++++++++++++++
> >  lib/librte_eal/common/eal_externs.h   |  42 +++++
>
> I don't agree with these new files.
> We must try to keep a semantic organization. The file eal_common_options.c
> would be better for option-related functions.
> Maybe that the split between system config, runtime config and internal
> config
> must be reworked.
>
> By the way, it would be nice to avoid extern variables.
>
> --
> Thomas
>