From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id CC94C5A74 for ; Thu, 22 Jan 2015 01:03:47 +0100 (CET) Received: by mail-pd0-f175.google.com with SMTP id fl12so19873482pdb.6 for ; Wed, 21 Jan 2015 16:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=b9RO8vxJDCNlerxW92eXR5YznzZnpXRsIGZFGNV4tg0=; b=NGyANviiaR5I8HJqLmbC+NH7PoT1T6Y5fC1rozDciFSz4193ANjUOOMfbyhNIGE/vC aQR5hlgpIusJrXoUayg4kNnPxJ3g1XaMCrFEt1446RaOIdExMWlfjLS9ALA6HPTnHYw2 x/EZaas+cDGA7jUDYquoiWtBxdUYpKEu8SNeFkI2WL4H8H3UksRVnENfdHBEIldXBx/+ ykvvECpdK0Mxgu6Jj1eygOIT3lJzgfOOKAm/Sn5Q8EVH99d7ufrW7J5J4dKzY3OstO6L ZK9O47waMWMW8VS3I2wWuxJItvuG4O+4cQCHYU9UXqfRphxjrVQmY7CBzcuINjQrO90W sOsQ== MIME-Version: 1.0 X-Received: by 10.70.140.167 with SMTP id rh7mr67339739pdb.108.1421885027031; Wed, 21 Jan 2015 16:03:47 -0800 (PST) Received: by 10.70.91.166 with HTTP; Wed, 21 Jan 2015 16:03:46 -0800 (PST) In-Reply-To: <2601191342CEEE43887BDE71AB977258213DB45B@irsmsx105.ger.corp.intel.com> References: <3180122.JKDOmAPjoA@xps13> <2601191342CEEE43887BDE71AB977258213D5104@irsmsx105.ger.corp.intel.com> <20150116105255.GA10516@bricha3-MOBL3> <2601191342CEEE43887BDE71AB977258213DA3B9@irsmsx105.ger.corp.intel.com> <20150116113140.GD10516@bricha3-MOBL3> <2601191342CEEE43887BDE71AB977258213DB45B@irsmsx105.ger.corp.intel.com> Date: Wed, 21 Jan 2015 16:03:46 -0800 Message-ID: From: Ravi Kerur To: "Ananyev, Konstantin" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 00:03:48 -0000 Intel team, Please let me know what additional testing needs to be done for I217/I218? I have confined changes only to _osdep_ files and have done basic testing with testpmd utility. Since DPDK PMD driver supporting e1000e has been available for quite sometime, I have assumed basic testing for Tx/Rx packets should suffice. Thanks, Ravi On Fri, Jan 16, 2015 at 4:01 AM, Ananyev, Konstantin < konstantin.ananyev@intel.com> wrote: > > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Friday, January 16, 2015 11:32 AM > > To: Ananyev, Konstantin > > Cc: Ravi Kerur; Thomas Monjalon; dev@dpdk.org > > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. > > > > On Fri, Jan 16, 2015 at 11:08:46AM +0000, Ananyev, Konstantin wrote: > > > > > > > > > > -----Original Message----- > > > > From: Richardson, Bruce > > > > Sent: Friday, January 16, 2015 10:53 AM > > > > To: Ananyev, Konstantin > > > > Cc: Ravi Kerur; Thomas Monjalon; dev@dpdk.org > > > > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel > chipsets. > > > > > > > > On Thu, Jan 15, 2015 at 11:54:52PM +0000, Ananyev, Konstantin wrote: > > > > > Hi, > > > > > > > > > > > -----Original Message----- > > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur > > > > > > Sent: Thursday, January 15, 2015 8:34 PM > > > > > > To: Thomas Monjalon > > > > > > Cc: dev@dpdk.org > > > > > > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel > chipsets. > > > > > > > > > > > > On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon < > thomas.monjalon@6wind.com> > > > > > > wrote: > > > > > > > > > > > > > 2015-01-09 04:41, Ravi Kerur: > > > > > > > > Thomas, > > > > > > > > > > > > > > > > Please let me know how I can move forward on this. If i > confine changes > > > > > > > in > > > > > > > > e1000/ directory to e1000_osdep.h file only and the rest in > PMD will that > > > > > > > > work? The reason I ask is because of following comment in > README file. > > > > > > > > > > > > > > > > ... > > > > > > > > Few changes to the original FreeBSD sources were made to: > > > > > > > > - Adopt it for PMD usage mode: > > > > > > > > e1000_osdep.c > > > > > > > > e1000_osdep.h > > > > > > > > ... > > > > > > > > > > Yes, if needed you can modify these files. > > > > > In fact, these files are the only 2 that are allowed to be > modified inside e1000 sub-directory. > > > > > As I understand you plan to implement E1000_READ_FLASH_REG and > E1000_WRITE_FLASH_REG > > > > > macros properly, correct? > > > > > Konstantin > > > > > > > > > > > > > As a cleanup we should really look to move these two files out of > the e1000 > > > > subdirectory (and similarly for the ixgbe versions etc.), so as to > give a cleaner > > > > and more manageable separation between what can be edited or not. > > > > > > It was always like that for all Intel PMDs we have: > > > > > > $ find lib/ -name '*_osdep.*' | grep -v acl > > > lib/librte_pmd_vmxnet3/vmxnet3/vmxnet3_osdep.h > > > lib/librte_pmd_ixgbe/ixgbe/ixgbe_osdep.h > > > lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_osdep.h > > > lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h > > > lib/librte_pmd_i40e/i40e/i40e_osdep.h > > > lib/librte_pmd_e1000/e1000/e1000_osdep.c > > > lib/librte_pmd_e1000/e1000/e1000_osdep.h > > > > > > As I understand ND has it's own version of _osdep.* for each > OS they support. > > > We obviously modify it to fit DPDK purposes. > > > > > > Konstantin > > > > > > > > > > > /Bruce > > > > Yep. Doesn't mean we haven't put it in the wrong place though! :-) > > We just don't move it at all :) > It is at the same place where ND puts it, we just modify the contents. > From my point - current location is perfectly ok. > Konstantin > > > > > /Bruce >