From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 41B425684 for ; Fri, 9 Jan 2015 13:41:50 +0100 (CET) Received: by mail-pd0-f182.google.com with SMTP id p10so17289566pdj.13 for ; Fri, 09 Jan 2015 04:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lN+h6d8htuljqLjx5sETVyGKjrmx/ng0YTHkpykLcvI=; b=NtDHDI5v3F/zKfWNhyDUbf3GPQb5CuvPJ2ndB9+qy2cUFFuxLtVnY0sBcc97MZ9hZq BhDFXLIeUS0YX+Oqo8zrpxF1hBRWPNPz0Oa/QacuKY/iOZv3uUcMUZafjuCCuFFCDKZT xzmM6ucNc/vgNsrkWsFWF3PVjIyQmOdxKziEcRUkk1hOKP9wmCSaQO/991PwjTO9uD6o xxR4FHOxnqid/4xuFqAn14C3riuF/0zPANwjpiEQHBHT9v0SQMQMRP0HZz9Z/H93YLyb WV1JMs6JnNiOJsOPetBsIAe6zXVLSJiaM3W7RRBairWvSUAozgu6INPDms1Jo6Tb7POz t56Q== MIME-Version: 1.0 X-Received: by 10.70.44.132 with SMTP id e4mr23569531pdm.58.1420807308947; Fri, 09 Jan 2015 04:41:48 -0800 (PST) Received: by 10.70.114.233 with HTTP; Fri, 9 Jan 2015 04:41:48 -0800 (PST) In-Reply-To: References: <1475634.GuJD5gSMru@xps13> Date: Fri, 9 Jan 2015 04:41:48 -0800 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jan 2015 12:41:51 -0000 Thomas, Please let me know how I can move forward on this. If i confine changes in e1000/ directory to e1000_osdep.h file only and the rest in PMD will that work? The reason I ask is because of following comment in README file. ... Few changes to the original FreeBSD sources were made to: - Adopt it for PMD usage mode: e1000_osdep.c e1000_osdep.h ... Thanks. On Mon, Jan 5, 2015 at 8:40 AM, Ravi Kerur wrote: > Inline > > On Mon, Jan 5, 2015 at 12:55 AM, Thomas Monjalon < > thomas.monjalon@6wind.com> wrote: > >> 2015-01-04 15:28, Ravi Kerur: >> > We have a Gigabyte H97N motherboard which has I217 Intel chipset which >> uses >> > e100e drivers. I looked into lib/librte_pmd_e1000 directory and I do see >> > that e1000e code is integrated but missing some support for read/write >> from >> > flash_address and other minor things. I have made changes shown below >> and >> > have done some testing with testpmd utility and now have following >> questions >> > >> > 1. What amount of testing is required to qualify patch as successfully >> > tested on new chipsets >> >> There is no good answer to this question. Generally, you must be sure that >> you don't break anything. >> So you must test the code paths you have changed. >> > > yes I have done testing on Ubuntu for I217 using testpmd. > >> >> > 2. FreeBSD testing, currently we have Ubuntu 14.04 installed on existing >> > H97N motherboard and testing is done solely on Linux. We plan to get >> > another motherboard which will have I218 chipset and still deciding >> whether >> > to go with FreeBSD or Ubuntu. So the question I have is what amount of >> > testing should be done on FreeBSD? I don't think >> setup.sh/dpdk_nic_bind.py >> > works on FreeBSD yet hence the question on testing. >> >> FreeBSD testing is required when patching common EAL, scripts or >> makefiles. >> >> > > lib/librte_pmd_e1000/e1000/e1000_api.c | 21 >> +++++++++++++++++++++ >> > > lib/librte_pmd_e1000/e1000/e1000_api.h | 1 + >> > > lib/librte_pmd_e1000/e1000/e1000_osdep.h | 24 >> +++++++++++++++++++----- >> >> These files are part of the base driver. >> The rule is to not patch them and try to do the changes in PMD only. >> There can be exceptions if an Intel maintainer acknowledges it. >> > > Changes in these files are modifying existing macros > > E1000_READ_FLASH_REG, > E1000_WRITE_FLASH_REG > ... > > If it is not recommended to modify these files, should I move macros into > some PMD file? > > Thanks. > >> >> -- >> Thomas >> > >