From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2
Date: Mon, 19 Jan 2015 14:07:49 -0800 [thread overview]
Message-ID: <CAFb4SLCtmq_4Sz6+zU-x0wGdViEadBqS33un0F5sWVxo94SvJA@mail.gmail.com> (raw)
In-Reply-To: <CAFb4SLBf+PTwOwstD6LBzTimF08pcycWsSP5+pHNuT+_6kZRew@mail.gmail.com>
Looks like "make test" was added recently? I have "1.8.0" version and when
I run "make test" after "make install T=x86_64-native-linuxapp-gcc" I get
following errors
root@user-PC:/home/rkerur/dpdk-new-5/dpdk# make test
No test found, please do a 'make build' first, or specify O=
root@user-PC:/home/rkerur/dpdk-new-5/dpdk#
However, When I pull latest code (as of 1/19) and follow same steps as
above I see "make test" runs fine but there are 19 failures as shown
below. Any other prerequisites needed for this test to run successfully. If
it is documented and can be shared, it will really help new contributors to
not make same mistake I did.
root@user-PC:/home/rkerur/dpdk-new-6/dpdk# make test
/home/rkerur/dpdk-new-6/dpdk/build/app/test -c f -n 4
Test name Test result Test
Total
================================================================================
Start group_1: Fail [No prompt] [00m 00s]
Timer autotest: Fail [No prompt] [00m 00s]
Debug autotest: Fail [No prompt] [00m 00s]
Errno autotest: Fail [No prompt] [00m 00s]
Meter autotest: Fail [No prompt] [00m 00s]
Common autotest: Fail [No prompt] [00m 00s]
Dump log history: Fail [No prompt] [00m 00s]
Dump rings: Fail [No prompt] [00m 00s]
Dump mempools: Fail [No prompt] [00m 00s] [00m
00s]
Start group_2: Success [00m 00s]
Memory autotest: Success [00m 00s]
Read/write lock autotest: Success [00m 00s]
Logs autotest: Success [00m 00s]
CPU flags autotest: Success [00m 00s]
Version autotest: Success [00m 00s]
EAL filesystem autotest: Success [00m 00s]
EAL flags autotest: Fail [00m 09s]
Hash autotest: Success [00m 00s] [00m
12s]
Start group_3: Success [00m 00s]
LPM autotest: Success [00m 23s]
IVSHMEM autotest: Fail [Not found] [00m 00s]
Memcpy autotest: Success [00m 00s]
Memzone autotest: Success [00m 00s]
String autotest: Success [00m 00s]
Alarm autotest: Success [00m 16s] [00m
54s]
Start group_4: Success [00m 00s]
PCI autotest: Fail [00m 00s]
Malloc autotest: Success [00m 00s]
Multi-process autotest: Fail [00m 01s]
Mbuf autotest: Success [00m 27s]
Per-lcore autotest: Success [00m 05s]
Ring autotest: Success [00m 02s] [01m
31s]
Start group_5: Success [00m 00s]
Spinlock autotest: Success [00m 15s]
Byte order autotest: Success [00m 00s]
TAILQ autotest: Success [00m 00s]
Command-line autotest: Fail [00m 00s]
Interrupts autotest: Success [00m 11s] [01m
59s]
Start group_6: Success [00m 00s]
Function reentrancy autotest: Success [00m 00s]
Mempool autotest: Fail [00m 00s]
Atomics autotest: Success [00m 00s]
Prefetch autotest: Success [00m 00s]
Red autotest: Success [01m 40s] [03m
40s]
Start group_7: Success [00m 00s]
PMD ring autotest: Fail [00m 00s]
Access list control autotest: Success [00m 00s]
Sched autotest: Success [00m 00s] [03m
42s]
Start kni: Success [00m 00s]
KNI autotest: Fail [Crash] [00m 00s] [03m
43s]
Start mempool_perf: Success [00m 00s]
Cycles autotest: Success [00m 01s]
Mempool performance autotest: Fail [00m 00s] [03m
45s]
Start memcpy_perf: Success [00m 00s]
Memcpy performance autotest: Success [00m 50s] [04m
37s]
Start hash_perf: Success [00m 00s]
Hash performance autotest: Success [01m 05s] [05m
43s]
Start power: Success [00m 00s]
Power autotest: Success [00m 00s] [05m
44s]
Start power_acpi_cpufreq: Success [00m 00s]
Power ACPI cpufreq autotest: Success [00m 00s] [05m
45s]
Start power_kvm_vm: Success [00m 00s]
Power KVM VM autotest: Fail [00m 00s] [05m
46s]
Start lpm6: Success [00m 00s]
LPM6 autotest: Fail [00m 00s] [05m
47s]
Start timer_perf: Success [00m 00s]
Timer performance autotest: Success [00m 11s] [05m
59s]
Start ring_perf: Success [00m 00s]
Ring performance autotest: Success [00m 04s] [06m
04s]
================================================================================
Total run time: 06m 04s
Number of failed tests: 19
On Mon, Jan 19, 2015 at 9:07 AM, Ravi Kerur <rkerur@gmail.com> wrote:
> Sorry for the inconvenience. I was not aware of "make test" utility which
> does more elaborate testing. I will make a note of it and make sure future
> patches will go through it. I had done basic testing with testpmd as the
> changes were minimal.
>
> Thanks,
> Ravi
>
> On Mon, Jan 19, 2015 at 1:13 AM, Thomas Monjalon <
> thomas.monjalon@6wind.com> wrote:
>
>> 2015-01-19 08:21, David Marchand:
>> > On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin <helin.zhang@intel.com>
>> wrote:
>> >
>> > > It seems that your fix result in cannot launching applications.
>> > > I don't suspect the correction of your fix, but somewhere else needs
>> to be
>> > > corrected together with your fix.
>> > >
>> > > Logs:
>> > > /************************************************************
>> > > RING: Cannot reserve memory for tailq
>> >
>> > I have a quick fix for this one (rte_malloc_socket refuses 0 alignment),
>> > but looking at the change, I would say there are a lot of places to be
>> > checked.
>> > Were those places checked during review ?
>>
>> http://dpdk.org/browse/dpdk/commit/?id=2fc8d6daa4c7a
>> This case demonstrates that an Acked-by line is not always sufficient
>> to apply a patch.
>>
>> > Kerur, did you run a make test ?
>> > All tests fail for me because of rte_malloc_socket.
>>
>> My dream would be to have a machine receiving patches, applying them in a
>> sandbox,
>> run some basic tests and reports failures.
>>
>> It should be fixed now:
>> http://dpdk.org/browse/dpdk/commit/?id=8e3e06501660
>>
>> --
>> Thomas
>>
>
>
next prev parent reply other threads:[~2015-01-19 22:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 15:28 Ravi Kerur
2014-12-27 15:30 ` Ravi Kerur
2014-12-27 20:49 ` Neil Horman
2015-01-15 13:12 ` Thomas Monjalon
2015-01-19 2:45 ` Zhang, Helin
2015-01-19 7:21 ` David Marchand
2015-01-19 9:13 ` Thomas Monjalon
2015-01-19 9:30 ` Qiu, Michael
2015-01-19 9:49 ` David Marchand
2015-01-19 10:02 ` Qiu, Michael
2015-01-19 10:07 ` Qiu, Michael
2015-01-19 17:07 ` Ravi Kerur
2015-01-19 22:07 ` Ravi Kerur [this message]
2015-01-19 9:14 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFb4SLCtmq_4Sz6+zU-x0wGdViEadBqS33un0F5sWVxo94SvJA@mail.gmail.com \
--to=rkerur@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).