From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f53.google.com (mail-pg0-f53.google.com [74.125.83.53]) by dpdk.org (Postfix) with ESMTP id 645FA2B88 for ; Sat, 4 Mar 2017 21:47:52 +0100 (CET) Received: by mail-pg0-f53.google.com with SMTP id 187so604909pgb.3 for ; Sat, 04 Mar 2017 12:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DxWvf81+Q1ut69lji6+5acCj6T8mVtH/rMgNPYaxX0s=; b=n8xHKs4ep6HaHxwOIqX/atZyKjuNyY3WHHcZ4rUo7RmBW8T/q7hh8Nrqt5ConYLGCC +VIGkmFKRRLN7sHEBZOsUkj7CGfVaKZmwN5znYoOfwZ4AsvCZNf9LHZCCGbT1u3hvCZO VXjGwUqNYppS8ZecZVD4YH8JqBGqquMItUMQK48DIlOY7ENUzRFAs60xRbsjUokXt/Gh XltrxjZ6LMWiPTWLAwkoLKBeVTwkzbepXYqNgiMNrlek1xJkePPdS1IX/p4M+IWo42dc EBGQKdaWEuUKb93zPxIQLP+dxfxLXw3IAbhTlRCX9nWYXXIO/NP5pL71kXTSBon3PdGK yZKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DxWvf81+Q1ut69lji6+5acCj6T8mVtH/rMgNPYaxX0s=; b=HwERHgX6gAkeUo0UYk4aUtCQuE/IJfI4gfVmJy3xMBvJFUHFQe7WtUn9cir5YpvVKV oOjh0W2mXBN7u9pga8Iej4dBTFAd41GvTe9tfnsIjQFJtX/F/REKYb0di9O9pveqs5PZ 2l426FT3xOu5eqt3Ou376S/xiWqpmlawWozEnc49k8Q9VnZv32InfYC68PrD8RROq3nI 8BE6mZSfRJFHBCSh+bIO3ehNCYgWSsfUphhb3uzgxyk+JjhIcnRT6djWpCfxtMJ1h1gz s3EsbPau5Zzs9rqwrJ8wf+/8y0dAEHpRUjX5rzAhhRJY2bkbpPOcCfAdXSul9kw8pOuD JQiA== X-Gm-Message-State: AMke39mQyIMdnCKI8IdIh9/R88EvbkGCts2hZ8uZ89ZKnt0OzRTp8BSMR98mqG/OvyWI/VFczun0CRd4TnzPsg== X-Received: by 10.99.114.66 with SMTP id c2mr10900073pgn.4.1488660471727; Sat, 04 Mar 2017 12:47:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.128.202 with HTTP; Sat, 4 Mar 2017 12:47:51 -0800 (PST) In-Reply-To: References: <1485550795-10771-1-git-send-email-rkerur@gmail.com> <2601191342CEEE43887BDE71AB9772583F11EA2A@irsmsx105.ger.corp.intel.com> From: Ravi Kerur Date: Sat, 4 Mar 2017 12:47:51 -0800 Message-ID: To: "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Richardson, Bruce" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 20:47:52 -0000 Hi Konstantin, Sorry for this one, I had to resend patch series as 'v3' as additional checkpatch warnings were seen after the submission which didn't show up in my run. 'v3' patch should have all fixed except the ones I mentioned in my earlier email on which I need inputs from you. Thanks. On Sat, Mar 4, 2017 at 11:49 AM, Ravi Kerur wrote: > Hi Konstantin, > > I have sent 'v2' patchset. I need clarifications on following things, if > they should be fixed I will send out 'v3' so please let me know. > > Following code changes were done by me manually, not merged. > +++ b/examples/l3fwd/main.c > @@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf = { > .rx_adv_conf = { > .rss_conf = { > .rss_key = NULL, > - .rss_hf = ETH_RSS_IP, > + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | > + ETH_RSS_TCP | ETH_RSS_SCTP, > + > }, > > The reason I did it is because > > LPM/EM has .rss_hf = ETH_RSS_IP > ACL has .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP | ETH_RSS_SCTP, > > ACL looks like a superset of LPM/EM and functional testing didn't reveal > any issues hence I kept ACL version. > > 2. Checkpatch errors are all fixed. Some warnings are not fixed and they > are > > 2.a, string length greater than 80 characters > 2.b GET_CB_FIELD macro. I could have changed GET_CB_FIELD to inline > function, however, function names cannot be in capital letters. I could > have changed it to 'get_cb_field' inline function, but didn't do it as I > thought it may not be worth the change. > > Let me know your inputs. > > Thanks. > > On Wed, Mar 1, 2017 at 7:29 AM, Ravi Kerur wrote: > >> Hi Konstantin, >> >> Thank you for the review. >> >> RSS hash value changes could be due to merge, I didn't make that change. >> I will go through the changes and fix it in 'v2' patch along with RFC >> removed and checkpatch fix. >> >> Thanks. >> >> On Tue, Feb 28, 2017 at 2:36 AM, Ananyev, Konstantin < >> konstantin.ananyev@intel.com> wrote: >> >>> Hi Ravi, >>> >>> > >>> > Thanks to Konstantin and Bruce on first internal review comments. This >>> > patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file >>> > read options to build LPM and EM tables. >>> >>> >>> Thanks for the patch, I think it is really useful one. >>> Can I suggest you re-submit it as non-RFC now, as we are in 17.05 window >>> already? >>> About the patch itself, one question I forgot to ask you before: >>> >>> +++ b/examples/l3fwd/main.c >>> @@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf = { >>> .rx_adv_conf = { >>> .rss_conf = { >>> .rss_key = NULL, >>> - .rss_hf = ETH_RSS_IP, >>> + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | >>> + ETH_RSS_TCP | ETH_RSS_SCTP, >>> + >>> }, >>> }, >>> >>> >>> Why it is necessary to change RSS hash input values? >>> >>> As another nit - there are few checkpatch warnings, that probably need >>> to be addressed. >>> Apart from that looks good to me. >>> Thanks >>> Konstantin >>> >>> >>> >> >