From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 2EAB758DD for ; Tue, 6 Jan 2015 18:32:05 +0100 (CET) Received: by mail-pa0-f48.google.com with SMTP id rd3so31294412pab.7 for ; Tue, 06 Jan 2015 09:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=FLNdN9SwD93TbvQZZ9ZBJXU3WeEtUxadxbgtLk7qin4=; b=RKLaVCNJn/I2f2qOmsVovdne9BpdmyS0xDItsdIfF2uShsHQeWrWXL6/WI7nZZzsez i3ovbRBnkrjtTF4yCCa/PqQ3n07xKK3I9UDpsdezjyZs4gCOzDR7ijKCfJkGgMQ+0uMi Yubse72tglYq45m7xghrb08w7oouXqEdUjXC0RIMZxtYiIIJHDuOAWBSvWYA/pK35o0F TZWtopHrwmi+0BZzwyopV7B2Yf7nGs1krd6mZf32c3GyEPezTIaSSCTJC6dIjUGBQY6w bm4LR2NS39PbExEwGs3GOoJcvG91fT0KE+6BS8oYRiw31QhF2rR2ISoAg4FPwufXM4MA bpVA== MIME-Version: 1.0 X-Received: by 10.68.191.101 with SMTP id gx5mr159344593pbc.108.1420565523787; Tue, 06 Jan 2015 09:32:03 -0800 (PST) Received: by 10.70.114.233 with HTTP; Tue, 6 Jan 2015 09:32:03 -0800 (PST) In-Reply-To: <5340807.22YuSvaAXs@xps13> References: <1419957384-11693-1-git-send-email-rkerur@gmail.com> <1419957440-11767-1-git-send-email-rkerur@gmail.com> <1419957440-11767-6-git-send-email-rkerur@gmail.com> <5340807.22YuSvaAXs@xps13> Date: Tue, 6 Jan 2015 09:32:03 -0800 Message-ID: From: Ravi Kerur To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 6/6] Move common functions in eal_memory.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2015 17:32:05 -0000 I have added wrapper function for BSD. On Mon, Jan 5, 2015 at 1:17 PM, Thomas Monjalon wrote: > 2014-12-30 11:37, Ravi Kerur: > > Use common function names rte_eal_hugepage_init and > > rte_eal_hugepage_attach for BSD and Linux. > > I'd like to be sure that using hugepage wording instead of contigmem > is not too weird for BSD people. > Do not forget that we have a kernel module called contigmem. > Here, an ifdef or a wrapper seems appropriate to keep right wording. > > -- > Thomas >