From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f181.google.com (mail-yw0-f181.google.com [209.85.161.181]) by dpdk.org (Postfix) with ESMTP id E707D2BDF for ; Wed, 1 Mar 2017 16:29:24 +0100 (CET) Received: by mail-yw0-f181.google.com with SMTP id p77so34316573ywg.1 for ; Wed, 01 Mar 2017 07:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=W+ChetQaKyOZgS6yhizjSX+QmSRkjZPw5lPvOSicpSQ=; b=IIbEkBroW/wHEQ7XItz3g0dk+HA1tCj8S2XCtB8f3pNitassejFVys32lVVDNlAzu3 69E81k6we1mAYXDeogt4SREqfhWMTqy8Ygd2j5hHK0FjaJyn3ur9EbopkWWGAlw66nQB 46Dap2zawPegfXmV0w3FlgQoUnUBJExF16cd1406QNMWVxYCOAJot6kcEWmlUrkro7LS rD8BH5jIJTuvPjcvTqeld/d5udAVvgACbsg057gXAjOwW8TBGCQV0BPOf5TrdaWUwiLK WwximVh3oxlxwA9FlDSUBBQWKOORjg9tToObUKjsVALwNNfVJljdfXO/cuWIscAFv4PA B7HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=W+ChetQaKyOZgS6yhizjSX+QmSRkjZPw5lPvOSicpSQ=; b=CY1OuIj/i2G4wOUQ7T08qPesF6g89TlT6dsejuQqy7J6q8tnjTUBYzvEWg4PNBM2BS JXXh9KqJih+TlQG5ZKYEggF0dz/hIXHtFltiAnyh+oqWH+lFz8Ed8XNq/I6AYJ1LDTI+ sLNL+BiPudktEsjSnEK36sEpi20p+Q6m+44VyAQLxG6Mk3oHhVP+cWxsi2UgkcDAm1eF YyrWnZ1BPl8u63P1xS3DcbsYNV32zE3tuKif2wNEDn+rz6YqvKfi1+XhwTDla1sIa8OR nwl20b5fDDU1SZR3o0QSCs88AxWXEqSrXb/yg8LuxmshGz19SWL3QPr1MxsKUDdPd1Tj CcYg== X-Gm-Message-State: AMke39m8g62vEdomwAMloFx8dPiyXK0FtfBiwysHQGkPdyd9pjYu3CATnAwNOM/Avr6top/378jn9K0rwkKvaQ== X-Received: by 10.13.193.68 with SMTP id c65mr3331713ywd.88.1488382163954; Wed, 01 Mar 2017 07:29:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.8.66 with HTTP; Wed, 1 Mar 2017 07:29:23 -0800 (PST) In-Reply-To: <2601191342CEEE43887BDE71AB9772583F11EA2A@irsmsx105.ger.corp.intel.com> References: <1485550795-10771-1-git-send-email-rkerur@gmail.com> <2601191342CEEE43887BDE71AB9772583F11EA2A@irsmsx105.ger.corp.intel.com> From: Ravi Kerur Date: Wed, 1 Mar 2017 07:29:23 -0800 Message-ID: To: "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Richardson, Bruce" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 15:29:25 -0000 Hi Konstantin, Thank you for the review. RSS hash value changes could be due to merge, I didn't make that change. I will go through the changes and fix it in 'v2' patch along with RFC removed and checkpatch fix. Thanks. On Tue, Feb 28, 2017 at 2:36 AM, Ananyev, Konstantin < konstantin.ananyev@intel.com> wrote: > Hi Ravi, > > > > > Thanks to Konstantin and Bruce on first internal review comments. This > > patch is RFC for 17.05 to merge l3fwd-acl and l3fwd code and add file > > read options to build LPM and EM tables. > > > Thanks for the patch, I think it is really useful one. > Can I suggest you re-submit it as non-RFC now, as we are in 17.05 window > already? > About the patch itself, one question I forgot to ask you before: > > +++ b/examples/l3fwd/main.c > @@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf = { > .rx_adv_conf = { > .rss_conf = { > .rss_key = NULL, > - .rss_hf = ETH_RSS_IP, > + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | > + ETH_RSS_TCP | ETH_RSS_SCTP, > + > }, > }, > > > Why it is necessary to change RSS hash input values? > > As another nit - there are few checkpatch warnings, that probably need > to be addressed. > Apart from that looks good to me. > Thanks > Konstantin > > >