From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com
 [209.85.218.49]) by dpdk.org (Postfix) with ESMTP id 08FF7C43A
 for <dev@dpdk.org>; Thu, 30 Jul 2015 14:15:01 +0200 (CEST)
Received: by oibn4 with SMTP id n4so20684895oib.3
 for <dev@dpdk.org>; Thu, 30 Jul 2015 05:15:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=pzreK4mbOwsQQyTML8UIJtz/OCOGYzboQLsp/xB4OFo=;
 b=ddez2UqmepaCcAJc3T4kHoqNTEMeqonlAt3NXdBxwa6rj3HoOlKouHD1z43dBNsKt0
 g8q1RKGn+2LO1J+2XAmrM6Bcw0ypwngIhQfO/L1WB4J2TWyFxzuFS5DiCxFXHsh6MW5A
 jb/MflAEHGS+AMY80RaWrCTCA+fBpTIM4iPjJSv9y+z3AmmJUyGdxKwItmg0F+rpUMbH
 yk8rCpq4ZQvzl6SV/9Uy6l/oG7+4DYfIdQsG4mPjJ5k1qIvtpkJ1bfN8uBuvwvaR97Vq
 5ruxRrCYvOUcO8f2QGtJN6aEQODuc3ZJUx8OH+Tpsfv8y61gEaAoYZ2F3RLsPcoMOYNJ
 ZiCg==
MIME-Version: 1.0
X-Received: by 10.202.220.65 with SMTP id t62mr43935462oig.115.1438258500435; 
 Thu, 30 Jul 2015 05:15:00 -0700 (PDT)
Received: by 10.202.179.195 with HTTP; Thu, 30 Jul 2015 05:15:00 -0700 (PDT)
In-Reply-To: <55B9DC6F.7040506@6wind.com>
References: <1437852868-6031-1-git-send-email-rkerur@gmail.com>
 <1437958594-29468-1-git-send-email-thomas.monjalon@6wind.com>
 <3055506.vZLM2IGfDr@xps13> <55B9DC6F.7040506@6wind.com>
Date: Thu, 30 Jul 2015 05:15:00 -0700
Message-ID: <CAFb4SLDSa74utLrEAMKuxuNMBJsZJk6gQP51=NkXnw-LJKBn7A@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v10 0/3] deduplicate EAL common functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2015 12:15:01 -0000

Hi Olivier,


On Thu, Jul 30, 2015 at 1:12 AM, Olivier MATZ <olivier.matz@6wind.com>
wrote:

> Hi Thomas & Ravi,
>
>
> On 07/27/2015 02:59 AM, Thomas Monjalon wrote:
>
>> 2015-07-27 02:56, Thomas Monjalon:
>>
>>> v9 was a subset of previous deduplications by Ravi Kerur.
>>> This v10 address the comments I've done on v9.
>>>
>>> Ravi Kerur (3):
>>>    eal: deduplicate lcore initialization
>>>    eal: deduplicate timer functions
>>>    eal: deduplicate memory initialization
>>>
>>
>> Applied shortly to integrate this old pending cleanup in RC2.
>>
>>
> When I try to compile the dpdk for x86_x32-native-linuxapp-gcc , I
> get the following compilation error:
>
>   CC eal_common_timer.o
> In file included from /usr/include/sys/sysctl.h:63:0,
>                  from /home/matz/dpdk-pkg-cron/
> dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
> /usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is
> unsupported in x32 kernel"
>  # error "sysctl system call is unsupported in x32 kernel"
>    ^
>
> Removing the "#include <sys/sysctl.h>" line fixes the issue without
> impacting the compilation. I think this include is not needed and
> could be removed.
> I can provide a patch if it's ok for you.
>
>
If it compiles fine on FreeBSD then it should be fine. It primarily needed
for eal_timer.c in FreeBSD environment, during code movement it slipped
through my mind. Sorry for the inconvenience.

Thanks,
Ravi


> Regards,
> Olivier
>
>