From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f42.google.com (mail-oi0-f42.google.com [209.85.218.42]) by dpdk.org (Postfix) with ESMTP id BFAC83775 for ; Wed, 13 May 2015 22:08:17 +0200 (CEST) Received: by oign205 with SMTP id n205so40294118oig.2 for ; Wed, 13 May 2015 13:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2ZRdEhabAVlY9A+TJo0q52dX07DusD/Ac5UKn4ZlcnQ=; b=w9yf6wIykmVNWpIluKmL6Ih/TXdwkl9KR3uj7+/GONOHNFobX2vdqYnetiKnsBH0ST WPPiTi7J9D66Sk2ONHU7aOprFhys8Bn6XnZ9oOFRbNbtWH+rLXvtsQpnmPcFoxZRIXXD CFXHLMQSMzV8xp6xH5oCBUVwcMGyhmJKZ1Rjb+/NE1j7ja7Zv1zR7alvNS6m/SalgEDC iU/pMTe6z2dHL2jemCEnqJ0L6bvFoZCixowNmtoqQfXvRL4rn4enWE+KaU4KNm2AcAQT auRgCrUAZksXKUVxUrIICjL8HHAEkFbsuMva/YJNXfbpprjKtsyTH6B+ngeT1ppUC8tf GC4w== MIME-Version: 1.0 X-Received: by 10.182.20.146 with SMTP id n18mr532256obe.76.1431547697337; Wed, 13 May 2015 13:08:17 -0700 (PDT) Received: by 10.202.179.195 with HTTP; Wed, 13 May 2015 13:08:17 -0700 (PDT) In-Reply-To: <20150513090353.GC12276@bricha3-MOBL3> References: <1431119989-32124-1-git-send-email-rkerur@gmail.com> <2601191342CEEE43887BDE71AB9772582142E106@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772582142E44A@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772582142E475@irsmsx105.ger.corp.intel.com> <20150513090353.GC12276@bricha3-MOBL3> Date: Wed, 13 May 2015 13:08:17 -0700 Message-ID: From: Ravi Kerur To: Bruce Richardson Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , Don Provan Subject: Re: [dpdk-dev] [PATCH v2] Implement memcmp using AVX/SSE instructions. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2015 20:08:18 -0000 On Wed, May 13, 2015 at 2:03 AM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Tue, May 12, 2015 at 06:16:20PM -0700, Ravi Kerur wrote: > > On Mon, May 11, 2015 at 3:29 PM, Don Provan wrote: > > > > > I probably shouldn't stick my nose into this, but I can't help myself. > > > > > > An experienced programmer will tend to ignore the documentation for > > > a routine named "blahblah_memcmp" and just assume it functions like > > > memcmp. Whether or not there's currently a use case in DPDK is > > > completely irrelevant because as soon as there *is* a use case, some > > > poor DPDK developer will try to use rte_memcmp for that and may or > > > may not have a test case that reveals their mistake. > > > > > > > In general I agree with you. However, comparison is a hit(equal) or > > miss(unequal) is generally the case in networking. I haven't seen cases > > where "less than" or "greater than" has mattered. > > > > > Agreed that == and != are the common operations. However, if that is what > is returned from the function - and given other limitations on parameter > sizes - > I agree with previous posters that this function needs to have a different > name > to rte_memcmp so as to avoid confusion. > I will be implementing complete memcmp itself, so probably I will retain same name. > > /Bruce > >