From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rkerur@gmail.com>
Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com
 [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id B872C5A8C
 for <dev@dpdk.org>; Tue, 31 Mar 2015 01:15:13 +0200 (CEST)
Received: by pdbni2 with SMTP id ni2so601397pdb.1
 for <dev@dpdk.org>; Mon, 30 Mar 2015 16:15:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=/VkH8FOj3jwBJ933ZsVvfCuIat78BdhhxUGiq8ax0yY=;
 b=lB/ox62nTDRC/pP1Ndb5AkuwzdAcvB+AOrI0K3mvRHC04J8bC4VtbpG0ijHJCkcKNV
 2m+Ik+usI6XAKRt6Up5yBixOmsyAxZ9zeoGZkUaJnLnWuTGe7m3ar+jWxiqO41MKjmF7
 rXKDiPXb3iuqihzUqBkHbSFfcPzheyEBBspsm2MOafWazY4iRJCY5Qu5kAHljttlvzBi
 6OuEQGwVjjkPixtF2XiY/uSIzSDkHQr8AYHnXz6PfcjOCc6sZ9T6eJiHhcxSPbeVMnTj
 vK+B4Ye3pydM5WajtVOOzM/UWw/gtWl5Bp12xeY9g4tXnDDmDjDaHwHpvp5C/G+s72ti
 k6Yw==
MIME-Version: 1.0
X-Received: by 10.68.223.36 with SMTP id qr4mr62219064pbc.50.1427757312887;
 Mon, 30 Mar 2015 16:15:12 -0700 (PDT)
Received: by 10.70.131.3 with HTTP; Mon, 30 Mar 2015 16:15:12 -0700 (PDT)
In-Reply-To: <1722908.xonNXe7smH@xps13>
References: <1420565095-17278-1-git-send-email-rkerur@gmail.com>
 <1722908.xonNXe7smH@xps13>
Date: Mon, 30 Mar 2015 16:15:12 -0700
Message-ID: <CAFb4SLDdn3ULTOJJi_r58RWWqrKWKV3CpzX00KazPtEFUu+3mw@mail.gmail.com>
From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 0/7] Move EAL common function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Mar 2015 23:15:14 -0000

Hi Thomas,

Sure, please let me know when it is needed I can work on it.

Thanks,
Ravi

On Mon, Mar 30, 2015 at 2:29 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> Hi Ravi,
>
> 2015-01-06 12:24, Ravi Kerur:
> > Fix v3 PATCH review comments from Thomas.
> > eal_common.c is further split into eal_common_system.c and
> > eal_common_runtime.c files with appropriate functions.
> > eal_externs.h file is removed and _get_ and _set_ APIs are
> > used to access variables.
> > Functions with same signature in Linux and BSD but different
> > names are kept intact but Linux function name is used as
> > wrapper for BSD.
> > Added eal_pci.c in v4 PATCH.
> > New files added follow _common_ naming conventions.
> > Tested against Ubuntu and FreeBSD.
> >
> > Ravi Kerur (7):
> >   Move common functions in eal_debug.c
> >   Move common functions in eal_thread.c
> >   Move common functions in eal.c
> >   Move common functions in eal_lcore.c
> >   Move common functions in eal_timer.c
> >   Move common functions in eal_memory.c
> >   Move common functions in eal_pci.c
>
> Sorry for not integrating this big refactoring in release 2.0.
> It wasn't easy to merge it during development of some EAL features.
> And it's now too risky to rework it before the release.
> I think this clean-up is needed and should be done at the beginning of 2.1
> cycle. We just need to rebase it and remove the "ifdef BSD/LINUX" which was
> introduced in pci code.
>
> Do you think you'll have time for it?
>
> Thanks
>