From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9DCB6A0A0C;
	Thu,  8 Apr 2021 20:02:11 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 067051411A7;
	Thu,  8 Apr 2021 20:02:11 +0200 (CEST)
Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com
 [209.85.167.48])
 by mails.dpdk.org (Postfix) with ESMTP id E41261411A3;
 Thu,  8 Apr 2021 20:02:08 +0200 (CEST)
Received: by mail-lf1-f48.google.com with SMTP id b14so5483471lfv.8;
 Thu, 08 Apr 2021 11:02:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=KIKrvBtllRck0sJs1tNuogLOHBLK2fRFcSf1HcyXJco=;
 b=C8R4sN/gMwNePSQvY4/a9FzkzXMviWfJSdFlVORsQK+lNkZuVCHvWpqZMjMAco3d9n
 RcqotAx5P7GMs9CxvbvzOpZh+v0vKQ6xx3VdPho34ZLDhe85uxxoKFVY6+xvfx3WFqLc
 eqdKA527o8kg6RpwevK4RjbzI+WlawwY6c1H7ay4gZezfH41TEvih7CgFQ5wrgkrdwQe
 Pc9njD4W0EYCM2sd6vnQlKSowxadESVYLg94tAqFA1sBgyb+xLiFoEMxvovJH6MqvpQe
 vHEZA/SCk5omwjmH4E6zeCk4dDMi5Xx76N+hJfa6kosXg53rU+Ip+cgR+8BaKonLgM4m
 T6VQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=KIKrvBtllRck0sJs1tNuogLOHBLK2fRFcSf1HcyXJco=;
 b=HFVPiUQlomJ6UONUYsXCoNk+hWF3MA05pjSBEvtmBu+sGHOiK4N6OMNM+GdFDOyllI
 3hoMvD2XxsRVoM0AW7LsLOtGGeLA+MC7rsL7e3QWYFHFJAYCXtJEZBKX2byHlp1NJQOR
 /XCgK5I6R9mVshzoVl8tmbeFwmosA0pJzJFHkXEAGQvuIDd7neHuLnW6bx5YEhoaq4im
 s/pPzNgKR5htq5e5FAW0UIfgyljgPfefqOb8Rfn6SprVOcDHboh2hAVXn3y4JeLhs0/8
 j3hxM97aL35swd9ihh/wnzJYGVgy3ajWdnUEKBP2MUG7tsgQgwMVb5IWL1Se+zrl2P1h
 roEg==
X-Gm-Message-State: AOAM533DhTlH+vhNLfwVXkW2TSYcaeMO3I+0kSOxhvpJZUHYBtt2BMgs
 QwPq/qv0PX1gMXN2k/umxEjcDuPjlFQ2WVm/vB8=
X-Google-Smtp-Source: ABdhPJwj5aKWi7xngCkrK4WaT0f3kwo55PX3e5yQCQOjOi4Mc82EjhkN48t0f5D9AhT769RvPX4TUgQH6GIThR1Y5/Y=
X-Received: by 2002:a05:6512:2243:: with SMTP id
 i3mr7847521lfu.537.1617904928405; 
 Thu, 08 Apr 2021 11:02:08 -0700 (PDT)
MIME-Version: 1.0
References: <DBAPR08MB581490C7F81791C485E062F698759@DBAPR08MB5814.eurprd08.prod.outlook.com>
 <20210407201603.149234-2-lucp.at.work@gmail.com>
 <20210408142013.GA1650@platinum>
In-Reply-To: <20210408142013.GA1650@platinum>
From: Luc Pelletier <lucp.at.work@gmail.com>
Date: Thu, 8 Apr 2021 14:01:57 -0400
Message-ID: <CAFeRdtAxti3JnEB2MGHVhSkQvB0oaRE3PdYQ-+_NoCKdk1Bx7Q@mail.gmail.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: jianfeng.tan@intel.com, Honnappa.Nagarahalli@arm.com, dev@dpdk.org, 
 stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation
 error logic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Thank you for these 2 fixes. Note the the title of your patches do not
> contain the version (should have been v8?). I don't know how critical
> it is for commiters.

Thanks Olivier. I'll admit that I wasn't sure if I should version the
patches after splitting the original. I opted not to but it seems like
I should have. If it's a problem, please let me know and I'll repost
them with 'v8'.

Le jeu. 8 avr. 2021 =C3=A0 10:20, Olivier Matz <olivier.matz@6wind.com> a =
=C3=A9crit :
>
> Hi Luc,
>
> On Wed, Apr 07, 2021 at 04:16:06PM -0400, Luc Pelletier wrote:
> > The affinity of a control thread is set after it has been launched. If
> > setting the affinity fails, pthread_cancel is called followed by a call
> > to pthread_join, which can hang forever if the thread's start routine
> > doesn't call a pthread cancellation point.
> >
> > This patch modifies the logic so that the control thread exits
> > gracefully if the affinity cannot be set successfully and removes the
> > call to pthread_cancel.
> >
> > Fixes: 6383d26 ("eal: set name when creating a control thread")
> > Cc: olivier.matz@6wind.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Luc Pelletier <lucp.at.work@gmail.com>
>
> Thank you for these 2 fixes. Note the the title of your patches do not
> contain the version (should have been v8?). I don't know how critical
> it is for commiters.
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>