From: Robert Sanford <rsanford@prolexic.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] mk: fix pcap build with empty LIBPCAP_CFLAGS
Date: Fri, 6 Dec 2013 11:48:34 -0500 [thread overview]
Message-ID: <CAFmpvUMxpRdamv0sUpEF3RRktVArbCtMvdx3+fMWRANoJJPKJw@mail.gmail.com> (raw)
Fix pcap build - In rte.sdkbuild.mk with CONFIG_RTE_LIBRTE_PMD_PCAP=y,
we error-exit if LIBPCAP_CFLAGS is empty. On some distros (e.g., Centos
6.4),
it is normal for "pcap-config --cflags" to output only a newline, because
pcap
header files reside in /usr/include/.
Solution is to remove the line that checks whether LIBPCAP_CFLAGS is empty.
---
mk/rte.sdkbuild.mk | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index 33bed57..d9b6802 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -42,7 +42,6 @@ endif
ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
LIBPCAP_CFLAGS ?= $(shell pcap-config --cflags)
-$(if $(LIBPCAP_CFLAGS),,$(error LIBPCAP_CFLAGS is undefined))
EXTERNAL_LIB_CFLAGS += $(LIBPCAP_CFLAGS)
endif
--
1.7.1
Signed-off-by: Robert Sanford <rsanford@prolexic.com>
next reply other threads:[~2013-12-06 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 16:48 Robert Sanford [this message]
2013-12-10 9:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFmpvUMxpRdamv0sUpEF3RRktVArbCtMvdx3+fMWRANoJJPKJw@mail.gmail.com \
--to=rsanford@prolexic.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).