From: Robert Sanford <rsanford@prolexic.com>
To: Maxime Leroy <maxime.leroy@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Comments regarding Flow Director support in PMD IXGBE
Date: Fri, 10 Jan 2014 09:33:15 -0500 [thread overview]
Message-ID: <CAFmpvUN4n1+grrN-mVQP6jQLBEFyTq6AGCKLeeGPDfJahSAHVQ@mail.gmail.com> (raw)
In-Reply-To: <CAEykdvo5Qc0kUAsVoCCWyPApYsRD6SEXS_e=o_xiMPPoDdvmUQ@mail.gmail.com>
Hello Maxime,
Thank you for taking the time to research these flow director issues and a
more complete solution.
On Fri, Jan 10, 2014 at 8:36 AM, Maxime Leroy <maxime.leroy@6wind.com>
wrote:
> But it will be nice to have a small test with ipv6 traffic to be sure
> about this point.
>
> Would you like to provide a patch to remove this useless "if" please ?
>
> (Note: the set_ipv6_mask field of the input_mask structure need to be
> removed too)
...
> Thus I agree with your analyze, the fdir api is not coherent.
> I think all the parameters of the fdir api should be in network order.
...
> The testpmd application need to be updated in consequence to provide ip
mask
> in network order (in lib/librte_cmdline/cmdline.c):
...
> Would you like to provide and test a patch to fix this issue, please ?
Yes, we will do as you suggest:
1. Test with IPv6 traffic.
2. Make appropriate changes to flow director code and testpmd.
3. Update comments in the structure definitions to indicate byte order.
4. Provide the patch.
--
Regards,
Robert
prev parent reply other threads:[~2014-01-10 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 19:52 Robert Sanford
2014-01-10 13:36 ` Maxime Leroy
2014-01-10 14:33 ` Robert Sanford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFmpvUN4n1+grrN-mVQP6jQLBEFyTq6AGCKLeeGPDfJahSAHVQ@mail.gmail.com \
--to=rsanford@prolexic.com \
--cc=dev@dpdk.org \
--cc=maxime.leroy@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).