From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f196.google.com (mail-yb1-f196.google.com [209.85.219.196]) by dpdk.org (Postfix) with ESMTP id E2CD41B163 for ; Thu, 22 Nov 2018 03:33:00 +0100 (CET) Received: by mail-yb1-f196.google.com with SMTP id g192-v6so3034011ybf.3 for ; Wed, 21 Nov 2018 18:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dFvKNveNatNAKZslJruVsBGPGnNkaeI0IgG0rQDO+WM=; b=ZmXoCEZsZ1Nzfuw16r96sK1bfJEVobe8YKYBRfKqjufqRkaQQOAlr1LN7qqvo4R7lB 6k5KTRsapfTJVfx2UxMHfp9o5YOvAjY/Uuy1jC8zTzgtn+qRmtoLQhv9dXc/nc2a1NQf Ve6oEHlq3DUscxPOw/Svt0PF7FulfdkIG2BZ7ZJSQJH1JR81Km+FTbVgVY71iTAeqf24 pOIvspakQkP8j1RE7tN8Y33wPax47kbwcR+yzd7GWMB+SJ2n0Q3+ES6mY6Sy4qv+Rkbf 7WAv3EvvWGxsDbwpOAQIoVFtvVhqe9SlBhEp67ufArdgPkH1lPH/K7nM9+kEgi1DYXV9 Wr6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dFvKNveNatNAKZslJruVsBGPGnNkaeI0IgG0rQDO+WM=; b=cmiEEqxn6WQ6Bwly0O3i2ZuSZUOR2jZYcuOXzeYAL+IEVlxRSTWN4T9BGBYjSVOYPD 16IPrbZqeZSpqBrhovQ3BVsciH0W03DjuMmYfLji9mBI8NxGFcPI4xElXp+E2RNKX+We h2OvvWrfAMKzpMqjKA7/boqoJIAclGwE5bddS1a8nB5pFvA082l4qQCMF6WtaHHLhKmj Hmb7eVACMqNJ3RHCQ05/i0208/JJRKeaaDQwy5sBLkb5NnOCxu//nWv5DW8R9fdG2imU LDYTc5V1BKJZz1TmVdEsWCdrVkakbb8COKnrnvHz0bbbQi72pn6QeX3Iz6lbwIJz7ftE ucmQ== X-Gm-Message-State: AA+aEWadOh+IvdFQ1DniyTs+gXEEbf4sMnjwKItQA6pMmuODr057bFob BXID4bpHi9TEOSzTbqyygYtoepHEPJq+OpfdSao= X-Google-Smtp-Source: AFSGD/UZTQBWVV2JY0hCvZsOCqJ9DzVChnBuez5LflARDz1V2PSsgbTfotuBxga3G+a+sdc4QcdbsLl1Y91yF+VIoK0= X-Received: by 2002:a5b:8cd:: with SMTP id w13-v6mr9396652ybq.428.1542853980356; Wed, 21 Nov 2018 18:33:00 -0800 (PST) MIME-Version: 1.0 References: <20181121131127.28528-1-wanlebing@didichuxing.com> <219e09d4-5516-b297-3e85-d4078e55a2fd@intel.com> In-Reply-To: <219e09d4-5516-b297-3e85-d4078e55a2fd@intel.com> From: =?UTF-8?B?5LiH5LmQ5Yaw?= Date: Thu, 22 Nov 2018 10:32:46 +0800 Message-ID: To: ferruh.yigit@intel.com Cc: dev@dpdk.org, konstantin.ananyev@intel.com, wanlebing Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix memory leak on removing eth rxtx callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 02:33:01 -0000 cc konstantin.ananyev konstantin.ananyev, please help. Ferruh Yigit =E4=BA=8E2018=E5=B9=B411=E6=9C=8821= =E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=8810:48=E5=86=99=E9=81=93=EF=BC= =9A > On 11/21/2018 1:11 PM, wanlebing wrote: > > eth rxtx callback is dynamically allocated using rte_zmalloc() > > but not released. Fix it by calling rte_free() to free callback > > when removing rxtx callback. > > I guess they are not freed intentionally because there is no safe way to > do it. > I remember Konstantin sent an RFC in the past to rework the callbacks, > cc'ed him > for more details. > > > > > Signed-off-by: wanlebing > > Signed-off-by: wanlebing > > --- > > lib/librte_ethdev/rte_ethdev.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/librte_ethdev/rte_ethdev.c > b/lib/librte_ethdev/rte_ethdev.c > > index 5f858174b..f00311047 100644 > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > @@ -3926,6 +3926,7 @@ rte_eth_remove_rx_callback(uint16_t port_id, > uint16_t queue_id, > > if (cb =3D=3D user_cb) { > > /* Remove the user cb from the callback list. */ > > *prev_cb =3D cb->next; > > + rte_free(cb); > > ret =3D 0; > > break; > > } > > @@ -3960,6 +3961,7 @@ rte_eth_remove_tx_callback(uint16_t port_id, > uint16_t queue_id, > > if (cb =3D=3D user_cb) { > > /* Remove the user cb from the callback list. */ > > *prev_cb =3D cb->next; > > + rte_free(cb); > > ret =3D 0; > > break; > > } > > > >