From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-io0-f195.google.com (mail-io0-f195.google.com [209.85.223.195]) by dpdk.org (Postfix) with ESMTP id 620FF1EFAB for ; Sun, 10 Jun 2018 03:35:22 +0200 (CEST) Received: by mail-io0-f195.google.com with SMTP id l19-v6so20058658ioj.5 for ; Sat, 09 Jun 2018 18:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mecDYWXekFhRhvKuz6Qqcac5SKDsmiKrBllwMZcvTrI=; b=JOF4+hcLIzqhkdfl9akShT9aQTOjMkU071s4UazyJhBvRxG79nFIKexnY892MFpi4r TB9AXN/Caa7SSyvPk1iL/OXWEYKb6bxiyPgVxpRODcesFS35mVD3ELtrmBnJUusGQ4P7 Aa7k/XcmWm1EBgIGO9IEMIpKiwLtpEei3CLSTiBT5Dju5ohvwU9vsECwIYXs7T63j08c en4DraWSP/47zPHLjLXeogmWeh4xZEfjBjwaUxy6D0GPm0bMEg5+JaqJr6k6cdGL7D9Y eKf2AzY4AYhrEIsS9TcFN8P+JynmE6mf3XZ7I4EDbpNxvSpnsa/hf00y0np4r5x3N02D SNYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mecDYWXekFhRhvKuz6Qqcac5SKDsmiKrBllwMZcvTrI=; b=sAMy4IULTvO+SBm8cAtAZ0IE8AEC+Mzrlir4Ch+08K6nvthqzQD/cQjZElh30rrxXd hprrb/xeiuVYvfeNfcgvIpTPK/iaXFtJaR1e45MgR5KSEUIFldf0+ZurPGLSf7C8Li7s bMzuxTNWbJlUYQtO9+XUA+UnN8vYD/clO+o08NAZdcvjywmCqFdY5C9KIgg17b4MOoTW 2g9lC5TqqSgAt2hzn233DsCOFpqFJvIEA1hYuFF0cAWoxMh+woKQhuqgS2CfUMHGzjH9 dk6Vq7YyuNfFbG03f6fQhaz8slth4ftXa8k+2dxLDhH+RHemNaZdNTCMZYz/eGQA3GMJ bksA== X-Gm-Message-State: APt69E2NAXLwRRmEVkaWEMwoxq61Q/DVda/iZmjlqq1sHaeGAsmo6f4q 9vWe0kDyA8ZN+VHj3Bo/ULQ7Md/qkLBn6jAsN00= X-Google-Smtp-Source: ADUXVKL9B1EHhwRhOiY9CBzirVZukBEvyZ9CWaIc3UA/++FYj5BEocJizCX9ctmum9B/hsKVJ6PD4Jb3oI87j+k7MTE= X-Received: by 2002:a6b:8267:: with SMTP id e100-v6mr10141868iod.110.1528594521797; Sat, 09 Jun 2018 18:35:21 -0700 (PDT) MIME-Version: 1.0 References: <20180607094322.14312-1-mk@semihalf.com> <20180607094322.14312-27-mk@semihalf.com> In-Reply-To: From: Chas Williams <3chas3@gmail.com> Date: Sat, 9 Jun 2018 21:35:10 -0400 Message-ID: To: Ferruh Yigit Cc: mk@semihalf.com, mw@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, dev@dpdk.org, matua@amazon.com, rk@semihalf.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 27/27] net/ena: set link speed as none X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2018 01:35:22 -0000 On Fri, Jun 8, 2018 at 3:37 PM Ferruh Yigit wrote: > On 6/7/2018 10:43 AM, Michal Krawczyk wrote: > > From: Rafal Kozik > > > > Link speed should is not limited to 10Gb/s and it shouldn't be hardcoded. > > > > They link speed is set to none instead and the applications shouldn't > > rely on this value when using ENA PMD. > > Why not able to set link speed? > > And what is the link_autoneg, ETH_LINK_FIXED? What is the point of setting > link > speed FIXED and later speed value NONE? > The link speed is part of the spanning tree path computation. I don't think picking 0 (or undefined) is the appropriate choice. For virtual interfaces link speed is a troublesome quantity but advertising undefined seems worse then just use some constant value. > > > > > Fixes: 1173fca ("ena: add polling-mode driver") > > For next time can you please use git alias to have consistent Fixes format > > > > > Signed-off-by: Rafal Kozik > > Acked-by: Michal Krawczyk > > --- > > drivers/net/ena/ena_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > > index 5c3b6494f..9ae73e331 100644 > > --- a/drivers/net/ena/ena_ethdev.c > > +++ b/drivers/net/ena/ena_ethdev.c > > @@ -848,7 +848,7 @@ static int ena_link_update(struct rte_eth_dev *dev, > > adapter = (struct ena_adapter *)(dev->data->dev_private); > > > > link->link_status = adapter->link_status ? ETH_LINK_UP : > ETH_LINK_DOWN; > > - link->link_speed = ETH_SPEED_NUM_10G; > > + link->link_speed = ETH_SPEED_NUM_NONE; > > link->link_duplex = ETH_LINK_FULL_DUPLEX; > > > > return 0; > > > >