From: Chas Williams <3chas3@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bonding: set dev_started later
Date: Thu, 14 Jun 2018 16:22:58 -0400 [thread overview]
Message-ID: <CAG2-Gk=m1Okzo7vODGNQCLf_y8adcHaVF4AJbtHcHNS6w5JHcw@mail.gmail.com> (raw)
In-Reply-To: <adca357c-d922-65f6-8435-9b85775622e5@intel.com>
No. This was fixed by
net/bonding: clear started state if start fails
There are several error paths where the bonding device may not start.
Clear dev_started before we return if we take one of these paths.
Fixes: 2efb58cbab6e ("bond: new link bonding library")
Cc: stable@dpdk.org
Signed-off-by: Chas Williams <chas3@att.com>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
which was less clumsy attempt at the fix.
On Thu, Jun 14, 2018 at 1:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 3/16/2018 4:34 PM, Chas Williams wrote:
> > From: "Charles (Chas) Williams" <chas3@att.com>
> >
> > There are several error paths where the bonding device may not start.
> > Don't set dev_started until we know that we are sure start is going
> > to succeed.
> >
> > Fixes: 2efb58cbab ("bond: new link bonding library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Chas Williams <chas3@att.com>
>
> Hi Chas,
>
> Is this patch still valid to consider for v18.08?
>
>
prev parent reply other threads:[~2018-06-14 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 16:34 Chas Williams
2018-03-23 17:05 ` [dpdk-dev] [PATCH v2] net/bonding: clear dev_started if start fails Chas Williams
2018-04-05 10:58 ` Radu Nicolau
2018-04-06 10:03 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-06-14 17:10 ` [dpdk-dev] [PATCH] net/bonding: set dev_started later Ferruh Yigit
2018-06-14 20:22 ` Chas Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG2-Gk=m1Okzo7vODGNQCLf_y8adcHaVF4AJbtHcHNS6w5JHcw@mail.gmail.com' \
--to=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).