From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <3chas3@gmail.com>
Received: from mail-it0-f67.google.com (mail-it0-f67.google.com
 [209.85.214.67]) by dpdk.org (Postfix) with ESMTP id DDA241DC98;
 Thu, 14 Jun 2018 22:23:09 +0200 (CEST)
Received: by mail-it0-f67.google.com with SMTP id j135-v6so74338itj.1;
 Thu, 14 Jun 2018 13:23:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=rIma/6cX6q/rqh2Zd72Tlu4XGpQmqcpArnbR3XNCn4s=;
 b=s/1/TV+GoV7ll8FHBiTB502YUU5CUC5lsxSPZdReAIf1vIA6LFidCFjp1zV0URaEXx
 Ym2HujhdIA5zxx0AdEv+2Pu9XkAsm9jnLOkCMUdR12BRLdrym4370CuwOE/+VuTPxoDj
 XCE3ujddIbKkyhVMRWecw6bhzymBkUMtIeSEanO5TpwBvzq2GEyEt7RHczMhxplmYy7j
 pLuw46aKoYhJxQHtFKJeTIbQVuqwhUXnt00iiS5JTPpQOIEygBmORUZ8RvrRx9k+GSKS
 H/ahTk2W4GTM3RYpP5FPc8/QOY++lszsGBgsm1qi2scABAHsL/zqiC+CuNLMrjkanxC/
 CalQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=rIma/6cX6q/rqh2Zd72Tlu4XGpQmqcpArnbR3XNCn4s=;
 b=fLbBbS2EZxZy9/a2lJC9WHnkSZO2QHycFg9jHYfXTHDUJvqVaW/WU8MaS/Tji6nL9r
 lu5O4YKabDWV0giIOZcOjbYMA0EcWR75HJq8jE/nLI8XolBtbhhL3VjunDSwORS9caRh
 dfrhAu9bHvEezBWBVGBiJwBGgTOr89JBl6Psm5EaMfw+LiKaonVvKL11dDtrNj9gU6iG
 zd9/mai2WZjyHxeak+FUA70kLtmWE40WONdbyX3Mb+0+5KCvNvNyeIejNshN7krwQU0b
 SzmWhuKhOtOWlNT7m6N1gtC6h2jpkKx1u41Irw48H4MOi82RFuooLbkn+J0trUNUVFcl
 TRww==
X-Gm-Message-State: APt69E04ZmTzEdmOcgNxfnlHQPemYXgg8teToPpSLtW55hVCJAB+s6+w
 7EZ59FvEOe2yT7CJShU9YPPeAB970VblNk8t2lg=
X-Google-Smtp-Source: ADUXVKLFZlng6WoQWHKSn0iL9FuuC5OqKp4jApONCbry5tcMegLrprYjLcgwstclsIWPeMFJJ5QtTkPXvOGN82BCwH4=
X-Received: by 2002:a24:3a49:: with SMTP id
 m70-v6mr3638251itm.84.1529007789263; 
 Thu, 14 Jun 2018 13:23:09 -0700 (PDT)
MIME-Version: 1.0
References: <20180316163441.31898-1-3chas3@gmail.com>
 <adca357c-d922-65f6-8435-9b85775622e5@intel.com>
In-Reply-To: <adca357c-d922-65f6-8435-9b85775622e5@intel.com>
From: Chas Williams <3chas3@gmail.com>
Date: Thu, 14 Jun 2018 16:22:58 -0400
Message-ID: <CAG2-Gk=m1Okzo7vODGNQCLf_y8adcHaVF4AJbtHcHNS6w5JHcw@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>,
 Chas Williams <chas3@att.com>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] net/bonding: set dev_started later
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 20:23:10 -0000

No.  This was fixed by

    net/bonding: clear started state if start fails

    There are several error paths where the bonding device may not start.
    Clear dev_started before we return if we take one of these paths.

    Fixes: 2efb58cbab6e ("bond: new link bonding library")
    Cc: stable@dpdk.org

    Signed-off-by: Chas Williams <chas3@att.com>
    Acked-by: Radu Nicolau <radu.nicolau@intel.com>

which was less clumsy attempt at the fix.

On Thu, Jun 14, 2018 at 1:10 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 3/16/2018 4:34 PM, Chas Williams wrote:
> > From: "Charles (Chas) Williams" <chas3@att.com>
> >
> > There are several error paths where the bonding device may not start.
> > Don't set dev_started until we know that we are sure start is going
> > to succeed.
> >
> > Fixes: 2efb58cbab ("bond: new link bonding library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Chas Williams <chas3@att.com>
>
> Hi Chas,
>
> Is this patch still valid to consider for v18.08?
>
>