From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-it0-f65.google.com (mail-it0-f65.google.com [209.85.214.65]) by dpdk.org (Postfix) with ESMTP id 2084B271 for ; Thu, 7 Dec 2017 01:00:29 +0100 (CET) Received: by mail-it0-f65.google.com with SMTP id m11so22333880iti.1 for ; Wed, 06 Dec 2017 16:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o9+MTV1qQWAl7wWPPpQsoNM0y/ytMj1W0qYvOzXr5Ug=; b=Jqt1BW9MZxC5m8HiWVCguoNDI7OCX2naix2HPVqcue0GJYNc5b9DJgk6gvPSwKZ3KF QjfOzfoRSFhIVeJxnd0yTp2WnbOaHgZk8epwpr8qEP0KQcaCX5TaLrWloNNPR1Dtg/U+ DM1kXTolyi6GuHt6rcSJeqm7oxfsxmdEgSFWUes8ZgJccCj8Zim7z6HllVSh2TC4Qiss 5jJWhgMG2m3RSZkIgRicp38a3l6PZCxAb+hbbTbEzXaMA6+nahkbDZ7DIca3YnscHyKt Rl6BgL9eKiC7VtgCLJYP1duYOrTMMkicSwbfXtNOCwnbACECncRx9+LZvw9AZaH72hEL yXMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o9+MTV1qQWAl7wWPPpQsoNM0y/ytMj1W0qYvOzXr5Ug=; b=H2fJkv1N+dp1exjO+QZeutaY94mNWveXOO40BqCxAUxXzfY/jymJ8o9svliJ1OUT6Y VKjE43tnnbO5qJ3mvaeUHengNGjY3aQe867k3Lqj9sZ1RgVQIOcws1unSUIQM+eAxwrv KZJ3Gz45P7bUx+QJty32JoCOKPktxpdShvu/LNsVmqhQmhPh8e5qw+d5bkhXiOkLHEgB 2MzkbdlwTQHgG2wwbwddiGRWNzSHc4L6uekQZEB3f+Mys7NKHn/m+3fTMST92vYm7GjV Y6wPeleBPd+BmCHHsPiazTSAlyDWfbxIPhZ0ZkvmkrYhZY6GCRTByIYCC+Ek+zmHIEL3 E9JQ== X-Gm-Message-State: AKGB3mKEo4ZrY67sVL8lMA3nEVzsawjQBErJ3LRKjB8VI3JVya93jHHf JOEEq9eDW9+DJpplP8IMay68o6FKWW4nyVoJro4= X-Google-Smtp-Source: AGs4zMbgFBqehRh72wIPVcaynYH4TWTA5APZQ2qt3UG2HmB6XU3enn27DPjWCEkofkDB/8c4OjFHxsy/mtng/KoS7t4= X-Received: by 10.36.108.83 with SMTP id w80mr15974784itb.3.1512604828208; Wed, 06 Dec 2017 16:00:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.2.5 with HTTP; Wed, 6 Dec 2017 16:00:27 -0800 (PST) In-Reply-To: <20171206235528.29746-1-3chas3@gmail.com> References: <20171206235528.29746-1-3chas3@gmail.com> From: Chas Williams <3chas3@gmail.com> Date: Wed, 6 Dec 2017 19:00:27 -0500 Message-ID: To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/e1000: add minimum support for Broadcom 54616 PHY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 00:00:29 -0000 Sorry, sent this to the wrong maintainer initially. I am cc'ing the Broadcom bnxt maintainers in hopes that they might comment about the 54616 behavior on reset. I couldn't find any programmer guide for this chip online but PHYs are typically well behaved. This patch does work on our test system. On Wed, Dec 6, 2017 at 6:55 PM, Chas Williams <3chas3@gmail.com> wrote: > From: "Charles (Chas) Williams" > > If we find a Broadcom 54616, handle as a e1000_phy_none assuming that > the NIC reset has initialized the PHY to a sane state. > > Signed-off-by: Chas Williams > --- > drivers/net/e1000/base/e1000_82575.c | 5 +++++ > drivers/net/e1000/base/e1000_defines.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/drivers/net/e1000/base/e1000_82575.c > b/drivers/net/e1000/base/e1000_82575.c > index c6400bd..3bcb6da 100644 > --- a/drivers/net/e1000/base/e1000_82575.c > +++ b/drivers/net/e1000/base/e1000_82575.c > @@ -312,6 +312,9 @@ STATIC s32 e1000_init_phy_params_82575(struct > e1000_hw *hw) > phy->ops.set_d3_lplu_state = e1000_set_d3_lplu_state_82580; > phy->ops.force_speed_duplex = e1000_phy_force_speed_duplex_ > m88; > break; > + case BCM54616_E_PHY_ID: > + phy->type = e1000_phy_none; > + break; > default: > ret_val = -E1000_ERR_PHY; > goto out; > @@ -1607,6 +1610,8 @@ STATIC s32 e1000_setup_copper_link_82575(struct > e1000_hw *hw) > case e1000_phy_82580: > ret_val = e1000_copper_link_setup_82577(hw); > break; > + case e1000_phy_none: > + break; > default: > ret_val = -E1000_ERR_PHY; > break; > diff --git a/drivers/net/e1000/base/e1000_defines.h > b/drivers/net/e1000/base/e1000_defines.h > index dbc2bbb..e2101c1 100644 > --- a/drivers/net/e1000/base/e1000_defines.h > +++ b/drivers/net/e1000/base/e1000_defines.h > @@ -1274,6 +1274,7 @@ POSSIBILITY OF SUCH DAMAGE. > #define I350_I_PHY_ID 0x015403B0 > #define I210_I_PHY_ID 0x01410C00 > #define IGP04E1000_E_PHY_ID 0x02A80391 > +#define BCM54616_E_PHY_ID 0x03625D10 > #define M88_VENDOR 0x0141 > > /* M88E1000 Specific Registers */ > -- > 2.9.5 > >