From: Chas Williams <3chas3@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Declan Doherty <declan.doherty@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Chas Williams <chas3@att.com>,
kiran.kokkilagadda@caviumnetworks.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers/bonding: fix bond mac address reset
Date: Thu, 14 Jun 2018 16:38:51 -0400 [thread overview]
Message-ID: <CAG2-GkmHr5EyFGJd-nLfecEikW-t8U9Yv106EoY8qLPqG-8QqQ@mail.gmail.com> (raw)
In-Reply-To: <fb0e95dc-762a-82bc-44c6-ba94e30b8ba5@intel.com>
On Thu, Jun 14, 2018 at 12:49 PM Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 5/23/2018 10:11 AM, Kiran Kumar wrote:
> > Currently when resetting bond mac address, we are getting the
> > persisted mac address from slave info considering primary port
> > as index. But we need to compare the port id from slave info
> > with the primary port to get the primary slave index and get
> > the persisted mac address. Without this fix, persisted mac addr
> > will be zero and rte_eth_dev_default_mac_addr_set will fail.
> >
> > Fixes: a45b288ef21a ("bond: support link status polling")
> >
> > Signed-off-by: Kiran Kumar <kiran.kokkilagadda@caviumnetworks.com>
>
> Hi Declan, Radu, Chas,
>
> If there is no objection, the patch will be merged as it is.
> Can you please check?
>
No objections. This patch looks correct.
>
> Thanks,
> ferruh
>
next prev parent reply other threads:[~2018-06-14 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 9:11 Kiran Kumar
2018-06-14 16:49 ` Ferruh Yigit
2018-06-14 20:38 ` Chas Williams [this message]
2018-06-15 13:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG2-GkmHr5EyFGJd-nLfecEikW-t8U9Yv106EoY8qLPqG-8QqQ@mail.gmail.com \
--to=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kiran.kokkilagadda@caviumnetworks.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).