From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) by dpdk.org (Postfix) with ESMTP id 2F5131DCBD for ; Thu, 14 Jun 2018 22:39:03 +0200 (CEST) Received: by mail-it0-f68.google.com with SMTP id 188-v6so96289ita.5 for ; Thu, 14 Jun 2018 13:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ymvL0bKRgDMZL+ZhmqydEUiS5mFINc4Aqf7AB3XWu/Y=; b=XcPLjTZrcVeqXDqv1K6pXaHV8BflRKscNJxgD690AjkyP57C1yJ9pyaX31UGm0NCnI uY/9ScWybZBYxpM8cXoEQRuL2QAa/vhiEn/YsspKOWTTquAwCEbVojAfAJweLydF6K/q mxOsPYdGMwEtDicbglTyAY6LB+Genlnm9Dy9NWELhK5XCVm6gK1ZJV4G4My3UhtbgK8L FtkyrCLFaTFjLzyxf2tk+zyZ+4AJ9CXrTCEN24HcIbYAqpBBHhaSd8X8Th6KT1FZf5lc 8kzEPbq2V+GxDRaI1RPyzwdv6NeJUUgDs/IiEpiPtHf1HSkE7cRXl+CeY9fsk6n04Hvo Qwjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ymvL0bKRgDMZL+ZhmqydEUiS5mFINc4Aqf7AB3XWu/Y=; b=njER82S4fY0vajhpeFMwdfScBxqQlP09nkjDqXaP8724HryPIxaqtqIZN7DMXlEFCZ LzYX9Dr8msYW3/V8mhCsP6bE9VnYX0xYilmrFrP++bW+vJV9L6pxmdKfIA0CILD+wje9 JpDtn65idygtJND5/uybZrvR+eedljM9UF8fhlrrGXvtDTeiQ2w0GaqUCprcoI/70yv+ BBLlfj2Ii3q0tvSIZRycCxBWEHPrAb7sIZ8t5j9IZTix4ELG0GhvlbhOXtcM804YWxpE HsqEqyO6vV5sgquwYSD7U1X2oU5CWV9oorvJSh8WFIAYLrVzrmlSRGPfMJ3rEKuY1aqd Knqg== X-Gm-Message-State: APt69E0qoJl0i/bsXeh4u2KNnkDkQb2qcfcHe3ehC2X23eoudj0j0deu ONvKbSkNocJQT0UMvkvFv9J2NSlG8NUKCdH7UNo= X-Google-Smtp-Source: ADUXVKJ6jWgAh5djFCH4GV3P+SGKgVj/BBBk+UAskf7XKVRB0tXisQkSEz6G5l8Bqn8PugncwhqdhmLHnSW/CcXotms= X-Received: by 2002:a24:8b81:: with SMTP id g123-v6mr3779797ite.67.1529008742599; Thu, 14 Jun 2018 13:39:02 -0700 (PDT) MIME-Version: 1.0 References: <20180523091121.9910-1-kiran.kokkilagadda@caviumnetworks.com> In-Reply-To: From: Chas Williams <3chas3@gmail.com> Date: Thu, 14 Jun 2018 16:38:51 -0400 Message-ID: To: Ferruh Yigit Cc: Declan Doherty , Radu Nicolau , Chas Williams , kiran.kokkilagadda@caviumnetworks.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] drivers/bonding: fix bond mac address reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 20:39:03 -0000 On Thu, Jun 14, 2018 at 12:49 PM Ferruh Yigit wrote: > On 5/23/2018 10:11 AM, Kiran Kumar wrote: > > Currently when resetting bond mac address, we are getting the > > persisted mac address from slave info considering primary port > > as index. But we need to compare the port id from slave info > > with the primary port to get the primary slave index and get > > the persisted mac address. Without this fix, persisted mac addr > > will be zero and rte_eth_dev_default_mac_addr_set will fail. > > > > Fixes: a45b288ef21a ("bond: support link status polling") > > > > Signed-off-by: Kiran Kumar > > Hi Declan, Radu, Chas, > > If there is no objection, the patch will be merged as it is. > Can you please check? > No objections. This patch looks correct. > > Thanks, > ferruh >