From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-it0-f68.google.com (mail-it0-f68.google.com [209.85.214.68]) by dpdk.org (Postfix) with ESMTP id 5DCCC3195; Thu, 19 Jul 2018 19:45:32 +0200 (CEST) Received: by mail-it0-f68.google.com with SMTP id v71-v6so11063101itb.3; Thu, 19 Jul 2018 10:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pts7W4uV5HvYADPd+3nt4mifn/3mRHPm4nqlM/Jcnus=; b=eOw1tekbwOe45R8GNqHdr6qCUtj97iw6jwLItJw4An7zpxyPvzh+4Mpxls//bQ+SD0 3VXjzE5Ma5Y881YPNa7O6gzf+J0h0QsqPQC4UEWNqWvpEiEWSpY9DUJkaNyh2fpy3yc5 cRwBaSghguy3FZhXk6jg5K9dOC/U2WaiR4JahWk3fNx8vCukZcz1M060HMPjwsym2p/g ffgjunzYKk2FVxJus9ZKLXmWe2FWWe0O65UrBFWn2WU8y/eWawm8j7t7U/gojLdtsQRY 51+TTz3YREFS6kRIHoBYZUBTaqTypzwSTIo6PRsHMv0+B6tXXFjHzhRxEfpjVnPHle5T CQXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pts7W4uV5HvYADPd+3nt4mifn/3mRHPm4nqlM/Jcnus=; b=H1K/8fKkaqyjgoJbZMzR+cFUlhByMwtqs4mHqAAihLxvRY2Ls3RoxNESM607UcwKyW 8+OtrILGZ1cUiwA2egGC4iIfBh8Vp4YpsBxsaCNHvAf7B0fZVAOShV93v9+eK25GsqM5 sRWAeatW6KxC82XAIx+YTgwsUxyUzEIqLXEg3lqYSiiLvVx7Ty54gs0FGNEkWG7qbPy4 C739epqEOdQosTmqTbYT0JFj0EcatQ4rCPixJO9sUFy1dG7w7eaitQ+M7+kaMPg1weZU TTizdi3AvljMFr3X8sgTejafDxggmEoWEb43DyLYTmZZL1tsOORXoP7L530Dn2kZSack GzuA== X-Gm-Message-State: AOUpUlGPDc+pn3krb311p9e6dOidldBfNsaN+0JHD/+HuLFGiCFB6R2h r4sRdtbo+p1K+EigRzZqpjLTDdVwbDWQm1BGs64= X-Google-Smtp-Source: AAOMgpdo2YtdiQv2uY/an86XD3znjE56DO+wMyYNEql8bcQiRQpPDKxIxxRSDc/BlK4/jw7yTe4mVhGc5LKHgndTMrQ= X-Received: by 2002:a02:982:: with SMTP id 2-v6mr10010291jam.79.1532022331714; Thu, 19 Jul 2018 10:45:31 -0700 (PDT) MIME-Version: 1.0 References: <1531912321-19544-1-git-send-email-radu.nicolau@intel.com> In-Reply-To: <1531912321-19544-1-git-send-email-radu.nicolau@intel.com> From: Chas Williams <3chas3@gmail.com> Date: Thu, 19 Jul 2018 13:45:20 -0400 Message-ID: To: Radu Nicolau Cc: dev@dpdk.org, Declan Doherty , Chas Williams , Thomas Monjalon , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix invalid port id error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 17:45:32 -0000 This seems fine. The bond PMD seems to call back into itself early. On Wed, Jul 18, 2018 at 7:19 AM Radu Nicolau wrote: > setting up the bonding options before calling rte_eth_dev_probing_finish > triggers an invalid port id error because of port state not set, or set > unused > > Fixes: fbe90cdd776c ("ethdev: add probing finish function") > Cc: stable@dpdk.org > > Signed-off-by: Radu Nicolau > Signed-off-by: Chas Williams > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c > b/drivers/net/bonding/rte_eth_bond_pmd.c > index fc4d4fd..1320cfd 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -3238,6 +3238,7 @@ bond_probe(struct rte_vdev_device *dev) > internals = rte_eth_devices[port_id].data->dev_private; > internals->kvlist = kvlist; > > + rte_eth_dev_probing_finish(&rte_eth_devices[port_id]); > > if (rte_kvargs_count(kvlist, PMD_BOND_AGG_MODE_KVARG) == 1) { > if (rte_kvargs_process(kvlist, > @@ -3257,7 +3258,6 @@ bond_probe(struct rte_vdev_device *dev) > rte_eth_bond_8023ad_agg_selection_set(port_id, AGG_STABLE); > } > > - rte_eth_dev_probing_finish(&rte_eth_devices[port_id]); > RTE_BOND_LOG(INFO, "Create bonded device %s on port %d in mode %u > on " > "socket %u.", name, port_id, bonding_mode, > socket_id); > return 0; > -- > 2.7.5 > >