From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-io0-f171.google.com (mail-io0-f171.google.com [209.85.223.171]) by dpdk.org (Postfix) with ESMTP id B4EB1F11; Tue, 4 Sep 2018 15:29:59 +0200 (CEST) Received: by mail-io0-f171.google.com with SMTP id n18-v6so2933350ioa.9; Tue, 04 Sep 2018 06:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:sender:from:date:message-id :subject:to:cc; bh=h3MC5wEzlxe7bgkpgeWr5EeYIxMSONSGDJGvurDByAU=; b=XtiumYsWBOpJjEJ9bj/z2EgNMSpk2Xm3dfZjP6nAt5Cr6SiLqyNLzRHs1XQjtiO+oY pvSwzr2gwVMXoXL/pohGIV5g19ZTt9bi3yHSqVs138v36MfMaS9DFbM8eJ3DzrA2UyOL Mve0nNURjrLMOmv2Tb61KikCUhiz6JAb3ufZax5l8hg9fphyy1t2qOOdCgjgKWJVs2MX SKHn9lSk7yrI0hCcl906Fl003RsemweIk+OosEfy8NH4BRpf3l1NKUwpnVgIa0sidhwd 9cETmyJ1ncqWjudz4SbAHt/BcGUC4owQgMEXfkvrTbaxWuyGjAMoza8SNk6wAE/zGlQz Zjbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:sender:from :date:message-id:subject:to:cc; bh=h3MC5wEzlxe7bgkpgeWr5EeYIxMSONSGDJGvurDByAU=; b=T7XfOmc0dbWLEwGTuNJYnSbctBbY71Zi3rjoasJ08xshSRbAQDQUd/9zTP8taBk59O Pp96aWGVnAoi5tsqnXivVypBF1EtNIMslzYdCCw9b3+YjSKM28NYoleb8JrYKyYBw8dk WZ+mJioiOcm8wp0ZE4F0YdneFnmwk3U7sgMkV7aXbxmRC9X7CRoowrFh8kLxtfQIxiuv ncfo6aaMstdW63CuL5zA0cAv8nV67p7z98Ex4XfcSYgbcmUCTgeGhNIW06F5tjI+pnOX Lz+x2ITP8y6Ng/ckEMjGZxSkUi0ap4z1tRFXcZqu1y2/zvoWHDAPbJMIzAVgIM0iHJoh LKYA== X-Gm-Message-State: APzg51BoRHAOxlgxmDE9Dtxy7f55zeraxE23d+JyjenIMif/gCRs5bRL eZgS6KqlY+cOQePQJh9XrCUCRvfjiqulaaSXflI= X-Google-Smtp-Source: ANB0VdYBWGY9qJpSu+hvW4m1uZM781VZnstCUOmhdXswAIo1CkOGOk+VHeP2dpunLghPKNb39nOaTAYLk9wxkhyqiME= X-Received: by 2002:a6b:1505:: with SMTP id 5-v6mr23105287iov.56.1536067799106; Tue, 04 Sep 2018 06:29:59 -0700 (PDT) MIME-Version: 1.0 References: <1535528910-2285-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1535528910-2285-1-git-send-email-arybchenko@solarflare.com> Sender: chasmosaurus@gmail.com X-Google-Sender-Delegation: chasmosaurus@gmail.com From: Chas Williams <3chas3@gmail.com> Date: Tue, 4 Sep 2018 09:29:47 -0400 X-Google-Sender-Auth: qtpbZrfDYph0uq5OYEM0ZqQX5QY Message-ID: To: arybchenko@solarflare.com Cc: Declan Doherty , Chas Williams , dev@dpdk.org, igor.romanov@oktetlabs.ru, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bonding: use evenly distributed default RSS RETA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 13:29:59 -0000 On Wed, Aug 29, 2018 at 3:48 AM Andrew Rybchenko wrote: > From: Igor Romanov > > Default Redirection Table that is set in bonding driver is distributed > evenly over all Rx queues only within every RETA group (the first RETA > entries in every group are always start with zero). But in the most > drivers, default RETA is distributed over all Rx queues without sequence > resets in the beginning of a new group, which implies more balanced > per-core load. > > Change the default RETA to be evenly distributed over all Rx queues > considering the whole table. > > Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") > Cc: stable@dpdk.org > > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko > Acked-by: Chas Williams > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c > b/drivers/net/bonding/rte_eth_bond_pmd.c > index b84f32263..0f5ab09e3 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -3293,7 +3293,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev) > for (i = 0; i < RTE_DIM(internals->reta_conf); i++) { > internals->reta_conf[i].mask = ~0LL; > for (j = 0; j < RTE_RETA_GROUP_SIZE; j++) > - internals->reta_conf[i].reta[j] = j % > dev->data->nb_rx_queues; > + internals->reta_conf[i].reta[j] = > + (i * RTE_RETA_GROUP_SIZE + > j) % > + dev->data->nb_rx_queues; > } > } > > -- > 2.17.1 > >