From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29CDAA09E5; Tue, 8 Dec 2020 10:58:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0850B72DE; Tue, 8 Dec 2020 10:58:14 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 84427A3 for ; Tue, 8 Dec 2020 10:58:12 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id a3so1784514wmb.5 for ; Tue, 08 Dec 2020 01:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mhsHEujrJhK+0+t1/8Tm4ruUD+ZBn+AMLrf6yJ0oJbs=; b=RyVtx28Hfz8J0H6DmI4XUW47HJjdTIsu4x0ucr+n29OyJkaPdLIy82GperGboVHKGj QXojN75Czsz70HyLjnb5W1Ct08Lo8LgVS4iYUcycYar8+fQtvLy5Ai/Tvy+QrncOtWIq 6whP3oau4Ij9ebHY3xPNgbpEk+qpsCsTDvC9aozX5/rKoasR+DpqR7Cyn8ccLDm5nzRp jJ7Pi6JAuccP4ILBofQUclb4cgQDBG67aQKp4bKa0S0S89DZHghyI7S7CYEG2iOz4Eij pIfgJ9FupSpvb2IsFgBbATyKRuSkH/WTK80j3uVh5+i9HTFSosIfiRLHjTMVMZyRNGch wgTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mhsHEujrJhK+0+t1/8Tm4ruUD+ZBn+AMLrf6yJ0oJbs=; b=mYDwSPL+sDPDJcWv8bK0XX0r1bJeIwSF5GAtpWQlo2O3vb58ILJYzhaIdptdGoGITV xVqsmzKBWshlsJEBx6j7aU5jhI9sUfO+EiJ5C6QHRJ3XXdClwalgzOK1ph1tYXs5J1Zm eiR8BzCBBWHDYs2pK7x1Zw7YBU+87bw3qxo4uumByh7XKZnvmg0U0kYTSnipunXvPLTF eF2bw5uyWNjDO+/6CyW+0vOXJ4ddpsFGYYxkpb0Y5aihGZHJa8ffH3ivxCl6rg/BaVjY //Hdd89zWtuGd3dHmQZOXhTWn4/KxD7UbVPbFHIGvR0t6VEHQTwgwxmHZx72VysdC4vW cZ8g== X-Gm-Message-State: AOAM5324S/4UNzUvj0BDhor7y1vyHE+JFbAXgAO/rD3uBZAUbq9Mi5Bp 1BMde2rTX7AfXhi+Kerr0zO6l4hI29wlAUnzI5QUYdUicuKm+g== X-Google-Smtp-Source: ABdhPJxVatxqbn7XUDaesB5YqJWzCWUzuCx6pTFqBm4fjFaubt1ReW3+txDCNqkEcffVoukHCxwkSCHBOtVZHri2Nvg= X-Received: by 2002:a1c:2203:: with SMTP id i3mr3070927wmi.6.1607421491338; Tue, 08 Dec 2020 01:58:11 -0800 (PST) MIME-Version: 1.0 References: <20201208081006.35125-1-benhaz1024@gmail.com> In-Reply-To: From: haz ben Date: Tue, 8 Dec 2020 17:58:00 +0800 Message-ID: To: "Wang, Haiyue" Cc: "ban, xiaozhen" , "Guo, Jia" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" my name is ban, xiaozhen. the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add? Wang, Haiyue =E4=BA=8E2020=E5=B9=B412=E6=9C=888=E6= =97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=885:04=E5=86=99=E9=81=93=EF=BC=9A > > -----Original Message----- > > From: banxiaozhen benhaz1024@gmail.com > > > Sent: Tuesday, December 8, 2020 16:10 > > To: Guo, Jia ; Wang, Haiyue > > Cc: dev@dpdk.org; banxiaozhen > > Subject: [PATCH] net/e1000: fix incorrect return value if filter type > not supported. > > > > From: banxiaozhen > > > > Signed-off-by: banxiaozhen > > The patch looks good. > > The name format should be like "Banxiao Zhen", and the commit message is > empty ? > > > --- > > drivers/net/e1000/igb_ethdev.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/e1000/igb_ethdev.c > b/drivers/net/e1000/igb_ethdev.c > > index 647aa8d99..8695426c2 100644 > > --- a/drivers/net/e1000/igb_ethdev.c > > +++ b/drivers/net/e1000/igb_ethdev.c > > @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev > __rte_unused, > > default: > > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported", > > filter_type); > > + ret =3D -EINVAL; > > break; > > } > > > > -- > > 2.24.3 (Apple Git-128) > >