From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49BD4A052A; Thu, 9 Jul 2020 15:57:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 456051E90A; Thu, 9 Jul 2020 15:57:05 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 4A8FC1E8F4 for ; Thu, 9 Jul 2020 15:57:04 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id s21so2092010ilk.5 for ; Thu, 09 Jul 2020 06:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QIFQ7FruTALkZa2jD+t4IXyfIaVNQr2VX2n8iv9hAlk=; b=Jc4C6Bx1Th+juer4TafJE5Tb3x+EQ4bGS6FRjcPzpFSYiL/9KQi/wHNhmp6HyGfAR+ O0oEDFFxtCoL+PUsaK/IJ7E9n0qvsDpMPT4IgyU4ZZtQZSdK7uNCKNYoGthjtCf8sxFI Y3ZKvmNne/ZGNAgaXmfQHDmMqweIyU7mTUD8icuGH4AAOUovZhaz85Dwa7nPrA7KrH/q Qo4HXl/FNW7upmAZDxvNO0bQcAzuMWdKlGOTR5luEgmjCcGomc7Zaii+XtXpzpgN/LsU mTNAduKaly1eGpHAMeTxhrZlzA6KggFStKumQ2dnD4zepyrSWgQmZuCPnThHl8OUcAk4 DP3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QIFQ7FruTALkZa2jD+t4IXyfIaVNQr2VX2n8iv9hAlk=; b=DOiiek1wNhWnfjK8cnL7LaLK3yRY3PxWwerqFbDaFGJk+96/xZOcCV/Gl7yUy1F1Tx Z9L/Y9c5Qdby0nOkdj7NxNs9T1YobjJluAEuEW3GlCDoCko/VBI0U+8P+Qrp+djwmjx5 lnDuFg9XpWqiTzRqDtsR5ITe00r890N+5+4VlwEvGuISKZeeenY5EUGLH9WTu0TgjfPJ i1B37DNchB/mO3FNZKB/XozulTfnZa0e6YLUUevRyrDQeD3dtaoDdACkc+0iScK9RIIn SzwCfQwG6LiabLvhm6ucfX/fKZvEWSTAG/u/QHmE9SlPZPZnTFPyCFLT6JidCLrlBueq qkHQ== X-Gm-Message-State: AOAM530VEQ8m/mySyLII9RcDgeZMb7ofPo8Ts14TG3wMExRBtrDaCJna +/8KrLWApa+b3sVraliZxK6/LGhcLctAZPA4eU4= X-Google-Smtp-Source: ABdhPJxIvFay4+U0BoJW+4JFmaK8mM0c/9weqAfsUqe0TWR2KjzSVoxGsygR0btAd7DSZgKXz96ibgcDcTfKIJ8e2KE= X-Received: by 2002:a92:c14f:: with SMTP id b15mr31572500ilh.288.1594303023498; Thu, 09 Jul 2020 06:57:03 -0700 (PDT) MIME-Version: 1.0 References: <20200707122516.28630-1-levendsayar@gmail.com> <20200709123216.47707-1-levendsayar@gmail.com> <1771788.WWZ8MmTXKr@thomas> In-Reply-To: <1771788.WWZ8MmTXKr@thomas> From: Levend Sayar Date: Thu, 9 Jul 2020 16:56:27 +0300 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Harry van Haaren Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] service: support C++ linkage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sure I agree Thomas. Thanks in advance. Best, Levend On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon wrote: > 09/07/2020 14:32, levendsayar@gmail.com: > > From: Levend Sayar > > > > "extern C" define is added to rte_service_component.h file > > to be able to use in C++ context > > It is a bug. > The title should be "service: fix C++ linkage" > And these tags must be added: > Fixes: 21698354c832 ("service: introduce service cores concept") > Cc: stable@dpdk.org > > If you agree, I can do the change while merging. > > >