From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13484A034F; Tue, 23 Mar 2021 07:22:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78E8A4014F; Tue, 23 Mar 2021 07:22:10 +0100 (CET) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mails.dpdk.org (Postfix) with ESMTP id 4E98340143 for ; Tue, 23 Mar 2021 07:22:09 +0100 (CET) Received: by mail-ed1-f43.google.com with SMTP id o19so22084788edc.3 for ; Mon, 22 Mar 2021 23:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DBKwdo4R+7Lp/TT/Wl3CKiF/koRTrz4McreKod1Cp8E=; b=gxM4pcnHgm3WVAdNlPaIlOAlD3rVRDavyiyl5VJvbSTUt0aRW630qcbJMK+NyLfwJ2 MUqSxAkia+3Bnvl0aPClJZTNhby2UJ945Io9v1g8nF82wSyBoALl36wf2V6daaDgokGt cwQx974sKYfyt3YfEszSRCA0jC8mpINajsQQqJtbQpQRp0fHdGc36ibmA1rD9GuPc0hd E5QKlcz78+mwfeZDx4zjaU7jI6IvmL81uhsBlCnIpnv89OcWGPxFZSJSI6VJoOEJH8RO 0NwOal7VQ3uAkXxmX2Lj82wpkjYO2gZ897iIq4OL3qDHSdXTwngJDcz2ftqmafdo++wK h9pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DBKwdo4R+7Lp/TT/Wl3CKiF/koRTrz4McreKod1Cp8E=; b=RSrA3XxgWHYyvRPqA7X8iT6AXUFfCXq3qRnUnzr/tP30Ov5fMIHF+2u6i8WWLoXO6H L0oJoh3ZdIgjW5jI+CJnZVus0dpCEm7dXKrtQZF7Yiz8j5CiUBu6W39Oi9rTZczvwDy7 4+/AwzmLcflmrH5rH95IvNgjG6sXrUEB7Pun6YFStsN4phaGOQvXXYCGxNySXbM5mKFN zD9TovSgOhOJGuOEgC2CyLRbueF3akcBnlLU18AamXCIwnfzZEFirCQ3Xc1VgXKNawno GSxGsYeYWmNm889nFyPN7hjZTVKL/tXVLvlrJPJ9wgLTeP0ZVwTtBd1vhUe2Oe4F3fIc FNug== X-Gm-Message-State: AOAM533DE9+Byjiel/XrT1EOB4VQevZkPyXJKcP3zOk+PdhqCNzB60O8 QbHYQntcV0tCqww0u1bnyTjsoaYelErwUUymdfsT/w== X-Google-Smtp-Source: ABdhPJxBD/NziUKJ9b5HW/p5hwOmaRHgNXPRHBY+k8aN5tt8eFDJkD/CAXRiZzvxzvaB1yAUOx0/F4jnWtoyqbNR7dg= X-Received: by 2002:a50:eb8f:: with SMTP id y15mr2974504edr.115.1616480528983; Mon, 22 Mar 2021 23:22:08 -0700 (PDT) MIME-Version: 1.0 References: <20210322083901.22493-1-gabriel.ganne@6wind.com> <20210322093421.GA1440@bricha3-MOBL.ger.corp.intel.com> <20210322182557.4dd1261b@sovereign> In-Reply-To: <20210322182557.4dd1261b@sovereign> From: Gabriel Ganne Date: Tue, 23 Mar 2021 07:22:00 +0100 Message-ID: To: Dmitry Kozlyuk Cc: Bruce Richardson , dev@dpdk.org, Olivier Matz , Thierry Herbelot Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thanks for the review. I have some reservations about those TODO: they are about rewriting the same functionality with a newer meson feature. No functional change is expected. => Why not write a commit that implements such a TODO and bumps meson version at the same time independently ? In any case, I aimed to set meson's required version to the lowest possible value so that distributions would have a chance to provide it. I know we can just install meson using pip, but it might be nice not to need this. Below are some versions of meson packages as of today: pip: 0.57.1 rhel-8: 0.49.2 debian-10: 0.49.2 ubuntu-18.04: 0.45.1 ubuntu-20.04: 0.53.2 Going over 0.49.2 will cause DPDK to lose some major distribution's stable release, at least out-of-the-box through their respective package manager. I propose to bump to 0.49.2 here, and leave the TODOs to wait a little longer. What do you think ? Best regards, P.S. get_linker_id() seems to be introduced in 0.53 See: https://mesonbuild.com/Release-notes-for-0-53-0.html#compilerget_linker_id On Mon, Mar 22, 2021 at 4:25 PM Dmitry Kozlyuk wrote: > 2021-03-22 09:34 (UTC+0000), Bruce Richardson: > > On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > > > WARNING: Project targetting '>= 0.47.1' but tried to use feature > introduced > > > in '0.48.0': console arg in custom_target > > > > > > console argument is used within kernel/linux/kni/meson.build > > > > > > Signed-off-by: Gabriel Ganne > > > --- > > > meson.build | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meson.build b/meson.build > > > index 7778e18200a9..65c46f051365 100644 > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -8,7 +8,7 @@ project('DPDK', 'C', > > > files('VERSION')).stdout().strip(), > > > license: 'BSD', > > > default_options: ['buildtype=release', 'default_library=static'], > > > - meson_version: '>= 0.47.1' > > > + meson_version: '>= 0.48.0' > > > ) > > > > > > > No objection to this on my part. Rather than bumping to just 0.48, I > think > > we might as well jump a couple of versions. For example, 0.49 adds > support > > for "break" and "continue" keywords which could allow loop > simplification. > > Beyond that, it's a matter of how up-to-date we want to be... > > FYI, recalling some TODOs and which versions would allow to resolve them. > > From https://mails.dpdk.org/archives/dev/2021-January/196000.html: > > A script to extract object files from library is still required. > Meson has extract_all_objects(), but they can't be passed as inputs > to custom_target() until 0.52.0 (commit f431cff809). > > buildtools/meson.build: > > # TODO: starting from Meson 0.51.0 use > # python3 = import('python').find_installation('python', > # modules : python3_required_modules) > > config/meson.build: > > # TODO: use cc.get_linker_id() with Meson >= 0.54 > is_ms_linker = is_windows and (cc.get_id() == 'clang') > -- Gabriel Ganne