From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id EEE1B23A for ; Fri, 25 May 2018 15:20:43 +0200 (CEST) Received: by mail-qk0-f193.google.com with SMTP id d125-v6so4012563qkb.8 for ; Fri, 25 May 2018 06:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EhSgiJcsQ+oo8hjZnuOhsIFxopLYxplkzMPH+Z2Ps68=; b=amHJQjLptwjNOcZqW6c+GGeONt0eoawn3FyHR/i8TI/LeUy3HbAAT6BEuTYkIT60MC UPhh5NXrE9CAUe/AEUc6+NiG6m5nODIu1QUrXv5fqPChDmPD9KPiie4x6aXW0ySzp+A8 sCLrCPDHsR5f/bF9vGAQM6JbxDvIWW3BzfTzJgA6ZMQCXBcwSSSMF4RFq63HGiVHEJmL ZQXrgMDeoWBon2ex/pKlskEASfUSLmZj0FC5yqLmW1FCe0q79+hlzsY0ZOTckXIEvbiU VS0GOxKZAcjz/7fHEu1+XIid3e2BxIxLWVrdfj0opPGgc5cbNPJm9qFJcKzGZQkAiQaU tn0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EhSgiJcsQ+oo8hjZnuOhsIFxopLYxplkzMPH+Z2Ps68=; b=bBDm8WLLcvCOno9uZc17mJhguCeVFiDrxXCedyD4UqccO9kT6ov1fTPOVbLwBQ/wSg Qz/z+IT6KfDOKJr3pcIZrTKO5Zse1+zyt+FXYxK5zBkDZsyC/sfOEwSN4MqZhjfXejC8 ejTE84QvBY7qgWFtwtgFUy4CoQ/5wuSyKrCwM7QfZv2IY+UXbWHLEJmSK3EJRx7VlIuM MHYcrE9aXoSxNAmCNC92h0Cq/2uQqIXwnK7RcKIGDUEJejfvj6Cg/OzR4JnAIVGhHkI4 vaZfbvfEJ+nt8q6W4RFWY3oxgnUFYYS+d572Az3rmwcwK40wcEHpl65HHVI0p1q2Suo6 mNaA== X-Gm-Message-State: ALKqPwfak1airtkxss078IM2sif/2ccX8SxtO4sBkEcbHfiUdxVPdu1R 5Kp5XsiXcvfcuKSzm12U0UntnF5507gRnYeiRRGUDA== X-Google-Smtp-Source: ADUXVKLGhDNFxlFAzKkqtdEbIuoRpkUbARKnn6HrpnL+zF6W3UkhuJCkh6mzQQYPD+q8uXdc6f5Q/6d5N97UOoCutEg= X-Received: by 2002:a37:b243:: with SMTP id b64-v6mr1894722qkf.21.1527254443363; Fri, 25 May 2018 06:20:43 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:3843:0:0:0:0:0 with HTTP; Fri, 25 May 2018 06:20:42 -0700 (PDT) In-Reply-To: <2384240.a6VFuv6gqB@xps> References: <2384240.a6VFuv6gqB@xps> From: Kevin Wilson Date: Fri, 25 May 2018 16:20:42 +0300 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Kernel Module dependency in DPDK 18.05-rc5 and earlier DPDK releases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 13:20:44 -0000 Thanks, Thomas. Actually there is an EAL rte_eal_check_module() method which does this exactly: http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal.c#n1089 It is declared in eal_private.h. Is it reasonable to send a patch which moves the decalartion to eal.h instead so PMDs can use it in their probe() method ? Apart from it - So is there any practical effect for using the RTE_PMD_REGISTER_KMOD_DEP() ? or is it only a sort of declarative macro, saying that the PMD is dependent on the specified kernel modules ? In the past - did it really ever check for dependency and shouted back when the required modules specified in the RTE_PMD_REGISTER_KMOD_DEP() macro were not found ? Regards, KW On Fri, May 25, 2018 at 2:21 PM, Thomas Monjalon wrote: > 25/05/2018 11:55, Kevin Wilson: >> Hi, >> >> I am facing the following issue in DPDK 18.05-rc5 (I saw it also with earlier >> releases of DPDK from the last year). The issue is with defining >> dependency on a kernel module in a PMD. >> I want to develop a PMD which requiers that before running DPDK app which >> uses this PMD, a specified kernel module is required to be insmoded. >> I tried to add a call to RTE_PMD_REGISTER_KMOD_DEP in my PMD, >> specifying a required >> kernel module, and I expected that when calling a DPDK app which uses >> this PMD it will shout that such a kernel module is not loaded, but this did not >> happen. > > No such check is implemented currently. > You can try to implement a check in EAL in the probing function. > > >