From: Matteo Croce <mcroce@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] Statistics consistency
Date: Wed, 13 Mar 2019 15:31:27 +0100 [thread overview]
Message-ID: <CAGnkfhzq8BfQNPBHFg-F6Nu=64s37wusegiXq3kwDMPWPpphAg@mail.gmail.com> (raw)
Hi,
I noticed that the statistics field for short packet is spelled
differently between drivers:
src/dpdk$ git grep -E '"rx_undersized?_errors"'
drivers/net/e1000/igb_ethdev.c: {"rx_undersize_errors",
offsetof(struct e1000_hw_stats, ruc)},
drivers/net/i40e/i40e_ethdev.c: {"rx_undersized_errors",
offsetof(struct i40e_hw_port_stats,
drivers/net/ice/ice_ethdev.c: {"rx_undersized_errors",
offsetof(struct ice_hw_port_stats,
drivers/net/ixgbe/ixgbe_ethdev.c: {"rx_undersize_errors",
offsetof(struct ixgbe_hw_stats, ruc)},
Is this an intended behaviour? Should the fields be aligned?
Regards,
--
Matteo Croce
per aspera ad upstream
reply other threads:[~2019-03-13 14:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGnkfhzq8BfQNPBHFg-F6Nu=64s37wusegiXq3kwDMPWPpphAg@mail.gmail.com' \
--to=mcroce@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).